From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A62D364959 for ; Tue, 21 Jul 2026 16:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784652576; cv=none; b=roSKpnbuDOBAfXl2xExY/6xC6UxUWEQCzVnqh/TpP7+TCYHpZDEAB/X52yE8YuPQ/1lMm4ttvXJ9txAD27UoGaogTMTW5IRQ44d/WmyXWu0Y4S549JI1um9afb0xlWeKbFQ/Mxa92pvaiG+6Wnpg9Vo/3DqAkOSTqp4p2utUYhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784652576; c=relaxed/simple; bh=zNHnVTypKgfgvOficguWFVlpkvG6iHharcWR4PswgHQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NTGGIfvFPui2mLq/S9+QPAjfMhCf/5WQ1YVCX7i58dTQAssmt/N5T/5xqgsWKqQFZox3k2NjhY/nXU9O2cnW3LX3vEbcpRPzw/h7zhU08HT3f5ZopHDcnuvjt5vjwS/0jUxMIbRR11QYxynGoSXESnpBKJ9O8YDxDNn7N8NC+8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IRWq4jR5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZJgCtKEG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IRWq4jR5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZJgCtKEG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDgGIY1399806 for ; Tue, 21 Jul 2026 16:49:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0KLaMb5Nn+c0pJrhabC4RdLZ94OtddIVgvprkhAXtwA=; b=IRWq4jR5tAK1Lj+X tgfzvYcl1EeXV6L3DdGAmq1XSvUOyvGr2C+UwmCgfQf3jLKW7G1NWIy/V+ICxU1H TdIcasyApCI3jcORv0gj4gvZno83PyURstN5cDrwRXCeusSYfgNPJBXROfKay5ZE J87A4J1ctzO+Y4IEaYG0PYveP1CARGoUyDn9xQXZ6XIWf7QVBn2IeacQ1r1OapS2 ysaMnzLCynGXNDtvtzZ2J1YAQtVHMjvi9bWrqZIBne+TwLWlHawGx7qPDijaj8ii sdjxepTiuFJXbOxaUM+/3WPtUTUgwpp1Ltz2SrCmyebh1vtAUZVRA17tnpieCvoN azHKAg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1es3jfq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 16:49:34 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ca5d2474c7so210791695ad.2 for ; Tue, 21 Jul 2026 09:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784652574; x=1785257374; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0KLaMb5Nn+c0pJrhabC4RdLZ94OtddIVgvprkhAXtwA=; b=ZJgCtKEGHS53V4JTD/KsV9314exWZnzzCw9Ay8yEzQdeYcgknTfiUOMXLz4qF2H7hN pQ3D7VwGZ8tipFn68ypYB5b2UVXM+jJN8UhHWM+ytFmMsR9fPEQimMJlx8kDknk2rt+x lv/RkNHmcDGGGZTpGfn/mPmNr3aWk6gttcdqYziyv/qJuj0OXIn9R2LHxYXz+ewA8scq f+EAUvpyZqMf66gnSto83kLeoYttAgoDFDff8iDFq1TTcXvZix86rEB/nW6NxVAuZGRW bxQ8bputAGl4Xm7gH3Rgsn4+2SvcoKtD7RlWVQr5Uwf5Dp8XDC3H3p13Lhn6o+vRHTph lPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784652574; x=1785257374; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0KLaMb5Nn+c0pJrhabC4RdLZ94OtddIVgvprkhAXtwA=; b=o7AacyT9h7p/AtBSEe4YCu1FxWbnOik8XWuP6x7Yb1m4vAitDuLjqrGOyLaNXMqvnE pOsM/7pEpIyrG9CGK7ZmW4dHR0Xtm8izSM77aLL4k49H4QTj0A+47nGmDXG7cJcb1zWY NzqFQRKPlT3xY1apky7cHD29+Jzb2TYlLzuKxR1d1Igb/tOK+/MzwZnNI3xNcLRUkOPn RKONcG7Bqr1KKPfGmgzmPuRFr3Tfxy362wGohl0v6iQMJ4e7D2RN99IyoiDUE4lKYMbE fCpqrhc17OwUMLbBLUdfEZ33I/yBwrKGA3ABX4i2ldtjc53nm4RUxA5tA5jZcO2irSD9 NHeA== X-Forwarded-Encrypted: i=1; AHgh+RqYBOmGXzpWRBOhLEqVpAyr3Wk1oKE73c8/exQXx4VFe7/P7uGp63seFZBOnB0a4otvnyJ+tML7tCwI@vger.kernel.org X-Gm-Message-State: AOJu0YwxCjafyRGJ5IMHgQbCSCQk7NTUEEX91N3F4n6/NrE40OcDKrg1 ximb7+qW+nm/lhYU5uINj5EwDAKAfx36uL8X9HNfZ1bkQTtgUdd3Sd9l4Ir8YN7WmrYH+PR49az eBx4AX64stn6Zx04pNoBO1XV5gSnG4R19eJV6fu2JmDvQsemw9CueJP3JdiPcDLNA X-Gm-Gg: AR+sD10zFtFJwDjp5br96is9fBVvCJbBgrCIunaRAzMZ8H3bJD2ZvF6PRkl1h+ChLkU La+ySewlmvzgUIKjujFbgKjtS/8Z85DUe3hsXrpbVTftglTLRDmWHPFw5avfMEEC1Rr/lmWPF5/ +srT1e8zhHr9iKlIcbptamMjFv+Q0FXg6vNWMCLEqiUHXe9KWA3Ligqe3odnMZ61Imp4iYs5UV0 FnHJVNSEIPXHko6eFLEOJVVJD2sQCdQKy82aTS+sM/QQSJFz/jSWJPUGN0MJEENqaJ59HPaOKD8 5D4pdDr2GlxTo0GA3E+C/lZoia9bvfDWR2NOKZV4s8/G5jnLlf5Vpp/OQMFvU5ZD4zIxUeORxUk 3FWEQpVA1DVVIqgK5QVxTRS+t/gSUKbkn X-Received: by 2002:a17:902:fc8f:b0:2cf:4544:104b with SMTP id d9443c01a7336-2cf45441560mr173412885ad.5.1784652573789; Tue, 21 Jul 2026 09:49:33 -0700 (PDT) X-Received: by 2002:a17:902:fc8f:b0:2cf:4544:104b with SMTP id d9443c01a7336-2cf45441560mr173412665ad.5.1784652573307; Tue, 21 Jul 2026 09:49:33 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a67esm684593eec.2.2026.07.21.09.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 09:49:32 -0700 (PDT) Message-ID: Date: Tue, 21 Jul 2026 22:19:27 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v9 01/14] dt-bindings: media: qcom,glymur-iris: Add glymur video codec Content-Language: en-US To: Rob Herring Cc: sashiko-reviews@lists.linux.dev, conor+dt@kernel.org, devicetree@vger.kernel.org References: <20260715-glymur-v9-0-8cf2cbe12a07@oss.qualcomm.com> <20260715-glymur-v9-1-8cf2cbe12a07@oss.qualcomm.com> <20260715142224.5FA721F00A3A@smtp.kernel.org> <20260716165434.GA290489-robh@kernel.org> <7bec94ea-a5b9-be03-0e40-5de8262d2197@oss.qualcomm.com> From: Vishnu Reddy In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=SPZykuvH c=1 sm=1 tr=0 ts=6a5fa31e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7CQSdrXTAAAA:8 a=yb9WwcpXJQ139jM9Wo8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: DGesVhvC87GwGJaFjSNZYU8dGuQZktEW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE3NyBTYWx0ZWRfX2Yg2ZzJNentB vr5TMTR9/OgS+mQtcc3GSR0WRw3IPxKIg9NidjVUsUNl0FuHKhkOtBsLlPIq/52Ho5Z6vwjZgnL lmO5ow0ILYBmF31eWzh/+ZvsZrqSXuaC6WwnfvvpM7lime+FZYsxj3g9PBZXOW9rCEsDXC6FVMW S1eV0H+KAnbfJMcibeLUsQhohDQUOzUWfIsD6bnivrXXpTjdccW7SjWy02dqKcfcVaMka09nVMU J5EuI5hWbcKU62rjCOpwye+TfKZtCumwtINQdtRA1+lqcohnFbRVo7AeTX+5k6QsE5oa98UIybD /gbHj+jUj4Uado0+KAi4oFoMXgRH9d5A4ZH6L8Z4dxJvmnOyZ2FjaeFw0O8pbrTVjZxTLMS2e6t cbPz/6WUa3sMK5cIKtWce9gf9GAj0LN6uNkb8PXOkkXbakY8LJQDq0cW+epxnDfWVMJNMwGhHZf H+7reX6oZvtjzjBUImw== X-Proofpoint-ORIG-GUID: DGesVhvC87GwGJaFjSNZYU8dGuQZktEW X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE3NyBTYWx0ZWRfXxBmO6jHKfaBY eiP3rJgTOyxo9A0lD5RVKJKJeWy21hRd3esa56g6GfAoPrPi2puSc/hv/eQcTDSBpmeMvb4LYap lpDETLqtAj4xfAcqPBW3Q7mJXshpqTw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210177 On 7/21/2026 7:50 PM, Rob Herring wrote: > On Mon, Jul 20, 2026 at 8:00 PM Vishnu Reddy > wrote: >> >> On 7/16/2026 10:24 PM, Rob Herring wrote: >>> On Thu, Jul 16, 2026 at 08:37:17AM +0530, Vishnu Reddy wrote: >>>> On 7/15/2026 7:52 PM, sashiko-bot@kernel.org wrote: >>>>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: >>>>> - [Low] Unnecessary `#address-cells` and `#size-cells` properties on a node without addressable children. >>>>> -- >>>>> >>>>> --- Patch [1]: [PATCH v9 01/14] dt-bindings: media: qcom,glymur-iris: Add glymur video codec --- >>>>> commit 8ca344fa9395fcf1d13bd1ea93de8bee21a5c176 >>>>> Author: Vishnu Reddy >>>>> >>>>> dt-bindings: media: qcom,glymur-iris: Add glymur video codec >>>>> >>>>> This commit adds the device tree binding for the Qualcomm Glymur Iris video >>>>> codec. It introduces a new dual-core architecture requiring additional >>>>> power domains and clocks, and updates the maxItems limits in the common >>>>> venus schema to accommodate these changes. >>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml b/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml >>>>>> new file mode 100644 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml >>>>>> @@ -0,0 +1,255 @@ >>>>> [ ... ] >>>>>> + interconnect-names: >>>>>> + items: >>>>>> + - const: cpu-cfg >>>>>> + - const: video-mem >>>>>> + >>>>>> + '#address-cells': >>>>>> + const: 2 >>>>>> + >>>>>> + '#size-cells': >>>>>> + const: 2 >>>>> [Severity: Low] >>>>> Are these properties necessary here? The schema strictly enforces const: 2 >>>>> for #address-cells and #size-cells at the root node, but none of the child >>>>> nodes (non-pixel, pixel, firmware) define a reg property, and the parent >>>>> does not define a ranges property. >>>>> >>>>> Will this cause the DeviceTree compiler (dtc) to emit an >>>>> avoid_unnecessary_addr_size warning when compiling device trees using this >>>>> node? >>>>> >>>>>> + >>>>>> + non-pixel: >>>>>> + type: object >>>>> [ ... ] >>>>>> + resets = <&gcc_video_axi0c_clk_ares>, >>>>>> + <&gcc_video_axi0_clk_ares>, >>>>>> + <&videocc_mvs0c_freerun_clk_ares>, >>>>>> + <&videocc_mvs0_freerun_clk_ares>, >>>>>> + <&gcc_video_axi1_clk_ares>, >>>>>> + <&videocc_mvs1_freerun_clk_ares>; >>>>>> + reset-names = "core_bus", >>>>>> + "vcodec0_bus", >>>>>> + "core", >>>>>> + "vcodec0_core", >>>>>> + "vcodec1_bus", >>>>>> + "vcodec1_core"; >>>>>> + >>>>>> + #address-cells = <2>; >>>>>> + #size-cells = <2>; >>>>> [Severity: Low] >>>>> Does the example need #address-cells and #size-cells? It demonstrates their >>>>> use without any child nodes containing reg properties, which directly causes a >>>>> dtc warning during dt_binding_check validation. >>>> Without #address-cells and #size-cells, getting the below kernel warning prints. >>>> [ 6.953615] Missing '#address-cells' in /soc@0/video-codec@aa00000 >>>> [ 6.968288] WARNING: drivers/of/base.c:115 at of_bus_n_addr_cells+0xa4/0xf4 >>>> >>>> [ 7.440909] Missing '#size-cells' in /soc@0/video-codec@aa00000 >>>> [ 7.447044] WARNING: drivers/of/base.c:142 at of_bus_n_size_cells+0xa4/0xf8 >>> Then the kernel is wrong. >> Hi Rob, >> >> Looking at the iris DT node from the link below: >> https://lore.kernel.org/all/20260715-glymur-v9-13-8cf2cbe12a07@oss.qualcomm.com/ >> >> The iris is the parent node and non_pixel is the child node, which does not >> have a reg property, but does have a memory-region reference containing >> iommu-addresses. During of_translate_dma_region, #address-cells and >> #size-cells are required from the parent node for address translation. > iommu-addresses in the reserved memory node would use > #address-cells/#size-cells from that node. of_translate_dma_region() passes the device parent node to get the #address-cells and #size-cells. In this case, the device is non-pixel and parent node is iris. > IMO, you shouldn't even have 'pixel' and 'non-pixel' nodes. Their > contents belong in the parent. Regarding about pixel and non-pixel nodes, it has been discussed in detail on the need of it. https://lore.kernel.org/all/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@kernel.org https://lore.kernel.org/all/f61a0a67-2cb5-4fac-818e-70eb9ed69f95@arm.com > Rob