From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90851A5BA for ; Mon, 22 Jan 2024 08:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705911036; cv=none; b=uHC1SkhA68FEFnHoof8kDostm12RmLAoddswSsRarqXChxeZlp6aFBdI40g+PuyKdvXWjJ8DBKkYeXF1ZqedebbKEld92A3DhF2gWHPQufiVbBpH0Y0ZrDkKRBlUuGtkX5G+YFJpOym26KSdgjBFBcgMDCSPuRzggM1r37UHve4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705911036; c=relaxed/simple; bh=4AnFFHs4L2etbgi2lL/rzxE/qe0JIVFa02Bny/FL0DE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=lVYhiu+hw/9RNf+lfHkctybye+ZwZNXXTwi7dtTE3U1IgYEg9Th8pgk22G+32H//NRBIoeRVsnZDFDXYNJNxZr8w4Td2kiJC2bbxY2S0IU4kAOtlulmJJtj0vBZp1frUjF1nqpwjsRZXTwi8FABNCrQh2WPdRscgRsCiwPIoWTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Shl3N3x7; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Shl3N3x7" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40e60e135a7so28984635e9.0 for ; Mon, 22 Jan 2024 00:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705911033; x=1706515833; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MbaUIqrMbMzTbi1xbIh7iOYXgE0LxrEe6wcimnzPid8=; b=Shl3N3x7OcZn6vi90K3zb1ieONQMz60djjcmdMYj11crzQISX6WA/HY6gpSay15yRD yEaq77dRPLCF5J6E0yk6e5KPehBANJrbGgKQ5n+/kHgcmj+u7KG1xpO5BpJH9BDLVRns x87FFmUl9PxcK29vtH+r2Msy5useK7djsiTg5/WxaEyeooV+LM+geos3QP+G63lZHDgN LLr2eaGNNKUPQdcCXpEg3A4XiXEHDo5fZ1pBi271aT9ZhQ8gfzLk8U/B/KUKzGYRyN2S xnQFY8STJaUtameUQkCp80ZVtTvqknbZe53yTIw8FO6inojgKOf3O4t95VmLqt/tI0hm kt7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911033; x=1706515833; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbaUIqrMbMzTbi1xbIh7iOYXgE0LxrEe6wcimnzPid8=; b=eatR8pTQ9G4tfImamQpuS5+6zQdxhINEYlTzIP5ODiSXyogbAmf1DmRoJH9jD81D08 RsnCRPOa1DstgACbSfZXc60gR/11W9pWNtJ2EzJTBpqVzn+wnpGZnKhbHZiigZETbpyz lDLjDsFY/BlwedMJvNu4hsMvykztSL1wez+xlKe2n9UUCr++YE6VolmMk7FeM1UjwVT+ kucMCTF7YoczI+jZqQfn4UGURMmJVH4hA00xdlc+AtWxoR739WINlT2C1y/J9TORaZqg nZ6bhI2o4kNAhjyz8dnufmwQoBjyohqExdmTgxVF6lCmdbFXTc8cfmRQ2YgyEHawH8pj Bz7A== X-Gm-Message-State: AOJu0Yxl17CtXCy+KEVG/X2n0px9px6WsXjIEECpXeU07cshzY5/iAWd GkMSn6aqO60oW0cUbes+mwNXXfpeo9UHlE0wgeoVLbcghA0LOKvnWEz5jHhtKRU= X-Google-Smtp-Source: AGHT+IF4zVESZieddWNU7+k8H1J80F/kOzh4atr1ez8O2h+FXPc5tEeCGo/qorFc5eG8W9X+yLPltg== X-Received: by 2002:a05:600c:2108:b0:40e:40fc:6d43 with SMTP id u8-20020a05600c210800b0040e40fc6d43mr2407442wml.98.1705911033033; Mon, 22 Jan 2024 00:10:33 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id bh11-20020a05600c3d0b00b0040eabc7cfacsm3912080wmb.16.2024.01.22.00.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 00:10:32 -0800 (PST) Message-ID: Date: Mon, 22 Jan 2024 09:10:29 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/5] dt-bindings: soc: sophgo: Add Sophgo system control module Content-Language: en-US To: Chen Wang , Chen Wang , aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com, richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org, jszhang@kernel.org, inochiama@outlook.com, samuel.holland@sifive.com References: <598b1026fdf9989bc48e5e10d1034b37947d3b80.1705388518.git.unicorn_wang@outlook.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/01/2024 06:29, Chen Wang wrote: > > On 2024/1/16 19:37, Chen Wang wrote: >> >> On 2024/1/16 18:06, Krzysztof Kozlowski wrote: >>> On 16/01/2024 08:21, Chen Wang wrote: >>>> From: Chen Wang >>>> >>>> Add documentation to describe Sophgo System Control for SG2042. >>>> >>>> Signed-off-by: Chen Wang >>>> --- >>>>   .../soc/sophgo/sophgo,sg2042-sysctrl.yaml     | 46 >>>> +++++++++++++++++++ >>>>   1 file changed, 46 insertions(+) >>>>   create mode 100644 >>>> Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml >>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml >>>> >>>> new file mode 100644 >>>> index 000000000000..7b50bb56b4cf >>>> --- /dev/null >>>> +++ >>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml >>>> @@ -0,0 +1,46 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: >>>> http://devicetree.org/schemas/soc/sophgo/sophgo,sg2042-sysctrl.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Sophgo SG2042 SoC system control >>>> + >>>> +maintainers: >>>> +  - Chen Wang >>>> + >>>> +description: >>>> +  The Sophgo system control is a registers block (SYS_CTRL), >>>> providing multiple >>>> +  low level platform functions like chip configuration, clock >>>> control, etc. >>>> + >>>> +properties: >>>> +  compatible: >>>> +    const: sophgo,sg2042-sysctrl >>>> + >>>> +  reg: >>>> +    maxItems: 1 >>>> + >>>> +  clock-controller: >>>> +    # Child node >>> Drop the comment, it is obvious. It cannot be anything else. >>> >>>> +    $ref: /schemas/clock/sophgo,sg2042-sysclk.yaml# >>>> +    type: object >>> Why isn't this merged here? You do not need the child node really... >>> unless the clock inputs are specific to that clock controller and you >>> will have here more devices? But where are they in such case? >> I don't see more devices will be included later. It should be ok to >> merge them into one. > > hi, Krzysztof, > > After some double check, I find we will have more devices in > system-control. For example, in the SYS_CTRL area, there is also a > section of registers used to control the "General Purpose Interrupt". > The pcie controller of sg2042 will use this interrupt controller which > is defined in SYS_CTRL, we will add it in later work. > I expect then all devices to be documented. Best regards, Krzysztof