devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 00/11] F(x)tec Pro1X feature expansion
@ 2024-07-31  6:18 Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button Dang Huynh
                   ` (11 more replies)
  0 siblings, 12 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

This patch series expand F(x)tec Pro1X (QX1050) device tree to support
various components of the device.

Most notably:
+ SD Card slot
+ Touchscreen
+ MDSS, DRM display panel
+ WLAN (ATH10K)
+ Hall sensor and camera button

This patch series has been tested on Buildroot Linux with TQFTPSERV and
RMTFS present in userspace.

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
Changes in v3:
- Fix dtschema errors
- Reorder gpio nodes by it's number
- Link to v2: https://lore.kernel.org/r/20240725-qx1050-feature-expansion-v2-0-5fac4bbd946f@riseup.net

Changes in v2:
- Squash copyright year commit to the hall sensor commit
- Reorder pinctrl-n and pinctrl-names in several commits
- Use interrupts-extended for touchscreen
- Add further information to the caps lock LED node
- Move status property from &wifi to the end of the node
- Link to v1: https://lore.kernel.org/r/20240722-qx1050-feature-expansion-v1-0-c4d486435b96@riseup.net

---
Dang Huynh (11):
      arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button
      arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander
      arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen
      arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED
      arm64: dts: qcom: sm6115-pro1x: Enable SD card slot
      arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU
      arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS
      arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property
      arm64: dts: qcom: sm6115-pro1x: Enable RGB LED
      arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs
      arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 343 +++++++++++++++++++++++-
 1 file changed, 334 insertions(+), 9 deletions(-)
---
base-commit: 41c196e567fb1ea97f68a2ffb7faab451cd90854
change-id: 20240722-qx1050-feature-expansion-7f6a2682f2ea

Best regards,
-- 
Dang Huynh <danct12@riseup.net>


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v3 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander Dang Huynh
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

The Pro1X has a flip keyboard and a single-state camera button.

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 34 +++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 4a30024aa48f..70f479a63f2e 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 /*
- * Copyright (c) 2023, Dang Huynh <danct12@riseup.net>
+ * Copyright (c) 2023 - 2024, Dang Huynh <danct12@riseup.net>
  */
 
 /dts-v1/;
@@ -35,9 +35,25 @@ framebuffer0: framebuffer@5c000000 {
 	gpio-keys {
 		compatible = "gpio-keys";
 
-		pinctrl-0 = <&vol_up_n>;
+		pinctrl-0 = <&hall_sensor_n>, <&key_camera_n>, <&vol_up_n>;
 		pinctrl-names = "default";
 
+		hall-switch {
+			label = "Hall Switch";
+			linux,input-type = <EV_SW>;
+			linux,code = <SW_KEYPAD_SLIDE>;
+			gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>;
+			debounce-interval = <90>;
+			wakeup-source;
+		};
+
+		key-camera {
+			label = "Camera Button";
+			linux,code = <KEY_CAMERA>;
+			gpios = <&tlmm 18 GPIO_ACTIVE_LOW>;
+			debounce-interval = <15>;
+		};
+
 		key-volume-up {
 			label = "Volume Up";
 			linux,code = <KEY_VOLUMEUP>;
@@ -212,6 +228,20 @@ &sleep_clk {
 
 &tlmm {
 	gpio-reserved-ranges = <0 4>, <14 4>;
+
+	key_camera_n: key-camera-n-state {
+		pins = "gpio18";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+
+	hall_sensor_n: hall-sensor-n-state {
+		pins = "gpio96";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
 };
 
 &ufs_mem_hc {

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31 11:05   ` Caleb Connolly
  2024-07-31  6:18 ` [PATCH v3 03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen Dang Huynh
                   ` (9 subsequent siblings)
  11 siblings, 1 reply; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

F(x)tec Pro1X comes with PCA9534 IO Expander, it is used for enabling
touch screen VDD/VDDIO and keyboard's caps lock LED.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 70f479a63f2e..47e446249af6 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -70,6 +70,23 @@ &dispcc {
 	status = "disabled";
 };
 
+&gpi_dma0 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+	/* Clock frequency was not specified downstream, let's park it to 100 KHz */
+	clock-frequency = <100000>;
+
+	pca9534: gpio@21 {
+		compatible = "nxp,pca9534";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+};
+
 &pm6125_gpios {
 	vol_up_n: vol-up-n-state {
 		pins = "gpio5";
@@ -89,6 +106,10 @@ &pon_resin {
 	status = "okay";
 };
 
+&qupv3_id_0 {
+	status = "okay";
+};
+
 &rpm_requests {
 	regulators-0 {
 		compatible = "qcom,rpm-pm6125-regulators";

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED Dang Huynh
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

The Fxtec Pro1X touchscreen uses Goodix GT9286 chip.

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 49 +++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 47e446249af6..813cd22907c8 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -63,6 +63,20 @@ key-volume-up {
 			wakeup-source;
 		};
 	};
+
+	ts_vdd_supply: ts-vdd-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "ts_vdd_supply";
+		gpio = <&pca9534 3 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	ts_vddio_supply: ts-vddio-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "ts_vddio_supply";
+		gpio = <&pca9534 2 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };
 
 &dispcc {
@@ -87,6 +101,27 @@ pca9534: gpio@21 {
 	};
 };
 
+&i2c2 {
+	status = "okay";
+	/* Clock frequency was not specified downstream, let's park it to 100 KHz */
+	clock-frequency = <100000>;
+
+	touchscreen@14 {
+		compatible = "goodix,gt9286";
+		reg = <0x14>;
+
+		interrupts-extended = <&tlmm 80 IRQ_TYPE_LEVEL_LOW>;
+
+		irq-gpios = <&tlmm 80 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&tlmm 71 GPIO_ACTIVE_HIGH>;
+		AVDD28-supply = <&ts_vdd_supply>;
+		VDDIO-supply = <&ts_vddio_supply>;
+
+		pinctrl-0 = <&ts_int_n>, <&ts_rst_n>;
+		pinctrl-names = "default";
+	};
+};
+
 &pm6125_gpios {
 	vol_up_n: vol-up-n-state {
 		pins = "gpio5";
@@ -257,6 +292,20 @@ key_camera_n: key-camera-n-state {
 		bias-pull-up;
 	};
 
+	ts_rst_n: ts-rst-n-state {
+		pins = "gpio71";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-pull-up;
+	};
+
+	ts_int_n: ts-int-n-state {
+		pins = "gpio80";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-pull-up;
+	};
+
 	hall_sensor_n: hall-sensor-n-state {
 		pins = "gpio96";
 		function = "gpio";

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (2 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot Dang Huynh
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

The Pro1X has a caps lock LED on the keyboard.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 813cd22907c8..b45ae3402741 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -8,6 +8,7 @@
 #include "sm6115.dtsi"
 #include "pm6125.dtsi"
 #include <dt-bindings/arm/qcom,ids.h>
+#include <dt-bindings/leds/common.h>
 
 / {
 	model = "F(x)tec Pro1X (QX1050)";
@@ -64,6 +65,19 @@ key-volume-up {
 		};
 	};
 
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		capslock-led {
+			label = "green:capslock";
+			function = LED_FUNCTION_CAPSLOCK;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&pca9534 1 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "kbd-capslock";
+			default-state = "off";
+		};
+	};
+
 	ts_vdd_supply: ts-vdd-supply {
 		compatible = "regulator-fixed";
 		regulator-name = "ts_vdd_supply";

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (3 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU Dang Huynh
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

Fxtec Pro1X has two card slots and allow either 2xSIM cards or
1xSIM, 1xSD Card configuration.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 32 +++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index b45ae3402741..67946d099976 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -191,6 +191,7 @@ pm6125_l4a: l4 {
 		pm6125_l5a: l5 {
 			regulator-min-microvolt = <1648000>;
 			regulator-max-microvolt = <3056000>;
+			regulator-allow-set-load;
 		};
 
 		pm6125_l6a: l6 {
@@ -292,6 +293,37 @@ pm6125_l24a: l24 {
 	};
 };
 
+&sdc2_state_off {
+	cd-pins {
+		pins = "gpio88";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+};
+
+&sdc2_state_on {
+	cd-pins {
+		pins = "gpio88";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+};
+
+&sdhc_2 {
+	pinctrl-0 = <&sdc2_state_on>;
+	pinctrl-1 = <&sdc2_state_off>;
+	pinctrl-names = "default", "sleep";
+
+	cd-gpios = <&tlmm 88 GPIO_ACTIVE_LOW>;
+
+	vmmc-supply = <&pm6125_l22a>;
+	vqmmc-supply = <&pm6125_l5a>;
+
+	status = "okay";
+};
+
 &sleep_clk {
 	clock-frequency = <32764>;
 };

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (4 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS Dang Huynh
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 84 +++++++++++++++++++++++--
 1 file changed, 80 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 67946d099976..0301f04041e7 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -33,6 +33,26 @@ framebuffer0: framebuffer@5c000000 {
 		};
 	};
 
+	disp_elvdd_supply: disp-elvdd-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "disp_elvdd_supply";
+	};
+
+	disp_elvss_supply: disp-elvss-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "disp_elvss_supply";
+	};
+
+	disp_vcc_supply: disp-vcc-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "disp_vcc_supply";
+	};
+
+	disp_vci_supply: disp-vci-supply {
+		compatible = "regulator-fixed";
+		regulator-name = "disp_vci_supply";
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 
@@ -93,13 +113,16 @@ ts_vddio_supply: ts-vddio-supply {
 	};
 };
 
-&dispcc {
-	/* HACK: disable until a panel driver is ready to retain simplefb */
-	status = "disabled";
+&gpi_dma0 {
+	status = "okay";
 };
 
-&gpi_dma0 {
+&gpu {
 	status = "okay";
+
+	zap-shader {
+		firmware-name = "qcom/sm6115/Fxtec/QX1050/a610_zap.mbn";
+	};
 };
 
 &i2c1 {
@@ -136,6 +159,46 @@ touchscreen@14 {
 	};
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	vdda-supply = <&pm6125_l18a>;
+	status = "okay";
+
+	panel: panel@0 {
+		compatible = "boe,bf060y8m-aj0";
+		reg = <0>;
+
+		reset-gpios = <&tlmm 82 GPIO_ACTIVE_LOW>;
+
+		elvdd-supply = <&disp_elvdd_supply>;
+		elvss-supply = <&disp_elvss_supply>;
+		vcc-supply = <&disp_vcc_supply>;
+		vci-supply = <&disp_vci_supply>;
+		vddio-supply = <&pm6125_l9a>;
+
+		pinctrl-0 = <&mdss_dsi_n &panel_en_n>;
+		pinctrl-names = "default";
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_out {
+	data-lanes = <0 1 2 3>;
+	remote-endpoint = <&panel_in>;
+};
+
+&mdss_dsi0_phy {
+	status = "okay";
+};
+
 &pm6125_gpios {
 	vol_up_n: vol-up-n-state {
 		pins = "gpio5";
@@ -338,6 +401,12 @@ key_camera_n: key-camera-n-state {
 		bias-pull-up;
 	};
 
+	panel_en_n: panel-en-n-state {
+		pins = "gpio65";
+		function = "gpio";
+		bias-disable;
+	};
+
 	ts_rst_n: ts-rst-n-state {
 		pins = "gpio71";
 		function = "gpio";
@@ -352,6 +421,13 @@ ts_int_n: ts-int-n-state {
 		bias-pull-up;
 	};
 
+	mdss_dsi_n: mdss-dsi-n-state {
+		pins = "gpio82";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+	};
+
 	hall_sensor_n: hall-sensor-n-state {
 		pins = "gpio96";
 		function = "gpio";

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (5 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property Dang Huynh
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

The F(x)tec Pro1X supports USB 3.0 through it's USB-C port.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 0301f04041e7..d28b870320c9 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -457,7 +457,6 @@ &usb {
 
 &usb_dwc3 {
 	/delete-property/ usb-role-switch;
-	maximum-speed = "high-speed";
 	dr_mode = "peripheral";
 };
 
@@ -468,6 +467,12 @@ &usb_hsphy {
 	status = "okay";
 };
 
+&usb_qmpphy {
+	vdda-phy-supply = <&pm6125_l4a>;
+	vdda-pll-supply = <&pm6125_l12a>;
+	status = "okay";
+};
+
 &xo_board {
 	clock-frequency = <19200000>;
 };

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (6 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED Dang Huynh
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

The USB-C port is used for powering external devices and transfer
data from/to them.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 51 +++++++++++++++++++++++--
 1 file changed, 48 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index d28b870320c9..be77a8318800 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -7,8 +7,10 @@
 
 #include "sm6115.dtsi"
 #include "pm6125.dtsi"
+#include "pmi632.dtsi"
 #include <dt-bindings/arm/qcom,ids.h>
 #include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
 
 / {
 	model = "F(x)tec Pro1X (QX1050)";
@@ -209,6 +211,46 @@ vol_up_n: vol-up-n-state {
 	};
 };
 
+&pmi632_typec {
+	status = "okay";
+
+	connector {
+		compatible = "usb-c-connector";
+
+		power-role = "dual";
+		data-role = "dual";
+		self-powered;
+
+		typec-power-opmode = "default";
+		pd-disable;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				pmi632_hs_in: endpoint {
+					remote-endpoint = <&usb_dwc3_hs>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				pmi632_ss_in: endpoint {
+					remote-endpoint = <&usb_qmpphy_out>;
+				};
+			};
+		};
+	};
+};
+
+&pmi632_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <1000000>;
+	status = "okay";
+};
+
 &pon_pwrkey {
 	status = "okay";
 };
@@ -455,9 +497,8 @@ &usb {
 	status = "okay";
 };
 
-&usb_dwc3 {
-	/delete-property/ usb-role-switch;
-	dr_mode = "peripheral";
+&usb_dwc3_hs {
+	remote-endpoint = <&pmi632_hs_in>;
 };
 
 &usb_hsphy {
@@ -473,6 +514,10 @@ &usb_qmpphy {
 	status = "okay";
 };
 
+&usb_qmpphy_out {
+	remote-endpoint = <&pmi632_ss_in>;
+};
+
 &xo_board {
 	clock-frequency = <19200000>;
 };

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (7 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs Dang Huynh
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

This device has an RGB LED. It is used for notifications.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 27 +++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index be77a8318800..34834a3929b1 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -211,6 +211,33 @@ vol_up_n: vol-up-n-state {
 	};
 };
 
+&pmi632_lpg {
+	status = "okay";
+
+	multi-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &pmi632_typec {
 	status = "okay";
 

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (8 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-07-31  6:18 ` [PATCH v3 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN Dang Huynh
  2024-08-01  3:19 ` [PATCH v3 00/11] F(x)tec Pro1X feature expansion Bjorn Andersson
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

Enable [A,C]DSP and MPSS remote processor on this device.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 34834a3929b1..d3782b2a7831 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -291,6 +291,21 @@ &qupv3_id_0 {
 	status = "okay";
 };
 
+&remoteproc_adsp {
+	firmware-name = "qcom/sm6115/Fxtec/QX1050/adsp.mbn";
+	status = "okay";
+};
+
+&remoteproc_cdsp {
+	firmware-name = "qcom/sm6115/Fxtec/QX1050/cdsp.mbn";
+	status = "okay";
+};
+
+&remoteproc_mpss {
+	firmware-name = "qcom/sm6115/Fxtec/QX1050/modem.mbn";
+	status = "okay";
+};
+
 &rpm_requests {
 	regulators-0 {
 		compatible = "qcom,rpm-pm6125-regulators";

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v3 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (9 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs Dang Huynh
@ 2024-07-31  6:18 ` Dang Huynh
  2024-08-01  3:19 ` [PATCH v3 00/11] F(x)tec Pro1X feature expansion Bjorn Andersson
  11 siblings, 0 replies; 14+ messages in thread
From: Dang Huynh @ 2024-07-31  6:18 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel, Dang Huynh

Enable onboard Wi-Fi on the F(x)tec Pro1X.

For reference, HW/SW identifies as:
qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x40670000
qmi fw_version 0x324103d6 fw_build_timestamp 2021-12-02 08:20
fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.2.4-00982-QCAHLSWMTPLZ-1

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index d3782b2a7831..b419cd32215f 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -560,6 +560,17 @@ &usb_qmpphy_out {
 	remote-endpoint = <&pmi632_ss_in>;
 };
 
+&wifi {
+	vdd-0.8-cx-mx-supply = <&pm6125_l8a>;
+	vdd-1.8-xo-supply = <&pm6125_l16a>;
+	vdd-1.3-rfa-supply = <&pm6125_l17a>;
+	vdd-3.3-ch0-supply = <&pm6125_l23a>;
+
+	qcom,ath10k-calibration-variant = "Fxtec_QX1050";
+
+	status = "okay";
+};
+
 &xo_board {
 	clock-frequency = <19200000>;
 };

-- 
2.46.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander
  2024-07-31  6:18 ` [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander Dang Huynh
@ 2024-07-31 11:05   ` Caleb Connolly
  0 siblings, 0 replies; 14+ messages in thread
From: Caleb Connolly @ 2024-07-31 11:05 UTC (permalink / raw)
  To: Dang Huynh, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel



On 31/07/2024 08:18, Dang Huynh wrote:
> F(x)tec Pro1X comes with PCA9534 IO Expander, it is used for enabling
> touch screen VDD/VDDIO and keyboard's caps lock LED.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
>   arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> index 70f479a63f2e..47e446249af6 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> @@ -70,6 +70,23 @@ &dispcc {
>   	status = "disabled";
>   };
>   
> +&gpi_dma0 {
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	status = "okay";
> +	/* Clock frequency was not specified downstream, let's park it to 100 KHz */

This is the default, so you can drop this comment.

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> +	clock-frequency = <100000>;
> +
> +	pca9534: gpio@21 {
> +		compatible = "nxp,pca9534";
> +		reg = <0x21>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};
> +
>   &pm6125_gpios {
>   	vol_up_n: vol-up-n-state {
>   		pins = "gpio5";
> @@ -89,6 +106,10 @@ &pon_resin {
>   	status = "okay";
>   };
>   
> +&qupv3_id_0 {
> +	status = "okay";
> +};
> +
>   &rpm_requests {
>   	regulators-0 {
>   		compatible = "qcom,rpm-pm6125-regulators";
> 

-- 
// Caleb (they/them)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3 00/11] F(x)tec Pro1X feature expansion
  2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
                   ` (10 preceding siblings ...)
  2024-07-31  6:18 ` [PATCH v3 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN Dang Huynh
@ 2024-08-01  3:19 ` Bjorn Andersson
  11 siblings, 0 replies; 14+ messages in thread
From: Bjorn Andersson @ 2024-08-01  3:19 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
	Dang Huynh
  Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
	linux-kernel


On Wed, 31 Jul 2024 13:18:41 +0700, Dang Huynh wrote:
> This patch series expand F(x)tec Pro1X (QX1050) device tree to support
> various components of the device.
> 
> Most notably:
> + SD Card slot
> + Touchscreen
> + MDSS, DRM display panel
> + WLAN (ATH10K)
> + Hall sensor and camera button
> 
> [...]

Applied, thanks!

[01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button
        commit: ff5affd17bde4ea78d153122a601d69b3f302326
[02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander
        commit: 4686161eb87168ec746eb54d7b84c5d022073a33
[03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen
        commit: e46b455e67f836361a94512ca187442a8b699f25
[04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED
        commit: 17c98581155e88d3f118cd879ba263e952b83946
[05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot
        commit: 95b19afd734d0a278088456b052a2fb94c4ade55
[06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU
        commit: 8b9f76a6f8fbc81fdc44b5c4b134d20095c38a6a
[07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS
        commit: e0674d85c80456782fdc44c36c4884fa64bb3a58
[08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property
        commit: 79f8d127c46a1311de49db7c175fee84ce827d3a
[09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED
        commit: b5c63330a7ef026c21da5eed4669a790b22ea642
[10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs
        commit: e055924159df6ec2ffa0f221aa84c49429cfe6db
[11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN
        commit: 84c1711f27509a6a5841b13ac08fc58b1d091ae8

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-08-01  3:19 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31  6:18 [PATCH v3 00/11] F(x)tec Pro1X feature expansion Dang Huynh
2024-07-31  6:18 ` [PATCH v3 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button Dang Huynh
2024-07-31  6:18 ` [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander Dang Huynh
2024-07-31 11:05   ` Caleb Connolly
2024-07-31  6:18 ` [PATCH v3 03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen Dang Huynh
2024-07-31  6:18 ` [PATCH v3 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED Dang Huynh
2024-07-31  6:18 ` [PATCH v3 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot Dang Huynh
2024-07-31  6:18 ` [PATCH v3 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU Dang Huynh
2024-07-31  6:18 ` [PATCH v3 07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS Dang Huynh
2024-07-31  6:18 ` [PATCH v3 08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property Dang Huynh
2024-07-31  6:18 ` [PATCH v3 09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED Dang Huynh
2024-07-31  6:18 ` [PATCH v3 10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs Dang Huynh
2024-07-31  6:18 ` [PATCH v3 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN Dang Huynh
2024-08-01  3:19 ` [PATCH v3 00/11] F(x)tec Pro1X feature expansion Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).