From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohan Kumar D <mkumard@nvidia.com>,
robh+dt@kernel.org, krzk+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com
Subject: Re: [PATCH] arm64: tegra: Enable hda node for P3737 + P3701
Date: Fri, 25 Mar 2022 10:42:17 +0100 [thread overview]
Message-ID: <ca18fa50-f63b-8131-07a2-8c44daed9f26@kernel.org> (raw)
In-Reply-To: <32e425be-5d78-e1e0-6ec4-70ea21895e15@nvidia.com>
On 25/03/2022 10:31, Mohan Kumar D wrote:
>
> On 3/25/2022 12:56 PM, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 25/03/2022 08:21, Mohan Kumar wrote:
>>> Add iommus property for hda and enable the node for P3737 + P3701
>>> platform.
>>>
>>> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
>>> ---
>>> arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 1 +
>>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 1 +
>>> 2 files changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> index 34d6a01ee1c6..156d5d95fde7 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> @@ -1751,6 +1751,7 @@
>>>
>>> hda@3510000 {
>>> nvidia,model = "NVIDIA Jetson AGX Orin HDA";
>>> + status = "okay";
>> Nodes are enabled by default. Why do you need this?
> hda node status is set to "disabled" by default in soc dts file
> tegra234.dtsi. The enable is controlled by platform specific dts files.
Oh, surprise... why do you override nodes with full path? This is
error-prone and makes any changes (like node name fixing) difficult.
This should be overridden by label.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-25 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 7:21 [PATCH] arm64: tegra: Enable hda node for P3737 + P3701 Mohan Kumar
2022-03-25 7:26 ` Krzysztof Kozlowski
2022-03-25 9:31 ` Mohan Kumar D
2022-03-25 9:42 ` Krzysztof Kozlowski [this message]
2022-03-28 6:20 ` Mohan Kumar D
2022-03-30 10:48 ` Thierry Reding
2022-04-11 9:56 ` Mohan Kumar D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca18fa50-f63b-8131-07a2-8c44daed9f26@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).