From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC902C77B73 for ; Mon, 8 May 2023 10:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234776AbjEHKel (ORCPT ); Mon, 8 May 2023 06:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234694AbjEHKeK (ORCPT ); Mon, 8 May 2023 06:34:10 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C332D2645F for ; Mon, 8 May 2023 03:33:19 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f1fe1208a4so1966451e87.2 for ; Mon, 08 May 2023 03:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683541992; x=1686133992; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ouHo7zR5/nEeID59MhsBNJUWJPBlxiSaILyid7Xi4po=; b=IrBMZQZQsf6YLTPsDLSPu6hI8VzWC0QkePEAUIIUI3vxrblNKGa+eewh7BPkynhhiD mlBFubuQqhOC9sWaJJFDBXxzV9dr6IfTLfufPm1f150hLrroXgJmn3VDC4Gm9uXq8Vp0 hdALtoG5lbrNoQQ2JjvbjFNc6Fm3DIkPN7560jg+Iyt2EtAA+pcpBYEGLR8d5Cu/ef+d L+AWQb1MHdl6Xe/c9tMvp220ySbm1cK/owaGE4Ss5ntCVZmbmph2h9lkynXMyPN+Ka3M fQ0Alea88Jt72lwRNJoTPZXzSigCfQGFMZVK4gIKO0Jaa/RcVuCl+bXG+t11/mhZVuTr syUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541992; x=1686133992; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ouHo7zR5/nEeID59MhsBNJUWJPBlxiSaILyid7Xi4po=; b=cabHi8ZNSNy37FVqPU8TInS+y2TV+TC4m/M4sbpCxGvOAPYli8gpN5VvR72+ToYbSl x73AsM5fyUKiM9PEGxHSFQEHX5DIQe/c3yQlG6ONXHOmB0eqglheprezv+ebixqGUoS3 4T4ZP+0lOtDZ7trnmVDiPD17bKtv8EB2WNLB5dwKM3TTC+YOU7FOdhUJPsR5+Tstob0v xISj/KLl1Tc0krnXlwF80XFWGDA5STHnjhIBXyWc5jhaMryUZGJaZYUe1JsOgAMi78r4 oufh8s5Stje2XkLHD5e3kOpt9IE99wLxtCBnA8AcA7G5nTI19rLNYw90ioKtaf+FucKM p/TA== X-Gm-Message-State: AC+VfDxIcLtxVo634pPH5SbAZVJUod6sFGOiw+IxBxCtSz9VE3uJw3aL vm3yeNqBCPGKXFLR3NXMpy4OoQ== X-Google-Smtp-Source: ACHHUZ4brFre2/8Y6K2a+AaHZm9B3InvOm7DPzyVMAY0+cNjjeeh6Ymi01ItA9JNbfwZCSNwGHW6OQ== X-Received: by 2002:a19:ad45:0:b0:4f1:4300:80e2 with SMTP id s5-20020a19ad45000000b004f1430080e2mr2493651lfd.32.1683541992278; Mon, 08 May 2023 03:33:12 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id e24-20020ac25478000000b004f1482d9db6sm1247211lfn.155.2023.05.08.03.33.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:33:11 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 13:33:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS Content-Language: en-GB To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230507190735.2333145-1-dmitry.baryshkov@linaro.org> <20230507190735.2333145-4-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 11:33, Konrad Dybcio wrote: > > > On 7.05.2023 21:07, Dmitry Baryshkov wrote: >> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region >> differs from the one defined in the msm8974, so it overriden locally. >> >> The modem is specified use mba.mbn instead of mbn.b00 (for the sake of >> similarity with other platforms). This requires a patch for remoteproc >> to be applied [1]. >> >> [1] https://lore.kernel.org/all/20230507172041.2320279-1-dmitry.baryshkov@linaro.org/ >> >> Signed-off-by: Dmitry Baryshkov >> --- >> .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 28 +++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> index 6b047c679370..c893afc00eb4 100644 >> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> @@ -4,6 +4,8 @@ >> #include "qcom-pm8841.dtsi" >> #include "qcom-pm8941.dtsi" >> >> +/delete-node/ &mpss_region; >> + >> / { >> model = "Qualcomm APQ8074 Dragonboard"; >> compatible = "qcom,apq8074-dragonboard", "qcom,apq8074"; >> @@ -17,6 +19,13 @@ aliases { >> chosen { >> stdout-path = "serial0:115200n8"; >> }; >> + >> + reserved-memory { >> + mpss_region: mpss@ac00000 { >> + reg = <0x0ac00000 0x2500000>; >> + no-map; >> + }; >> + }; >> }; >> >> &blsp1_uart2 { >> @@ -39,6 +48,25 @@ eeprom: eeprom@52 { >> }; >> }; >> >> +&remoteproc_adsp { >> + cx-supply = <&pm8841_s2>; >> + >> + firmware-name = "qcom/apq8074/adsp.mbn"; >> + >> + status = "okay"; >> +}; >> + >> +&remoteproc_mss { >> + cx-supply = <&pm8841_s2>; >> + mss-supply = <&pm8841_s3>; >> + mx-supply = <&pm8841_s1>; >> + pll-supply = <&pm8941_l12>; > High time to move this to rpmpd! > I won't object to adding this though, as it obviously works > and is already used on other boards.. I think the problem is that they are not level-voted on this platform, so they are regulators, not PDs. > >> + >> + firmware-name = "qcom/apq8074/mba.mbn", "qcom/apq8074/modem.mbn"; > Could you please keep it one entry per line? Sure. > > Otherwise, > > Reviewed-by: Konrad Dybcio > > Konrad >> + >> + status = "okay"; >> +}; >> + >> &rpm_requests { >> regulators-0 { >> compatible = "qcom,rpm-pm8841-regulators"; -- With best wishes Dmitry