devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Shenghao Ding <13916275206@139.com>,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
	shenghao-ding@ti.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com,
	navada@ti.com, gentuser@gmail.com, Ryan_Chu@wistron.com,
	Sam_Wu@wistron.com
Subject: Re: [PATCH v2 2/5] ASoC: dt-bindings: Add tas2781 amplifier
Date: Thu, 11 May 2023 11:37:12 +0200	[thread overview]
Message-ID: <ca2ed8e9-850a-56c5-e395-72e5861b9c71@linaro.org> (raw)
In-Reply-To: <ZFyBzHWo3ORKAskX@finisterre.sirena.org.uk>

On 11/05/2023 07:49, Mark Brown wrote:
>> Missing minItems, but...
> 
>>> +    items:
>>> +      minimum: 0x38
>>> +      maximum: 0x3f
> 
>> ... So these are fixed? No need to encode them in such case...
> 
> I'm not sure I understand your concern here, there's up to 4 possible
> values from 0x38-0x3f which has more than 4 possible values.

Aren't the addresses going to be incremented by one (up to 8 of devices
in total)?


Best regards,
Krzysztof


  reply	other threads:[~2023-05-11  9:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  5:45 [PATCH v2 2/5] ASoC: dt-bindings: Add tas2781 amplifier Shenghao Ding
2023-05-08  6:26 ` Rob Herring
2023-05-08  9:32   ` Krzysztof Kozlowski
2023-05-10  7:04 ` Krzysztof Kozlowski
2023-05-10 14:03   ` [EXTERNAL] " Ding, Shenghao
2023-05-11  9:01     ` Krzysztof Kozlowski
2023-05-11  5:49   ` Mark Brown
2023-05-11  9:37     ` Krzysztof Kozlowski [this message]
2023-05-11 13:19       ` [EXTERNAL] " Ding, Shenghao
2023-05-11 14:48         ` Krzysztof Kozlowski
2023-05-17 12:24           ` Ding, Shenghao
2023-05-17 15:05             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca2ed8e9-850a-56c5-e395-72e5861b9c71@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=13916275206@139.com \
    --cc=Ryan_Chu@wistron.com \
    --cc=Sam_Wu@wistron.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gentuser@gmail.com \
    --cc=kevin-lu@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navada@ti.com \
    --cc=peeyush@ti.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=shenghao-ding@ti.com \
    --cc=x1077012@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).