From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sergei Antonov" <saproj@gmail.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
"Jonas Jensen" <jonas.jensen@gmail.com>
Subject: Re: [PATCH] ARM: dts: sync Moxa SDIO 'compatible' name with moxart-mmc.c
Date: Mon, 05 Sep 2022 14:13:04 +0200 [thread overview]
Message-ID: <ca470feb-8030-400f-8201-e3d17dbd52ac@www.fastmail.com> (raw)
In-Reply-To: <CABikg9w9k0UUtEBbO=QB4_YVT7BFtzs0id6-g+Xo3HGv8qTvrQ@mail.gmail.com>
On Mon, Sep 5, 2022, at 1:24 PM, Sergei Antonov wrote:
> On Mon, 5 Sept 2022 at 14:13, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Mon, Sep 5, 2022, at 12:43 PM, Sergei Antonov wrote:
> I am sure. Witnessing right now that it works with SDHC cards with
> capacity 16 GB and 8 GB.
> Datasheet quote:
> "supports both MMC and SD interface protocol."
> See
> https://bitbucket.org/Kasreyn/mkrom-uc7112lx/src/master/documents/FIC8120_DS_v1.2.pdf
> , page 367.
Ok, that does make it pretty clear that there is only one
controller.
>> > diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi
>> > index f5f070a87482..d69d73930ebe 100644
>> > --- a/arch/arm/boot/dts/moxart.dtsi
>> > +++ b/arch/arm/boot/dts/moxart.dtsi
>> > @@ -94,7 +94,7 @@ watchdog: watchdog@98500000 {
>> > };
>> >
>> > sdhci: sdhci@98e00000 {
>> > - compatible = "moxa,moxart-sdhci";
>> > + compatible = "moxa,moxart-mmc";
>> > reg = <0x98e00000 0x5C>;
>> > interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
>> > clocks = <&clk_apb>;
>>
>> Both the label and the device name still point to "sdhci",
>> so it would be possible that the SoC actually has both
>> an SDHCI compatible device and ftsdc010. In this case the
>> correct fix would be to add a second node for the
>> moxa,moxart-mmc with the correct reg and interrupts
>> properties but to leave this one alone.
>
> SoC contains ftsdc010 which supports SDHC cards. Should be compatible
> with MMC cards too. I will test it to be sure.
Don't worry about MMC cards, that is not the point. Both sdhci
and ftsdc010 can support SD, SDHC, MMC and eMMC devices, probably
other related standards as well.
The only question was whether the ftsdc010 was incorrectly labeled
as an sdhci type controller rather than ftsdc010, or whether the
chip has both sdhci and ftsdc010 controllers that can be used
simultaneously as is common on some other chips.
Please respin the patch though and change the node name to mmc@,
and the change the label to something other than sdhci (e.g.
"mmc", or "ftsdc010", doesn't matter) to make this less
confusing.
Arnd
prev parent reply other threads:[~2022-09-05 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:43 [PATCH] ARM: dts: sync Moxa SDIO 'compatible' name with moxart-mmc.c Sergei Antonov
2022-09-05 11:12 ` Arnd Bergmann
2022-09-05 11:24 ` Sergei Antonov
2022-09-05 12:13 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca470feb-8030-400f-8201-e3d17dbd52ac@www.fastmail.com \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jonas.jensen@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=saproj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox