From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver Date: Wed, 18 Oct 2017 00:26:45 +0300 Message-ID: References: <3d432aa2617977a2b0a8621a1fc2f36f751133e1.1507752381.git.digetx@gmail.com> <20171017201354.efgjrwvakkseyvr7@rob-hp-laptop> <20171017202407.GA10482@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Thierry Reding Cc: Jonathan Hunter , Greg Kroah-Hartman , Mauro Carvalho Chehab , Stephen Warren , Dan Carpenter , "linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 18.10.2017 00:13, Rob Herring wrote: > On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding > wrote: >> On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: >> [...] >>>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt >> [...] >>>> +- resets : Must contain an entry for each entry in reset-names. >>>> + See ../reset/reset.txt for details. >>>> +- reset-names : Must include the following entries: >>>> + - vde >>> >>> -names is pointless when there is only one. >> >> I'd prefer to keep it. In the past we occasionally had to add clocks or >> resets to a device tree node where only one had been present (and hence >> no -names property) and that caused some awkwardness because verbiage >> had to be added to the bindings that clarified that one particular entry >> (the original one) always had to come first. > > The order should be specified regardless of -names and the original > one has to come first if you add any. That's not awkwardness, but how > bindings work. Probably it would be okay to remove '-names' from the binding doc, but keep them in the actual DT, wouldn't it? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html