From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alireza Sanaee <alireza.sanaee@huawei.com>,
mark.rutland@arm.com, robh@kernel.org
Cc: coresight@lists.linaro.org, devicetree@vger.kernel.org,
dianders@chromium.org, james.clark@linaro.org,
jonathan.cameron@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linuxarm@huawei.com, mike.leach@linaro.org,
ruanjinjie@huawei.com, saravanak@google.com,
shameerali.kolothum.thodi@huawei.com, suzuki.poulose@arm.com
Subject: Re: [PATCH 2/5] arch_topology: update CPU map to use the new API
Date: Tue, 8 Jul 2025 08:29:43 +0200 [thread overview]
Message-ID: <ca58608c-c147-45a7-910f-41a7c312fd5a@kernel.org> (raw)
In-Reply-To: <20250707150414.620-3-alireza.sanaee@huawei.com>
On 07/07/2025 17:04, Alireza Sanaee wrote:
> Cleans up the cpu-map generation using the created API.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> drivers/base/arch_topology.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 3ebe77566788..88970f13f684 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -518,23 +518,23 @@ core_initcall(free_raw_capacity);
> */
> static int __init get_cpu_for_node(struct device_node *node)
> {
> + struct device_node *cpu_node __free(device_node) = NULL;
That's not a correct style anymore. What's more it is not really
explained anywhere. Follow standard cleanup.h rules (constructor).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-08 6:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 15:04 [PATCH 0/5] Refactoring finding CPU phandles in DT Alireza Sanaee
2025-07-07 15:04 ` [PATCH 1/5] of: add infra for finding CPU id from phandle Alireza Sanaee
2025-07-08 8:26 ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 2/5] arch_topology: update CPU map to use the new API Alireza Sanaee
2025-07-08 6:29 ` Krzysztof Kozlowski [this message]
2025-07-08 8:22 ` Jonathan Cameron
2025-07-08 8:26 ` Krzysztof Kozlowski
2025-07-08 8:31 ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 3/5] coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id Alireza Sanaee
2025-07-08 8:36 ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 4/5] coresight: " Alireza Sanaee
2025-07-08 8:37 ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 5/5] perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to_id Alireza Sanaee
2025-07-08 8:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca58608c-c147-45a7-910f-41a7c312fd5a@kernel.org \
--to=krzk@kernel.org \
--cc=alireza.sanaee@huawei.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=james.clark@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saravanak@google.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).