From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D8EC43217 for ; Tue, 15 Nov 2022 12:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbiKOMMv (ORCPT ); Tue, 15 Nov 2022 07:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbiKOMMu (ORCPT ); Tue, 15 Nov 2022 07:12:50 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD60E13CEE for ; Tue, 15 Nov 2022 04:12:47 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id k19so17255991lji.2 for ; Tue, 15 Nov 2022 04:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oMav8xKNkyJd8dYTuDrxcWCyxQ9njFDC0AA3Jeepq2U=; b=gDzxzSC6yVNoqY1zCu3xhGRLsbd8bfIpOQs4V6/Wn3OhFeIlkL5K+DR+1RyGwvvLvO ouUjHZpieshOzEo92gPkMWkMdhrktS3Hcc7Q7xDuQ0n/XXN5VAvpwSDQ9Z7bjiSNottj Wmd/SkewWKJrjwJdeg6/AvovqKFeF1S1VQaqYwFhmJRiRAmmXusj4+PdVn86gSabWIIX BqIOqVwrlYpIYAsimUifLhthNh0D0KxOTPS2qP9IUL36tlHbkc0/LV0ROO4jEn/Mptty IpvRAXca3xUV+LLaVMPI1OvZIjxgTO6SbRwLoS67m+o6Z0n3kzfGqO+Z7OZwxa2J7cAT XHTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oMav8xKNkyJd8dYTuDrxcWCyxQ9njFDC0AA3Jeepq2U=; b=AsJn3kxvwEhXlO8U1XZP7mb7uDRALgXe3x+7xfQ52Wr2t/EtMQu0tX1eKxlBze35ni zOVoZLMDxhQW/iYAM5onMSypryDmvaKisrVDjK2mtc0o2ph3gkRNU7eKOnS0YnhDLE5+ 3J2dIe8V8KAgvOPYIzu/AX1qOtSOcg/TDLBQ1vFkBMhFh8EzU0m3S2S2/plZMw4B1MI2 yob3FzGfQopY9Kntq7+ZOAH9oNdayvP7qZU//R8X24VdMM0vee5gcJOh8keOgfCX78qO xBbD5CopHzGKnM8TNsKUfeSP4692kd8guvCf9pac50Gfs022yqMOL4f89gBwtU0HM78j PF2A== X-Gm-Message-State: ANoB5plQ9/YAHOgB6/r/WEha9AH8WInPyvvN4ktvZoxRW50EeRC5IoKO wBXY0A2w8Q2+hMrwHCETxEKl5w== X-Google-Smtp-Source: AA0mqf7sx3nXu5rTD5mQ5GRhhLsHR9sDtPFQcjrqxTGQIL4llNiJnNagH/dDXzwbxLekddyKweds/A== X-Received: by 2002:a2e:b621:0:b0:276:762b:3499 with SMTP id s1-20020a2eb621000000b00276762b3499mr5525270ljn.444.1668514366200; Tue, 15 Nov 2022 04:12:46 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id g27-20020a2ea4bb000000b002771888fda1sm2473767ljm.84.2022.11.15.04.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 04:12:45 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 13:12:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 01/23] dt-bindings: display: tegra: add bindings for Tegra20 VIP Content-Language: en-US To: luca.ceresoli@bootlin.com, David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Dmitry Osipenko Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Thomas Petazzoni , Richard Leitner References: <20221109141852.729246-1-luca.ceresoli@bootlin.com> <20221109141852.729246-2-luca.ceresoli@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20221109141852.729246-2-luca.ceresoli@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2022 15:18, luca.ceresoli@bootlin.com wrote: > From: Luca Ceresoli > > VIP is the parallel video capture component within the video input > subsystem of Tegra20 (and other Tegra chips, apparently). Subject: drop second, redundant "bindings". > > Signed-off-by: Luca Ceresoli > --- > .../display/tegra/nvidia,tegra20-vip.yaml | 64 +++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml > new file mode 100644 > index 000000000000..934dabfd2307 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/tegra/nvidia,tegra20-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra VIP (parallel video capture) controller > + > +maintainers: > + - Luca Ceresoli > + > +properties: > + $nodename: > + const: vip No need to enforce names in device schemas, especially that this does not look like a generic name. > + > + compatible: > + enum: > + - nvidia,tegra20-vip > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + channel@0: Missing description. > + type: object Do you expect it to grow to more channels? > + > + properties: > + reg: true const: 0 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port receiving the video stream from the sensor > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Port sending the video stream to the VI > + > + required: > + - port@0 > + - port@1 > + > + additionalProperties: false > + > + required: > + - reg > + - ports > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - channel@0 > + > +# see nvidia,tegra20-vi.yaml for an example That file does not have this compatible. At least not on next-20221109. Best regards, Krzysztof