From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C9AC4332F for ; Fri, 11 Nov 2022 07:58:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231625AbiKKH6x (ORCPT ); Fri, 11 Nov 2022 02:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbiKKH6w (ORCPT ); Fri, 11 Nov 2022 02:58:52 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC6E47301 for ; Thu, 10 Nov 2022 23:58:51 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id be13so7228150lfb.4 for ; Thu, 10 Nov 2022 23:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KwU5CkjoRIEtbAhM41+6jkxe2GJWOzFr6ZG3QP2ECFg=; b=ZaSv/KRfXBtxkGUSgji6I7GnV9tr2AB9YForlVDX5XFX6IR3erR2a1qmlIrpvxkUYj i3hyWfIpzIWcI+Kq3vmbpOTVnsxd+HJLwV8+NALZ0Lxz9b9hGPZ9Gp++JIr+YOgt5VL1 raGG3kk0h2+gCCfZD7YOrHpjkw6SF0I8Ya2k3q0dSyXiHlIfUxbg2WmCbUpTwH67JFo7 pTBjIYjYffG0o2U+5Pkkf7pLKPRicVhZnL49LIfTlet+92BuI8MvbYaEk8L2wMN573O1 eM2YItr/iN5Gpd38qPIlTs2i59ZVUMNFqlEM+QMpcTcKplFbHiLss68f/a2jd2Hrw93c 513A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KwU5CkjoRIEtbAhM41+6jkxe2GJWOzFr6ZG3QP2ECFg=; b=xA/rB4nNF3h5Nn3j6LnvbIywih7vkk+ZPdo2WMVXFd/cvUyhzO5/67NfTO6EVGpg5G gA90vjVEHIcXCxKJIgmYYXQ5j7tqe30TRDelmgT2w4mljZ//wLz0rsm8JKTruWDLTbxe Z54rVpE2V1X8qFR7UzAoLZydJ4KEqk7zPFkUhZ5JIJtgzm4xbcm24hYDkHRioRyJmmRS tq/V3+1sJuUUwitm/bt4bAdwf70HM1cNx6brRHBOgip4I8wht2n7GfzPoGVtNtOtJvYC 0BeEdlVQNpSBgQQHRB/VZwai7eCPylU1jAfl6KkIwxoLpuGXvLSC6zExnOTPcZj808Iz leZg== X-Gm-Message-State: ANoB5pk4GmscC8YCCdsiuzY2Tak2QGJIcxFP+sLzdkyUq4NCuWV9TWil bXf1L/sE8Ia+Z9VGKFTdI0qBOA== X-Google-Smtp-Source: AA0mqf6p3rZ6O0OVw4hUrGNozzgAitQ9QVJ9blTJGAml+eH1lWfauMEDnESpyUls6Sygn0NkeUXOEw== X-Received: by 2002:a05:6512:456:b0:4b1:5bf0:df51 with SMTP id y22-20020a056512045600b004b15bf0df51mr419009lfk.674.1668153529875; Thu, 10 Nov 2022 23:58:49 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id a18-20020a056512391200b004b097f2c73dsm199930lfu.253.2022.11.10.23.58.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 23:58:49 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 08:58:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] dt-bindings: Convert active-semi PMIC docs to YAML schemas Content-Language: en-US To: Paul Cercueil Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, list@opendingux.net References: <20221105225803.39197-1-paul@crapouillou.net> <02c45ae9-61a4-9fc5-4daf-8c4c9df9a4a0@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/11/2022 22:08, Paul Cercueil wrote: > Hi Krzysztof, > > Le dim. 6 nov. 2022 à 10:55:11 +0100, Krzysztof Kozlowski > a écrit : >> On 05/11/2022 23:58, Paul Cercueil wrote: >>> Create YAML bindings for the Active-semi PMICs and remove the old >>> text >>> files. >>> >>> The bindings aren't perfect, for instance I couldn't find good >>> descriptions for the vendor properties in the "charger" node of the >>> ACT8945A because I am not familiar with the hardware and these >>> properties were not documented anywhere. >>> >>> The YAML schemas are a bit different than what is described in the >>> old >>> text files, because these were sometimes wrong or had missing >>> information. This is the case for the ACT8600 documentation, which >>> specified the valid node names for the regulators, while the driver >>> was >>> expecting different names. This led to the current situation where >>> we >>> have two different boards using different names for the regulators: >>> - arch/mips/boot/dts/ingenic/ci20.dts uses the names documented in >>> the >>> text file, >>> - arch/mips/boot/dts/ingenic/gcw0.dts uses the names that the driver >>> expects. >>> In theory, the driver should be fixed to follow the documentation, >>> and >>> accept both naming schemes. In practice though, when the PMIC node >>> was >>> added to the ci20.dts board file, the names were already wrong in >>> regards to what the driver expected, so it never really worked >>> correctly and wasn't tested properly. Furthermore, in that board the >>> consumers of the regulators aren't working for various other reasons >>> (invalid GPIOs, etc.). >>> >>> For that reason, for the ACT8600 bindings I decided to only use the >>> node >>> names that the driver expects (and that gcw0.dts uses), instead of >>> accepting both old and new names. A follow-up patch will update the >>> CI20 >>> board to use the new regulator names. >>> >>> Signed-off-by: Paul Cercueil >>> --- >>> >>> Notes: >>> v2: >>> - Avoid | character in descriptions that can be single-line >>> - Remove unevaluatedProperties when additionalProperties is >>> also present >>> - Remove useless inner parentheses in regular expressions >>> - Rename I2C nodes to just... i2c >>> - Remove node handles >>> >>> Note: >>> I set Liam Girdwood and Mark Brown as the maintainers by >>> default, since >>> it doesn't appear that anybody is managing the Active-semi >>> drivers, but >>> if anybody steps up I can update it. >> >> It should not be Liam and Mark, but someone having/knowing this >> particular hardware. > > Well, who would that be? > > I do have a board with the ACT8600, but that's about it. You or driver maintainer or recent contributors. Best regards, Krzysztof