Re: [PATCH] dt-bindings: interrupt-controller: convert loongson,ls1x-intc.txt to json-schema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 20/02/2023 11:36, Kelvin Cheung wrote:
> On Mon, Feb 20, 2023 at 6:28 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/02/2023 11:25, Kelvin Cheung wrote:
>>> On Mon, Feb 20, 2023 at 4:04 PM Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> On 18/02/2023 13:22, Keguang Zhang wrote:
>>>>> Convert the Loongson1 interrupt controller dt-bindings to json-schema.
>>>>>
>>>>> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
>>>>> ---
>>>>>  .../loongson,ls1x-intc.txt                    | 24 ---------
>>>>>  .../loongson,ls1x-intc.yaml                   | 51 +++++++++++++++++++
>>>>>  2 files changed, 51 insertions(+), 24 deletions(-)
>>>>>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>>>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>>>> deleted file mode 100644
>>>>> index a63ed9fcb535..000000000000
>>>>> --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt
>>>>> +++ /dev/null
>>>>> @@ -1,24 +0,0 @@
>>>>> -Loongson ls1x Interrupt Controller
>>>>> -
>>>>> -Required properties:
>>>>> -
>>>>> -- compatible : should be "loongson,ls1x-intc". Valid strings are:
>>>>> -
>>>>> -- reg : Specifies base physical address and size of the registers.
>>>>> -- interrupt-controller : Identifies the node as an interrupt controller
>>>>> -- #interrupt-cells : Specifies the number of cells needed to encode an
>>>>> -  interrupt source. The value shall be 2.
>>>>> -- interrupts : Specifies the CPU interrupt the controller is connected to.
>>>>> -
>>>>> -Example:
>>>>> -
>>>>> -intc: interrupt-controller@1fd01040 {
>>>>> -     compatible = "loongson,ls1x-intc";
>>>>> -     reg = <0x1fd01040 0x18>;
>>>>> -
>>>>> -     interrupt-controller;
>>>>> -     #interrupt-cells = <2>;
>>>>> -
>>>>> -     interrupt-parent = <&cpu_intc>;
>>>>> -     interrupts = <2>;
>>>>> -};
>>>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..4cea3ee9fbb1
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml
>>>>> @@ -0,0 +1,51 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Loongson-1 Interrupt Controller
>>>>
>>>> You changed the title, so this binding now will cover all Loonson-1
>>>> interrupt controllers?
>>>>
>>> Yes.
>>
>> OK, then with the dropped |
>>
> Sorry.
> Should I send the patch V2 to drop the description part?

Yes, please, with my tag.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540


Best regards,
Krzysztof