* [PATCH v1] colibri.dtsi: Refactor ASoC driver name
@ 2023-02-01 12:09 Markus Burri
2023-02-01 14:25 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Burri @ 2023-02-01 12:09 UTC (permalink / raw)
To: linux-kernel
Cc: Manuel Traut, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, Markus Burri
From: Manuel Traut <manuel.traut@mt.com>
ASoC driver names have a 15 character size limit:
[ 21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'
Use a name that fits.
Signed-off-by: Manuel Traut <manuel.traut@mt.com>
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..f50030cf208a 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -129,7 +129,7 @@ sound {
"LINE_IN", "Line In Jack",
"MIC_IN", "Mic Jack",
"Mic Jack", "Mic Bias";
- model = "imx6dl-colibri-sgtl5000";
+ model = "imx-sgtl5000";
mux-int-port = <1>;
mux-ext-port = <5>;
ssi-controller = <&ssi1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] colibri.dtsi: Refactor ASoC driver name
2023-02-01 12:09 [PATCH v1] colibri.dtsi: Refactor ASoC driver name Markus Burri
@ 2023-02-01 14:25 ` Fabio Estevam
2023-02-01 14:48 ` Krzysztof Kozlowski
2023-02-02 8:32 ` [PATCH v2] ARM: dts: imx6qdl-colibri: " Markus Burri
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-02-01 14:25 UTC (permalink / raw)
To: Markus Burri
Cc: linux-kernel, Manuel Traut, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
On Wed, Feb 1, 2023 at 9:09 AM Markus Burri <markus.burri@mt.com> wrote:
>
> From: Manuel Traut <manuel.traut@mt.com>
>
> ASoC driver names have a 15 character size limit:
> [ 21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'
>
> Use a name that fits.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
> Signed-off-by: Markus Burri <markus.burri@mt.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] colibri.dtsi: Refactor ASoC driver name
2023-02-01 12:09 [PATCH v1] colibri.dtsi: Refactor ASoC driver name Markus Burri
2023-02-01 14:25 ` Fabio Estevam
@ 2023-02-01 14:48 ` Krzysztof Kozlowski
2023-02-02 8:32 ` [PATCH v2] ARM: dts: imx6qdl-colibri: " Markus Burri
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-01 14:48 UTC (permalink / raw)
To: Markus Burri, linux-kernel
Cc: Manuel Traut, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel
On 01/02/2023 13:09, Markus Burri wrote:
> From: Manuel Traut <manuel.traut@mt.com>
>
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: dts: imx6qdl-colibri: Refactor ASoC driver name
2023-02-01 12:09 [PATCH v1] colibri.dtsi: Refactor ASoC driver name Markus Burri
2023-02-01 14:25 ` Fabio Estevam
2023-02-01 14:48 ` Krzysztof Kozlowski
@ 2023-02-02 8:32 ` Markus Burri
2 siblings, 0 replies; 4+ messages in thread
From: Markus Burri @ 2023-02-02 8:32 UTC (permalink / raw)
To: linux-kernel
Cc: Manuel Traut, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, Markus Burri
From: Manuel Traut <manuel.traut@mt.com>
ASoC driver names have a 15 character size limit:
[ 21.917463] imx-sgtl5000 sound: ASoC: driver name too long 'imx6dl-colibri-sgtl5000' -> 'imx6dl-colibri-'
Use a name that fits.
Signed-off-by: Manuel Traut <manuel.traut@mt.com>
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
index d8f985f297e4..f50030cf208a 100644
--- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
@@ -129,7 +129,7 @@ sound {
"LINE_IN", "Line In Jack",
"MIC_IN", "Mic Jack",
"Mic Jack", "Mic Bias";
- model = "imx6dl-colibri-sgtl5000";
+ model = "imx-sgtl5000";
mux-int-port = <1>;
mux-ext-port = <5>;
ssi-controller = <&ssi1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-02 8:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-01 12:09 [PATCH v1] colibri.dtsi: Refactor ASoC driver name Markus Burri
2023-02-01 14:25 ` Fabio Estevam
2023-02-01 14:48 ` Krzysztof Kozlowski
2023-02-02 8:32 ` [PATCH v2] ARM: dts: imx6qdl-colibri: " Markus Burri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).