From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Piyush Mehta <piyush.mehta@amd.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
balbi@kernel.org, michal.simek@xilinx.com
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
siva.durga.prasad.paladugu@amd.com, git@amd.com
Subject: Re: [PATCH V2] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt
Date: Thu, 11 May 2023 11:34:42 +0200 [thread overview]
Message-ID: <ca8b31f5-ce4e-d7b1-d077-3684862083bf@linaro.org> (raw)
In-Reply-To: <20230511072154.2030703-1-piyush.mehta@amd.com>
On 11/05/2023 09:21, Piyush Mehta wrote:
> The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> As the DWC3 IP supports the hibernation feature, to handle the wakeup
> or hibernation interrupt, add host mode "wakeup" interrupt-names
> optional property in the binding schema to capture remote-wakeup and
> connect/ disconnect event in the hibernation state.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
> Change in V2:
> - Addressed ROB review comments
> - Updated name of interrupt-names property with "wakeup"
> - Move interrupt-names property from dwc3-xilinx core to dwc3 core.
>
> Link: https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4StuHUm1kgchw@mail.gmail.com/
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 50edc4da780e..db512769bd80 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -53,6 +53,8 @@ properties:
> - const: dwc_usb3
> - items:
> enum: [host, peripheral, otg]
> + - items:
> + enum: [dwc_usb3, otg, wakeup]
You didn't add only "wakeup" but also dwc_usb3 which does not look
correct here as it is common interrupt. The change does not match commit
msg and I don't know what you actually want to achieve.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-11 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 7:21 [PATCH V2] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt Piyush Mehta
2023-05-11 9:34 ` Krzysztof Kozlowski [this message]
2023-05-12 6:57 ` Mehta, Piyush
2023-05-12 7:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8b31f5-ce4e-d7b1-d077-3684862083bf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
--cc=siva.durga.prasad.paladugu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).