From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FE3C433EF for ; Tue, 12 Jul 2022 07:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbiGLHp5 (ORCPT ); Tue, 12 Jul 2022 03:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiGLHp4 (ORCPT ); Tue, 12 Jul 2022 03:45:56 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA5209B9E2 for ; Tue, 12 Jul 2022 00:45:54 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id d12so12529534lfq.12 for ; Tue, 12 Jul 2022 00:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=siR3BgH5slJk3knBZkv4TTMZlcCDCcI0G+RmWKGiNJI=; b=PcDsBCjoEi7y2zXt0manejyoz9eTHAVOorbVHLfepdzeB7d6Y5KHhdQRIJ3t/hK1gn IK5wMZKa4wVLxN01Pp+x5/mnxgBPLB9m5NPTHF5SJRa0W6WEy6+Shyvl9cMAOMBIMB8D Fk51VL4LmQrZYo9qKGTgSvUOBTj4/K9cCV4F16zGa6pbBqsZxnDGsBkDil0TIffFk8RW WamN21t+0RZNI1iDtPpb2nOylVVtvpBPNWayVwAysgIO59HSuZ0iLAgU2DhDqKAUPgSH nwqp3lNipNUWf440glo2oOqWbrKl5LaWQEO5cuYUiJUFeUp4bWc6rqul3w3MqWGeWqqT fnuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=siR3BgH5slJk3knBZkv4TTMZlcCDCcI0G+RmWKGiNJI=; b=TRH6tbTypA6eqeS3H8ry7MtH15lneHXWjrx4GzRlzN9OhqQEX8QZjnNu/ooolef6Xi AEQa+4l+ZxZ0QK5w1BeStlYcxVGLj61DXZRJDI/9OqBRC+PIT2r3atVFnkhLysa4xj9E PmPcxAg+XJizIvhR/trgMsAkXdds60hSoNQ8rlQygjR8k2mqSXGWpc7Cgrs//MVMhmzs 9DScwM8qa54ScKtqWWWAMK4o/n3cFQ8qXpjPSCsOIK1cvl/tfPaH+nvtNzvjXIKm5lZn 2WaEGWCctzLDcG5igdz5FxUU/sCYvCmdsjriqwn4WJoO9sZawSkSzVdMXqf6t5xNvwyw nSUw== X-Gm-Message-State: AJIora+joecVVh4mr+xsBY8oSURtiqSptnGHhkQ/w8sVmRy7krIeszZu +7bjreKQozXqF5OZsgKlPmy1Nw== X-Google-Smtp-Source: AGRyM1u8DsjZupWlTyiGLXLSYB3FvxE1/dKdHt5I6jYe5YV8hK8ZK73y8NLMint5GufUPzx6SZyDyQ== X-Received: by 2002:a05:6512:23a0:b0:489:d19c:602d with SMTP id c32-20020a05651223a000b00489d19c602dmr8378703lfv.89.1657611953262; Tue, 12 Jul 2022 00:45:53 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id j16-20020ac25510000000b0048160c5e625sm2040845lfk.12.2022.07.12.00.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 00:45:52 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 09:45:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH 1/3] dt-bindings: arm64: bcmbca: Merge BCM4908 into BCMBCA Content-Language: en-US To: William Zhang , Linux ARM List Cc: kursad.oney@broadcom.com, anand.gore@broadcom.com, dan.beygelman@broadcom.com, f.fainelli@gmail.com, Broadcom Kernel List , joel.peshkin@broadcom.com, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220712021144.7068-1-william.zhang@broadcom.com> <20220712021144.7068-2-william.zhang@broadcom.com> From: Krzysztof Kozlowski In-Reply-To: <20220712021144.7068-2-william.zhang@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 04:11, William Zhang wrote: > Merge BCM4908 SoC device tree description into BCMBCA and combined > all BCM4908 chip variants into the same BCM4908 chip family item. Merge means you combine some entries, so I would expect to see the removal here as well. > > Each compatible string represent the whole chip family. The board > variants and chip varints go into the first and second enum in the > compatible string item list. > > Signed-off-by: William Zhang > --- > > .../bindings/arm/bcm/brcm,bcmbca.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > index d9dc4f22f4a5..906c3e1de372 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > @@ -28,6 +28,23 @@ properties: > - const: brcm,bcm47622 > - const: brcm,bcmbca > > + - description: BCM4908 Family based boards > + items: > + - enum: > + # BCM4908 SoC based boards > + - brcm,bcm94908 > + - asus,gt-ac5300 > + - netgear,raxe500 > + # BCM4906 SoC based boards > + - brcm,bcm94906 > + - netgear,r8000p > + - tplink,archer-c2300-v1 > + - enum: > + - brcm,bcm4908 > + - brcm,bcm4906 > + - brcm,bcm49408 This is wrong. brcm,bcm94908 followed by brcm,bcm4906 does not look like valid list of compatibles. > + - const: brcm,bcmbca > + > - description: BCM4912 based boards > items: > - enum: Best regards, Krzysztof