* [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format
[not found] <20220330064505.243799-1-jo@jsfamily.in>
@ 2022-03-30 6:45 ` Joel Selvaraj
2022-03-30 17:51 ` Caleb Connolly
2022-04-21 14:26 ` Bjorn Andersson
2022-03-30 6:45 ` [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver Joel Selvaraj
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Joel Selvaraj @ 2022-03-30 6:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir,
Joel Selvaraj
The "qcom/sdm845/" path conflicts with db845c's firmware that are
present in the linux-firmware package. Xiaomi uses their own signed
firmware for Poco F1 and can't use the db845c's firmware. So let's
use "qcom/sdm845/beryllium/" to distinguish Poco F1's firmware files.
For easier handling and packaging, the mdt+bXX files are squashed
using Bjorn Andersson's pil-squasher tool from this link:
https://github.com/andersson/pil-squasher
Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index 367389526b41..27ba9ad1ad02 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -121,7 +121,7 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
&adsp_pas {
status = "okay";
- firmware-name = "qcom/sdm845/adsp.mdt";
+ firmware-name = "qcom/sdm845/beryllium/adsp.mbn";
};
&apps_rsc {
@@ -208,7 +208,7 @@ vreg_l26a_1p2: ldo26 {
&cdsp_pas {
status = "okay";
- firmware-name = "qcom/sdm845/cdsp.mdt";
+ firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
};
&dsi0 {
@@ -262,7 +262,7 @@ &gpu {
zap-shader {
memory-region = <&gpu_mem>;
- firmware-name = "qcom/sdm845/a630_zap.mbn";
+ firmware-name = "qcom/sdm845/beryllium/a630_zap.mbn";
};
};
@@ -289,7 +289,7 @@ &mdss {
&mss_pil {
status = "okay";
- firmware-name = "qcom/sdm845/mba.mbn", "qcom/sdm845/modem.mdt";
+ firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
};
&pm8998_gpio {
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format
2022-03-30 6:45 ` [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format Joel Selvaraj
@ 2022-03-30 17:51 ` Caleb Connolly
2022-04-21 14:26 ` Bjorn Andersson
1 sibling, 0 replies; 9+ messages in thread
From: Caleb Connolly @ 2022-03-30 17:51 UTC (permalink / raw)
To: Joel Selvaraj, Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir
On 30/03/2022 07:45, Joel Selvaraj wrote:
> The "qcom/sdm845/" path conflicts with db845c's firmware that are
> present in the linux-firmware package. Xiaomi uses their own signed
> firmware for Poco F1 and can't use the db845c's firmware. So let's
> use "qcom/sdm845/beryllium/" to distinguish Poco F1's firmware files.
>
> For easier handling and packaging, the mdt+bXX files are squashed
> using Bjorn Andersson's pil-squasher tool from this link:
> https://github.com/andersson/pil-squasher
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 367389526b41..27ba9ad1ad02 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -121,7 +121,7 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
>
> &adsp_pas {
> status = "okay";
> - firmware-name = "qcom/sdm845/adsp.mdt";
> + firmware-name = "qcom/sdm845/beryllium/adsp.mbn";
> };
>
> &apps_rsc {
> @@ -208,7 +208,7 @@ vreg_l26a_1p2: ldo26 {
>
> &cdsp_pas {
> status = "okay";
> - firmware-name = "qcom/sdm845/cdsp.mdt";
> + firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
> };
>
> &dsi0 {
> @@ -262,7 +262,7 @@ &gpu {
>
> zap-shader {
> memory-region = <&gpu_mem>;
> - firmware-name = "qcom/sdm845/a630_zap.mbn";
> + firmware-name = "qcom/sdm845/beryllium/a630_zap.mbn";
> };
> };
>
> @@ -289,7 +289,7 @@ &mdss {
>
> &mss_pil {
> status = "okay";
> - firmware-name = "qcom/sdm845/mba.mbn", "qcom/sdm845/modem.mdt";
> + firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
> };
>
> &pm8998_gpio {
> --
> 2.35.1
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format
2022-03-30 6:45 ` [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format Joel Selvaraj
2022-03-30 17:51 ` Caleb Connolly
@ 2022-04-21 14:26 ` Bjorn Andersson
1 sibling, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2022-04-21 14:26 UTC (permalink / raw)
To: Andy Gross, Joel Selvaraj, Rob Herring
Cc: ~postmarketos/upstreaming, devicetree, linux-kernel,
linux-arm-msm, phone-devel, Amit Pundir
On Wed, 30 Mar 2022 12:15:02 +0530, Joel Selvaraj wrote:
> The "qcom/sdm845/" path conflicts with db845c's firmware that are
> present in the linux-firmware package. Xiaomi uses their own signed
> firmware for Poco F1 and can't use the db845c's firmware. So let's
> use "qcom/sdm845/beryllium/" to distinguish Poco F1's firmware files.
>
> For easier handling and packaging, the mdt+bXX files are squashed
> using Bjorn Andersson's pil-squasher tool from this link:
> https://github.com/andersson/pil-squasher
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format
commit: efbd3599154cb3d947564a9dce419a6754d233ef
[2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver
commit: 84b6c2420415767079baa24ffd70d048cd35bdd8
[3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property
commit: 1f1c494082a1f10d03ce4ee1485ee96d212e22ff
[4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel
commit: 3213b3741a147db59ed6f1ebc5f569854725b91f
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver
[not found] <20220330064505.243799-1-jo@jsfamily.in>
2022-03-30 6:45 ` [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format Joel Selvaraj
@ 2022-03-30 6:45 ` Joel Selvaraj
2022-03-30 17:52 ` Caleb Connolly
2022-03-30 6:45 ` [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property Joel Selvaraj
2022-03-30 6:45 ` [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel Joel Selvaraj
3 siblings, 1 reply; 9+ messages in thread
From: Joel Selvaraj @ 2022-03-30 6:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir,
Joel Selvaraj
Enable Qualcomm IP Accelerator (IPA) driver for mobile data functionality
which works by using ModemManager.
Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index 27ba9ad1ad02..801b8c5984a3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -292,6 +292,12 @@ &mss_pil {
firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
};
+&ipa {
+ status = "okay";
+ memory-region = <&ipa_fw_mem>;
+ firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
+};
+
&pm8998_gpio {
vol_up_pin_a: vol-up-active {
pins = "gpio6";
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver
2022-03-30 6:45 ` [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver Joel Selvaraj
@ 2022-03-30 17:52 ` Caleb Connolly
0 siblings, 0 replies; 9+ messages in thread
From: Caleb Connolly @ 2022-03-30 17:52 UTC (permalink / raw)
To: Joel Selvaraj, Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir
On 30/03/2022 07:45, Joel Selvaraj wrote:
> Enable Qualcomm IP Accelerator (IPA) driver for mobile data functionality
> which works by using ModemManager.
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 27ba9ad1ad02..801b8c5984a3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -292,6 +292,12 @@ &mss_pil {
> firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
> };
>
> +&ipa {
> + status = "okay";
> + memory-region = <&ipa_fw_mem>;
> + firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
> +};
> +
> &pm8998_gpio {
> vol_up_pin_a: vol-up-active {
> pins = "gpio6";
> --
> 2.35.1
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property
[not found] <20220330064505.243799-1-jo@jsfamily.in>
2022-03-30 6:45 ` [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format Joel Selvaraj
2022-03-30 6:45 ` [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver Joel Selvaraj
@ 2022-03-30 6:45 ` Joel Selvaraj
2022-03-30 17:54 ` Caleb Connolly
2022-03-30 6:45 ` [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel Joel Selvaraj
3 siblings, 1 reply; 9+ messages in thread
From: Joel Selvaraj @ 2022-03-30 6:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir,
Joel Selvaraj
vddio is misspelled with a "0" instead of "o". Fix it.
Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index 801b8c5984a3..f97900e7797b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -218,7 +218,7 @@ &dsi0 {
panel@0 {
compatible = "tianma,fhd-video";
reg = <0>;
- vddi0-supply = <&vreg_l14a_1p8>;
+ vddio-supply = <&vreg_l14a_1p8>;
vddpos-supply = <&lab>;
vddneg-supply = <&ibb>;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property
2022-03-30 6:45 ` [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property Joel Selvaraj
@ 2022-03-30 17:54 ` Caleb Connolly
0 siblings, 0 replies; 9+ messages in thread
From: Caleb Connolly @ 2022-03-30 17:54 UTC (permalink / raw)
To: Joel Selvaraj, Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir
On 30/03/2022 07:45, Joel Selvaraj wrote:
> vddio is misspelled with a "0" instead of "o". Fix it.
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 801b8c5984a3..f97900e7797b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -218,7 +218,7 @@ &dsi0 {
> panel@0 {
> compatible = "tianma,fhd-video";
> reg = <0>;
> - vddi0-supply = <&vreg_l14a_1p8>;
> + vddio-supply = <&vreg_l14a_1p8>;
> vddpos-supply = <&lab>;
> vddneg-supply = <&ibb>;
>
> --
> 2.35.1
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel
[not found] <20220330064505.243799-1-jo@jsfamily.in>
` (2 preceding siblings ...)
2022-03-30 6:45 ` [PATCH 3/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix typo in panel's vddio-supply property Joel Selvaraj
@ 2022-03-30 6:45 ` Joel Selvaraj
2022-03-30 17:55 ` Caleb Connolly
3 siblings, 1 reply; 9+ messages in thread
From: Joel Selvaraj @ 2022-03-30 6:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir,
Joel Selvaraj
Like the c630, the Poco F1 is also capable of using both antenna
channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
channel is used for bluetooth. Similar to Oneplus 6.
Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index f97900e7797b..798fc72578a7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -185,6 +185,12 @@ vreg_l21a_2p95: ldo21 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
+ vreg_l23a_3p3: ldo23 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
vreg_l24a_3p075: ldo24 {
regulator-min-microvolt = <3088000>;
regulator-max-microvolt = <3088000>;
@@ -547,6 +553,7 @@ &wifi {
vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
};
/* PINCTRL - additions to nodes defined in sdm845.dtsi */
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel
2022-03-30 6:45 ` [PATCH 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable second wifi channel Joel Selvaraj
@ 2022-03-30 17:55 ` Caleb Connolly
0 siblings, 0 replies; 9+ messages in thread
From: Caleb Connolly @ 2022-03-30 17:55 UTC (permalink / raw)
To: Joel Selvaraj, Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Amit Pundir
On 30/03/2022 07:45, Joel Selvaraj wrote:
> Like the c630, the Poco F1 is also capable of using both antenna
> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
> channel is used for bluetooth. Similar to Oneplus 6.
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index f97900e7797b..798fc72578a7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -185,6 +185,12 @@ vreg_l21a_2p95: ldo21 {
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l23a_3p3: ldo23 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3312000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> vreg_l24a_3p075: ldo24 {
> regulator-min-microvolt = <3088000>;
> regulator-max-microvolt = <3088000>;
> @@ -547,6 +553,7 @@ &wifi {
> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
> };
>
> /* PINCTRL - additions to nodes defined in sdm845.dtsi */
> --
> 2.35.1
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 9+ messages in thread