From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB90DCCA47B for ; Sun, 5 Jun 2022 15:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349656AbiFEPPL (ORCPT ); Sun, 5 Jun 2022 11:15:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351098AbiFEPPG (ORCPT ); Sun, 5 Jun 2022 11:15:06 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECDDC4D602 for ; Sun, 5 Jun 2022 08:15:03 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id o10so15769729edi.1 for ; Sun, 05 Jun 2022 08:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uUTCHtLrKiDbQl/tZcD1cs2OUjqwDsiGmSTmuLA8eFg=; b=OyHF3rulfwpQ+H4kM0gYuavsh+7RQuG/F/zHr0QsihBHUiUBlpMVnkgcz75akfkD+x 7lybdMqw3PIgKS64wtbHQhSEkL/LDHN3FIxPkabYVKZnXMMKjbcb/RHRqeBd35+KcKzw 8irsXRbo+ZQyZpOlng6sHNgF1hBOc4CRDzEWROwcV3/L/XNvbqZFpMm4Sbp7iqvEIKok b9AVzZjUM4HNrWRUhPLjzxIDveoiJA/VYz21urpzxMZOIOmCFd643zqnqeOuYgwZYFvg uapATNYf2N7VBrXO7cvo7P1i1qutovtxDA2Mrn5g2BhpLSvSh8i4OyqAMZJD7BX/4Vij 1Azg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uUTCHtLrKiDbQl/tZcD1cs2OUjqwDsiGmSTmuLA8eFg=; b=rAwsZgnWG8Je/TM6uR61I0SQr2PuoRc1SeENODy/EU7w9OgSaJ5+3zj+iKNqZh3zq0 ctIZkt58PXT+4FXLD7OVAznxMjiyt3ASSaF6VMEH4SayW85UKegSCWwnUOFqbI2XCFmt kjS8lHA7XAKM/9s98E78LWCQ82/DEYt5O308xDZ6G0itQScXHh/H2nMEcJBLaAPLoGFY Fky4GfUDtzornP/igBpTAdxVT1A5JgBWeyV0Zg/271yeiyrvgP1VnOyRtOtbwJ+mrYnI NFp89MCTZya6Rn9558sBiRYJbPn5Ce6gmbFXnX6jX0/6Q46KBImC007jb2cwispT1VGf BcFQ== X-Gm-Message-State: AOAM533f96xBMAbB2EyTA6yoOjFHeZoHG82KDAYlFm07niKSN7YCIgN9 wRDRlerpxc+rQMCq3v0NgEuW5g== X-Google-Smtp-Source: ABdhPJwRAfAIDWYX/hPmYOR71w9t0egsDQWp6p9WhbNqD1JeS7dZwZgdrj+Xnm4r3xmk8BEScZaxHQ== X-Received: by 2002:a05:6402:4255:b0:431:34c3:6018 with SMTP id g21-20020a056402425500b0043134c36018mr7082764edb.146.1654442102273; Sun, 05 Jun 2022 08:15:02 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id cz20-20020a0564021cb400b0042dd85bd23bsm6933493edb.55.2022.06.05.08.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 08:15:01 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 17:15:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH 2/2] dt-bindings: input: gpio-keys: document label and autorepeat properties Content-Language: en-US To: Dmitry Torokhov Cc: Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hansson , Andreas Kemnade References: <20220603101601.542054-1-krzysztof.kozlowski@linaro.org> <20220603101601.542054-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/06/2022 18:43, Dmitry Torokhov wrote: > On Fri, Jun 03, 2022 at 12:16:01PM +0200, Krzysztof Kozlowski wrote: >> The original text bindings documented "autorepeat" and "label" >> properties (in the device node, beside the nodes with keys). >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/input/gpio-keys.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml >> index 49d388dc8d78..b1c910a5e233 100644 >> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml >> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml >> @@ -15,6 +15,14 @@ properties: >> - gpio-keys >> - gpio-keys-polled >> >> + autorepeat: >> + type: boolean >> + description: >> + Enable operating system (not hardware) key auto repeat feature. > > Should we refer to the generic input device property here instead (one > on described in input.yaml)? You mean copy the description from input.yaml or say something like: "see input.yaml"? Best regards, Krzysztof