From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Wang <wanghongliang@loongson.cn>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
loongarch@lists.linux.dev
Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties
Date: Fri, 27 Mar 2026 07:39:42 +0100 [thread overview]
Message-ID: <ca984be0-e7a6-4897-bf9f-db9465942c6e@kernel.org> (raw)
In-Reply-To: <bc22bad4-9825-829d-1df0-a801ebd933d6@loongson.cn>
On 27/03/2026 04:09, Hongliang Wang wrote:
> The initial idea was that this patch could be used for both ACPI and DTS.
>>>> The i2c-ls2x driver is compatible with both Loongson 2K and 3A+7A
>>>> platform, parse
>>>> the same parameters regardless of dts or acpi parameter passing, So
>>>> clock-input
>>>> and clock-div attributes are defined to describe input clock of i2c
>>>> controller and
>>>> divisor of input clock. It can be used on both 2K and 3A+7A platform.
>>> And you cannot use them in DTS.
> OK
>> I need to keep guessing what you want to achieve, because neither your
>> message nor commit text was explicit
> What I want to achieve is to describe the input clock and divisor of I2C
> controller
Input clocks are defined as clock inputs obviously in DT, not as
integers. Bindings need to describe the hardware, so start with that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-27 6:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 1:18 [PATCH v2 0/2] i2c: ls2x: Add clock- related properties and parsing Hongliang Wang
2026-03-25 1:18 ` [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties Hongliang Wang
2026-03-25 11:42 ` Krzysztof Kozlowski
2026-03-25 11:43 ` Krzysztof Kozlowski
2026-03-26 2:12 ` Hongliang Wang
2026-03-26 7:02 ` Krzysztof Kozlowski
2026-03-26 7:49 ` Krzysztof Kozlowski
2026-03-26 11:48 ` Hongliang Wang
2026-03-26 12:23 ` Krzysztof Kozlowski
2026-03-27 2:06 ` Hongliang Wang
2026-03-27 3:09 ` Hongliang Wang
2026-03-27 6:39 ` Krzysztof Kozlowski [this message]
2026-03-26 7:21 ` Andi Shyti
2026-03-27 2:08 ` Hongliang Wang
2026-03-25 1:18 ` [PATCH v1 2/2] i2c: ls2x: Add clock-input and clock-div properties parsing Hongliang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca984be0-e7a6-4897-bf9f-db9465942c6e@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox