devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: soc@kernel.org, linux-kernel@vger.kernel.org,
	Olof Johansson <olof@lixom.net>,
	devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh@kernel.org>,
	arm@kernel.org, linux-input@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties
Date: Mon, 27 Jun 2022 10:17:23 +0200	[thread overview]
Message-ID: <cab6fd96-4b8e-42a3-4dce-db63656df92c@linaro.org> (raw)
In-Reply-To: <20220616005333.18491-1-krzysztof.kozlowski@linaro.org>

On 16/06/2022 02:52, Krzysztof Kozlowski wrote:
> The gpio-keys DT schema matches all properties with a wide pattern and
> applies specific schema to children.  This has drawback - all regular
> properties are also matched and are silently ignored, even if they are
> not described in schema.  Basically this allows any non-object property
> to be present.
> 
> Enforce specific naming pattern for children (keys) to narrow the
> pattern thus do not match other properties.  This will require all
> children to be properly prefixed or suffixed (button, event, switch or
> key).
> 
> Removal of "if:" within patternProperties causes drop of one indentation
> level, but there are no other changes in the affected block.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/input/gpio-keys.yaml  | 157 +++++++++---------
>  1 file changed, 77 insertions(+), 80 deletions(-)
> 

Dmitry,

Any comments from your side? Are you planning to pick up the dt-bindings
here (patch 1-3)?

Best regards,
Krzysztof

  reply	other threads:[~2022-06-27  8:17 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  0:52 [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Krzysztof Kozlowski
2022-06-16  0:52 ` [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties Krzysztof Kozlowski
2022-06-27  8:17   ` Krzysztof Kozlowski [this message]
2022-07-05 11:39     ` Krzysztof Kozlowski
2022-06-16  0:52 ` [PATCH v3 02/40] dt-bindings: input: gpio-keys: reference input.yaml and document properties Krzysztof Kozlowski
2022-06-16  0:52 ` [PATCH v3 03/40] dt-bindings: input: gpio-keys: accept also interrupt-extended Krzysztof Kozlowski
2022-06-16  0:52 ` [PATCH v3 04/40] dt-bindings: pinctrl: nuvoton,wpcm450-pinctrl: align key node name Krzysztof Kozlowski
2022-06-25 23:28   ` Linus Walleij
2022-06-26 10:28     ` Krzysztof Kozlowski
2022-06-27 22:18   ` Rob Herring
2022-06-28 19:26   ` Linus Walleij
2022-06-16  0:52 ` [PATCH v3 05/40] arm64: dts: apm: correct gpio-keys properties Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:52 ` [PATCH v3 06/40] arm64: dts: broadcom: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 07/40] arm64: dts: freescale: " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 08/40] arm64: dts: freescale: align led " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 09/40] arm64: dts: hisilicon: align gpio-key " Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-21  2:29     ` Wei Xu
2022-06-16  0:53 ` [PATCH v3 10/40] arm64: dts: hisilicon: correct gpio-keys properties Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-21  2:28     ` Wei Xu
2022-06-16  0:53 ` [PATCH v3 11/40] arm64: dts: marvell: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-22  8:32   ` Krzysztof Kozlowski
2022-06-27  8:42     ` Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 12/40] arm64: dts: marvell: armada-3720: align lednode " Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 13/40] ARM: dts: marvell: align gpio-key node " Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 14/40] ARM: dts: marvell: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 15/40] arm64: dts: mediatek: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-17 10:43   ` Matthias Brugger
2022-06-16  0:53 ` [PATCH v3 16/40] arm64: dts: mediatek: mt7622-bananapi-bpi-r64: align led " Krzysztof Kozlowski
2022-06-17 10:43   ` Matthias Brugger
2022-06-16  0:53 ` [PATCH v3 17/40] arm64: dts: mediatek: mt7622-rfb1: correct gpio-keys properties Krzysztof Kozlowski
2022-06-17 10:41   ` Matthias Brugger
2022-06-17 23:18     ` Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 18/40] ARM: dts: mediatek: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-17 10:44   ` Matthias Brugger
2022-06-16  0:53 ` [PATCH v3 19/40] arm64: dts: tegra: " Krzysztof Kozlowski
2022-06-24 16:08   ` Thierry Reding
2022-06-24 16:09     ` Krzysztof Kozlowski
2022-06-27  8:45       ` Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 20/40] ARM: " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 21/40] arm64: dts: qcom: " Krzysztof Kozlowski
2022-06-22  8:33   ` Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-07-03  3:56   ` Bjorn Andersson
2022-06-16  0:53 ` [PATCH v3 22/40] arm64: dts: qcom: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-07-03  3:56   ` Bjorn Andersson
2022-06-16  0:53 ` [PATCH v3 23/40] arm64: dts: qcom: sdm630-sony-xperia-nile: drop unneeded status from gpio-keys Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-07-03  3:56   ` Bjorn Andersson
2022-06-16  0:53 ` [PATCH v3 24/40] arm64: dts: qcom: align led node names with dtschema Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-07-03  3:56   ` Bjorn Andersson
2022-06-16  0:53 ` [PATCH v3 25/40] ARM: dts: qcom: align gpio-key " Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 26/40] arm64: dts: rockchip: " Krzysztof Kozlowski
2022-06-22  8:34   ` Krzysztof Kozlowski
2022-06-22 12:52     ` Heiko Stuebner
2022-06-16  0:53 ` [PATCH v3 27/40] ARM: " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 28/40] ARM: dts: rockchip: rk3288-tinker: correct gpio-keys properties Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 29/40] arm64: dts: ti: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 30/40] arm64: dts: xilinx: " Krzysztof Kozlowski
2022-06-23  8:10   ` Michal Simek
2022-06-16  0:53 ` [PATCH v3 31/40] ARM: " Krzysztof Kozlowski
2022-06-23  8:10   ` Michal Simek
2022-06-16  0:53 ` [PATCH v3 32/40] ARM: dts: omap: " Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 33/40] ARM: dts: omap: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 34/40] ARM: dts: animeo: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 35/40] ARM: dts: animeo: correct gpio-keys properties Krzysztof Kozlowski
2022-06-20 11:14   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 36/40] ARM: dts: aspeed: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-27  8:49   ` Krzysztof Kozlowski
2022-07-05 11:42     ` Krzysztof Kozlowski
2022-07-05 11:45   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 37/40] ARM: dts: aspeed: correct gpio-keys properties Krzysztof Kozlowski
2022-07-05 11:45   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 38/40] ARM: dts: at91: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-16  7:41   ` Claudiu.Beznea
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 39/40] ARM: dts: at91: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27  9:15   ` (subset) " Krzysztof Kozlowski
2022-06-16  0:53 ` [PATCH v3 40/40] ARM: dts: at91: drop unneeded status from gpio-keys Krzysztof Kozlowski
2022-06-27  9:16   ` (subset) " Krzysztof Kozlowski
2022-06-18  3:02 ` (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Nishanth Menon
2022-06-22 19:47 ` Heiko Stuebner
2022-07-03  3:56 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cab6fd96-4b8e-42a3-4dce-db63656df92c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).