From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D83C4167B for ; Tue, 30 Nov 2021 11:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234687AbhK3LuY (ORCPT ); Tue, 30 Nov 2021 06:50:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241180AbhK3Ltm (ORCPT ); Tue, 30 Nov 2021 06:49:42 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD29C061377 for ; Tue, 30 Nov 2021 03:46:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0B6B1CE18B8 for ; Tue, 30 Nov 2021 11:46:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B290C53FD2; Tue, 30 Nov 2021 11:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638272758; bh=NaJPt5ZfhcOqGwPuUoJxkdXpkvIfXMuvm1EjiLlhrA8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=l6SVrj96Z9TEcxscLwygYJqGqnP8XY6ccBjU5L1bUR0Xu+aCdPbem7raqQp1lWlj3 zyjudDEyIVFZ4AggYGgiY3bT1/KgrszWwdWGwY6ifHsyaOm3Ojxrmc0o7GfOflxJ/U zcU6cu6hqs1uyOJraEnZKJiu3bI/j/7EKsJXAEBCWcuW32wNZfq1jUq7Y6Xfl+jrA+ rEfivr+GXb8t0jthTGX8x5nfZxPGd8oKGba6Bv6gh1U3fO8L1asf8sNAPIUX9Zgwlv GZ2wlmvH/taqmPK+IxH90TobtHa1yWSSdiOmOoj565egkY0sgto89YFvVuFXIYWfv4 kblF0b/QpOLaQ== Message-ID: Subject: Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline From: nicolas saenz julienne To: Maxime Ripard , Scott Branden , Rob Herring , Frank Rowand , Ray Jui , Florian Fainelli , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Cc: linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Date: Tue, 30 Nov 2021 12:45:49 +0100 In-Reply-To: <20211117145040.334827-1-maxime@cerno.tech> References: <20211117145040.334827-1-maxime@cerno.tech> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Maxime, On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote: > Hi, > > The VC4 driver has had limited support to disable the HDMI controllers and > pixelvalves at boot if the firmware has enabled them. > > However, this proved to be limited, and a bit unreliable so a new firmware > command has been introduced some time ago to make it free all its resources and > disable any display output it might have enabled. > > This series takes advantage of that command to call it once the transition from > simplefb to the KMS driver has been done. I think it would make sense to integrate this funtionality into 'reset/reset-raspberrypi.c' and pass it to VC4 as a reset controller. It fits the same startup situation as the one we have with the USB controller. Also, it would contain the firmware weirdness in a single spot. Otherwise, please use 'devm_rpi_firmware_get()'. Regards, Nicolas