From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E5E170A27; Fri, 27 Sep 2024 07:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727420549; cv=none; b=B4M3dXS9QTbNqEwSUPHFhRU35/kyPUujuWs9TqGrcyD62jGWkQ3SgjKPF7RvPw8I2AFQQd2AvCUwdHf4twECZvPovhrfNa0PrE0MQTF+VKhdcQJOm7Bf7BHWRJtIiqeL4r1Sy5Uebt6kvpsMJ4DAmKZ2jE6W1SgCAt7v2lfz+7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727420549; c=relaxed/simple; bh=pPETlumeZfk8BUPmC9xV20OEoFe4aY3SU6T58FRAyGw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=gBCfi/oDFEciZaKJ59rHeU6IfORNmB1bvivKJAVBUTNypo4ohHC2bwaNFOip8fZHgWrPxGSj8qGwpyYn+exipDMenz424cZe9M8TIJsu39l0Ag50V9t/XR6aNlsLDdZiOmofcm0Te4scC2A+fqo//7Jgt0QiQGLYopZexvZHRtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=sFZxV/xM; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="sFZxV/xM" X-UUID: 711e366a7c9e11ef8b96093e013ec31c-20240927 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=KhtQyrefSaqhSJzfUoA/J9/fh2qANj+W43YRxUZuX+Y=; b=sFZxV/xMwDiMvGobRU1JZm9noSsIRRD6f12cT9MGhE0Vt6gX3NbjWyoTEoXCt8GhMJDvXHXjZFhc3uFKRfl1Vsdxq9WpEVsVr1MiQcG8XPB9A+itFlc6Al1om2XlgJxw81u1papC5tARdGLCkbPaRX8Eto6gjMWYYVQKP7cCuEc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:924ae4d4-a6bc-4587-8123-3ac05e45ecf9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6dc6a47,CLOUDID:61f0dad0-7921-4900-88a1-3aef019a55ce,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|-5,EDM:-3,IP:ni l,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 711e366a7c9e11ef8b96093e013ec31c-20240927 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1549227480; Fri, 27 Sep 2024 15:02:21 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 27 Sep 2024 15:02:19 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 27 Sep 2024 15:02:18 +0800 Message-ID: Date: Fri, 27 Sep 2024 15:02:17 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 5/5] dt-bindings: display: mediatek: dpi: Add mt8195 support in power domains Content-Language: en-US To: Conor Dooley CC: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yong Wu , "Joerg Roedel" , Will Deacon , Robin Murphy , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Jitao shi , Tinghan Shen , Seiya Wang , Ben Lok , "Nancy . Lin" , , , , , , , "Alexandre Mergnat" , Bear Wang , "Pablo Sun" , Macpaul Lin , Sen Chu , Chris-qj chen , "MediaTek Chromebook Upstream" , Chen-Yu Tsai References: <20240926111449.9245-1-macpaul.lin@mediatek.com> <20240926111449.9245-5-macpaul.lin@mediatek.com> <20240926-visible-harmonica-a7cda103ff70@spud> From: Macpaul Lin In-Reply-To: <20240926-visible-harmonica-a7cda103ff70@spud> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--11.014300-8.000000 X-TMASE-MatchedRID: L8tZF6zWW2oOwH4pD14DsPHkpkyUphL9MZm0+sEE9ms+zqOf/RM2rvFo ODtDoX2Qa8dzyZlF6/UhzQ5Mp0WQPT7dljlY/nlHSEQN/D/3cG6Vq+okl1rYDwDqzaYhcjeQLPv NvFI8A1X8iIBnP6y347s9OusH9JJyzB1CJ6qmdNrhuXUWQoMQtzQsOZ4mhPfZDO+DX+rUwfZjOk Y6jTBnQ10EtLM2oIeDMPuSmMtOM67I2RqSAXh33hlckvO1m+JcfLPKYyLDlAebKItl61J/ycnjL TA/UDoAoTCA5Efyn8CNo+PRbWqfRDsAVzN+Ov/stFRELSGgUUwRPXFwDjp7875XMMt8JxNIHRRl YMHNv0WZTXkb2/rFPg== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.014300-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: A017A170104B5427D244883B62BFD51C539651236B943B919967563A14DF14A42000:8 On 9/26/24 23:59, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 07:14:49PM +0800, Macpaul Lin wrote: >> Add power domain binding to the mediatek DPI controller for MT8185. > > This wording is confusing, no binding is being added here, you're just > allowing one property. > >> The dpi node in mt8195.dtsi was triggering a dtbs_check error: >> dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] > > And while it is good to have the warning, it would be better to explain > here that there are actually power domains, since the dts could be wrong > here also. Thanks for the reminder! After MediaTek's internal discussion, a new patch v3 has been submitted. The details has been written in that patch. > Otherwise, > Acked-by: Conor Dooley Since the new patch v3 use a different approach to update the DT Schema, the "Acked-by:" tag has been dropped, please help to review the replacement v3 patch. Thanks! >> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") >> Signed-off-by: Macpaul Lin >> --- >> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> Changes for v2: >> - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. >> [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ >> We still need this change to fix the 2 dtbs_check errors. >> So keeps no change here. >> Best regards, Macpaul Lin