From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD12D3FE375; Wed, 10 Jun 2026 12:13:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781093616; cv=none; b=MmrSh0QnzLx20bEtzNVLzd/8oySRIgaDPvLVe74uGidanMNOC/c9w7zlQRJFCBzg+sj0FkY6p5gCwgCDWbGhYKm9KztXUnm4h+IILNwbfjGsL/GZFAM0ydqDNSFo41g4I67i27r9LAB3/PYJGNQuTphwUaS/KhMGIEX6wCMDGEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781093616; c=relaxed/simple; bh=/xiMunDatToBsmStrrTWrLizGI4ssFXYAuwPgP9sK/4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ahcw13FJFqjISUETZ4Uk6hH9Fs4CI/SXJnos9XZCPHS1n61mM8N4zFi8DrwI0Pa2jV5S0KhnrrtTVfOkWTUoV0Y7/FxAcow1EtaIE4yaQaRBfV1/UvzT4PXdxKN0GoFlqhdCw0uXBVAm//Z1/9xS+vtSEUNLNSWsj3QvQCSZKU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TcnXzgdb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TcnXzgdb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C47A1F00898; Wed, 10 Jun 2026 12:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781093614; bh=PLw6uU78BIy4nXyeh53q4Xa1pNL6CePfrXCw0nypxAU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TcnXzgdbLkOizHQIcF3GC5DDqA6io8RAwuHhATh49oW4LHZf6ujvKtBj/62MrPh7w qYsGbXW5zdovitKU9GyHW1SN1CXv5W0pQUCIpioYDaRXi14VlLkUeQY3rtr1r6akEk Aa9MgDtBeDrRhTJVinx1s9tQQ/fve2V+ak286zMKtwRWRf6Dy66p/WPJRxYg7JKiQU PhLUsrz+3sd4WrKZGXGZupb8EVDgspBYyN0YJFO9nawGgRX6qQpeAeiSNnhlolOWd4 kXQi2aubed0kstXpSJkGEv9oiUVd7ZJOGcbt/SQoc218UDv412E7huhnj/t8lm/eHG hay1dkBUiTlzA== Message-ID: Date: Wed, 10 Jun 2026 14:13:28 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] arm64: dts/media: qcom: keep PLL8 out of Purwa camss hot path To: Ramshouriesh , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mauro Carvalho Chehab , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Bryan O'Donoghue , Vinod Koul , Neil Armstrong Cc: Aleksandrs Vinarskis , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org References: <20260610-a14-himax-hm1092-v1-0-0c9907da47ed@gmail.com> <20260610-a14-himax-hm1092-v1-6-0c9907da47ed@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260610-a14-himax-hm1092-v1-6-0c9907da47ed@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/06/2026 13:09, Ramshouriesh wrote: > cam_cc_pll8 (defined in camcc-x1e80100.c) doesn't latch on Purwa > silicon. "Lucid PLL latch failed. Output may be unstable!" fires from > wait_for_pll() whenever something asks for a PLL8-sourced rate, and > the camera pipeline ends up dead with "Failed to start media > pipeline: -32" even after the qcom,x1p42100-camss compatible is in > place. > > PLL8 sneaks into the streaming path via two RCG freq tables: the > slow_ahb RCG defaults to its 64 MHz entry (PLL8-sourced) when CSID > pulls it during csid_set_power, and vfe_lite picks its highest entry > (480 MHz, also PLL8) at streamon. > > Fix this from the DT side: > > * pin slow_ahb at 80 MHz via assigned-clock-rates in purwa.dtsi so > the RCG is reprogrammed to PLL0_OUT_EVEN at clk-init time and > never reaches PLL8; > * drop the 480 MHz entry from the Purwa vfe_lite clock_rate array > so the driver caps at 400 MHz (PLL0_OUT_ODD). > > I went poking at the Qualcomm Windows BSP shipped for the UX3407QA to > see what rates the vendor side actually uses. The AeoB resource blob > at qccamplatform_ext8380/CAMP_{PERF,RES}_MTP.bin lists the camera > clocks Windows enables, and PLL8 isn't referenced once. For CCI in > particular Windows runs at 37.5 MHz off PLL0_OUT_EVEN, not the > 30 MHz/PLL8 alternative the Linux driver happens to pick first. > Whether PLL8 is fused off, trust-zone-only, or just unwired on this > SoC I don't know, but treating it as unavailable matches what the > vendor does. > > Signed-off-by: Ramshouriesh > --- > arch/arm64/boot/dts/qcom/purwa.dtsi | 12 ++++++++++++ > drivers/media/platform/qcom/camss/camss.c | 16 ++++++++-------- You cannot combine such changes. DTS must be separate, see submitting patches in DT, DTS coding style, SoC maintainer profile... Best regards, Krzysztof