* [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings
@ 2022-08-16 8:38 Lad Prabhakar
2022-08-16 9:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Lad Prabhakar @ 2022-08-16 8:38 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven
Cc: linux-spi, devicetree, linux-kernel, linux-renesas-soc, Prabhakar,
Biju Das, Lad Prabhakar
With 'unevaluatedProperties' support implemented, there's a number of
warnings when running dtbs_check:
arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: spi@e6e90000: Unevaluated properties are not allowed ('power-domains', 'resets' were unexpected)
From schema: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
The main problem is that SoC DTSI's include power-domains and resets
property, whereas the renesas,sh-msiof.yaml has 'unevaluatedProperties:
false'. So just add optional power-domains and resets properties.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
index 5de710adfa63..7bd86cf876f1 100644
--- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
+++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
@@ -69,6 +69,10 @@ properties:
clocks:
maxItems: 1
+ power-domains: true
+
+ resets: true
+
num-cs:
description: |
Total number of chip selects (default is 1).
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings
2022-08-16 8:38 [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings Lad Prabhakar
@ 2022-08-16 9:45 ` Krzysztof Kozlowski
2022-08-18 18:21 ` Lad, Prabhakar
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-16 9:45 UTC (permalink / raw)
To: Lad Prabhakar, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven
Cc: linux-spi, devicetree, linux-kernel, linux-renesas-soc, Prabhakar,
Biju Das
On 16/08/2022 11:38, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: spi@e6e90000: Unevaluated properties are not allowed ('power-domains', 'resets' were unexpected)
> From schema: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
>
> The main problem is that SoC DTSI's include power-domains and resets
> property, whereas the renesas,sh-msiof.yaml has 'unevaluatedProperties:
> false'. So just add optional power-domains and resets properties.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> index 5de710adfa63..7bd86cf876f1 100644
> --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> @@ -69,6 +69,10 @@ properties:
> clocks:
> maxItems: 1
>
> + power-domains: true
> +
> + resets: true
No. For both you need maxItems (or describe the items).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings
2022-08-16 9:45 ` Krzysztof Kozlowski
@ 2022-08-18 18:21 ` Lad, Prabhakar
0 siblings, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2022-08-18 18:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lad Prabhakar, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven, linux-spi,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Linux-Renesas, Biju Das
Hi Krzysztof,
Thank you for the review.
On Tue, Aug 16, 2022 at 10:45 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 16/08/2022 11:38, Lad Prabhakar wrote:
> > With 'unevaluatedProperties' support implemented, there's a number of
> > warnings when running dtbs_check:
> >
> > arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: spi@e6e90000: Unevaluated properties are not allowed ('power-domains', 'resets' were unexpected)
> > From schema: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> >
> > The main problem is that SoC DTSI's include power-domains and resets
> > property, whereas the renesas,sh-msiof.yaml has 'unevaluatedProperties:
> > false'. So just add optional power-domains and resets properties.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > index 5de710adfa63..7bd86cf876f1 100644
> > --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > @@ -69,6 +69,10 @@ properties:
> > clocks:
> > maxItems: 1
> >
> > + power-domains: true
> > +
> > + resets: true
>
> No. For both you need maxItems (or describe the items).
>
Agreed, I will fix it and send a v2.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-18 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-16 8:38 [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-16 9:45 ` Krzysztof Kozlowski
2022-08-18 18:21 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).