From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E4AC7EE2C for ; Fri, 26 May 2023 13:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243759AbjEZNiH (ORCPT ); Fri, 26 May 2023 09:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237082AbjEZNiG (ORCPT ); Fri, 26 May 2023 09:38:06 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83EB9B for ; Fri, 26 May 2023 06:38:04 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f6e68cc738so5528655e9.1 for ; Fri, 26 May 2023 06:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685108283; x=1687700283; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kRNhz/1ssZp7GmMjGCU/2aCWcpCSy7S5uy3uYHdmw7Y=; b=UK2zb07TRRz408dzHN0N/0vYmIJfV431IB7X8ANOYPkRHJPIfACk52Z+ortc1DPIGR ym3FHdPARthYj9fHb1Y77DWDBlDDxcN6mz8VnzkIC83BfLSOozkYbj6WeZWqN84w5zhB 48eJuVq+F92uKNK/YsObvKq0i/YjH6oNpyqSFUqJOYhaJC+bb8iExFUzUgidocdy+UQ7 v+fwn+FgrB1OTSQpbGwM5C0/mHtFV4UHHIgIasF4MVW0cfxPC89wAdiYN3fUfwQ4kTEF DjUMj8J6g4qvUnl762VOKsF3aEmswJ4TZUDK1gGmpRlkYSNOvnChdVdAh3HR0Oix55pz EQHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685108283; x=1687700283; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kRNhz/1ssZp7GmMjGCU/2aCWcpCSy7S5uy3uYHdmw7Y=; b=V14Je4VoI1CCQ1vVW54KjbjhX0BSZPVqSdOe1ZJ/3HjKi+HnCoFAyvDL+mFFKT5wyM uOcdqrZbfpaDmB+S3GwT3SuZDApjYWcNaNAEk/B4ntMbetGZMvc6eNxOROyViUUx6kmH CvfA5+geBKQIZdlzZWys+9QMZKuH+D/W2f2KXfhfhHpLO+SdmL6c3MF/r87CqEJMoFpQ xhqqhbBWmEDUZrr91gdDWFw1RzJctgL491RPPk6J6zErPx5DYxvIqrJ9HYXyrdZqyYhe tPN9zxIM94JgNIltQEo+cJWPUgwtCiDYil5El60cjyx2HkX2mH0EgwbXW71GcAGxdglH tbXA== X-Gm-Message-State: AC+VfDxyZsm35NxnoF4aPdkdZo7QtjCo2MSTLdUpQC+ZETsnzgrKPqjc ydkE32fwXYWK7xBnqCa3CQgzyA== X-Google-Smtp-Source: ACHHUZ4/TvkidQGqm2je1FAQ3GSQm0puIZ2fO6yxBGt5bIoGb3dqxAif8j+LCNz9JMwYn75vWYsdtg== X-Received: by 2002:a7b:c412:0:b0:3f5:fa8e:aaa3 with SMTP id k18-20020a7bc412000000b003f5fa8eaaa3mr1595377wmi.28.1685108283226; Fri, 26 May 2023 06:38:03 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id n11-20020a05600c294b00b003f6129d2e30sm8900220wmd.1.2023.05.26.06.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 06:38:02 -0700 (PDT) Message-ID: Date: Fri, 26 May 2023 14:38:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/8] arm64: dts: qcom: msm8916: Fix regulator constraints Content-Language: en-US To: Stephan Gerhold , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20230510-msm8916-regulators-v1-0-54d4960a05fc@gerhold.net> <20230510-msm8916-regulators-v1-3-54d4960a05fc@gerhold.net> From: Bryan O'Donoghue In-Reply-To: <20230510-msm8916-regulators-v1-3-54d4960a05fc@gerhold.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/05/2023 19:48, Stephan Gerhold wrote: > The regulator constraints for most MSM8916 devices (except DB410c) were > originally taken from Qualcomm's msm-3.10 vendor device tree (for lack > of better documentation). Unfortunately it turns out that Qualcomm's > voltages are slightly off as well and do not match the voltage > constraints applied by the RPM firmware. > > This means that we sometimes request a specific voltage but the RPM > firmware actually applies a much lower or higher voltage. This is > particularly critical for pm8916_l11 which is used as SD card VMMC > regulator: The SD card can choose a voltage from the current range of > 1.8 - 2.95V. If it chooses to run at 1.8V we pretend that this is fine > but the RPM firmware will still silently end up configuring 2.95V. > This can be easily reproduced with a multimeter or by checking the > SPMI hardware registers of the regulator. > > Fix this by making the voltages match the actual "specified range" in > the PM8916 Device Specification which is enforced by the RPM firmware. > > Signed-off-by: Stephan Gerhold > --- > arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts | 12 ++++++------ > arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 14 +++++++------- > arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts | 12 ++++++------ > 13 files changed, 89 insertions(+), 89 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > index 13cd9ad167df..0d517804e44e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > @@ -159,13 +159,13 @@ &smd_rpm_regulators { > vdd_l7-supply = <&pm8916_s4>; > > s3 { > - regulator-min-microvolt = <1200000>; > - regulator-max-microvolt = <1300000>; > + regulator-min-microvolt = <1250000>; > + regulator-max-microvolt = <1350000>; Where are you getting these 5s from ? > }; > > s4 { > - regulator-min-microvolt = <1800000>; > - regulator-max-microvolt = <2100000>; > + regulator-min-microvolt = <1850000>; > + regulator-max-microvolt = <2150000>; > }; > > l1 { > @@ -199,7 +199,7 @@ l7 { > }; > > l8 { > - regulator-min-microvolt = <2850000>; > + regulator-min-microvolt = <2900000>; > regulator-max-microvolt = <2900000>; > }; > > @@ -209,12 +209,12 @@ l9 { > }; > > l10 { > - regulator-min-microvolt = <2700000>; > + regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > }; > > l11 { > - regulator-min-microvolt = <1800000>; > + regulator-min-microvolt = <2950000>; Wouldn't 1v8 be the right voltage for eMMC !SD though have you tested eMMC instead of SD ? --- bod