From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBAC9C433EC for ; Mon, 27 Jul 2020 09:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94D9020672 for ; Mon, 27 Jul 2020 09:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="W6LDg0aO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbgG0JuV (ORCPT ); Mon, 27 Jul 2020 05:50:21 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:28866 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgG0JuU (ORCPT ); Mon, 27 Jul 2020 05:50:20 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595843419; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: To: Subject: Sender; bh=Kbjy0E1cyBAH7os5xRP4ZFWN/pUN1FsBi0P64wEC5LI=; b=W6LDg0aOzx8hdKk8VOvMNRlcClaESEKp3jB6Mhy80bsXDTut+hfhS3iqRKPMPGUuVqm1IvOM KA9kT/H53sBt8UJKxO/4wWhHmWSkBEGHaG7h4kZauWLTQ/9ih1wv+fZQ1OEC0xSshQLsDwcB ExNep8XO+yBx3B2FN4kFnHL/FLc= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f1ea355634c4259e31b7b89 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 27 Jul 2020 09:50:13 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E1D83C433A0; Mon, 27 Jul 2020 09:50:12 +0000 (UTC) Received: from [192.168.0.129] (unknown [183.83.142.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rohitkr) by smtp.codeaurora.org (Postfix) with ESMTPSA id 119ACC433C9; Mon, 27 Jul 2020 09:50:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 119ACC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=rohitkr@codeaurora.org Subject: Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant To: Srinivas Kandagatla , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1595413915-17867-1-git-send-email-rohitkr@codeaurora.org> From: Rohit Kumar Message-ID: Date: Mon, 27 Jul 2020 15:20:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote: > > > On 22/07/2020 11:31, Rohit kumar wrote: >> This patch chain add audio support for SC7180 soc by doing the required >> modification in existing common lpass-cpu/lpass-platform driver. >> This also fixes some concurrency issue. >> >> Changes since v3: >>     - Fixed yaml documentation comments and make dt_binding_check >> issues. >>     - Moved general fixes out of sc7180 specific patches as suggested >> by Srinivas. >>     - Update clock-names to make it same as existing platforms. >> >> Ajit Pandey (4): >>    ASoC: qcom: Add common array to initialize soc based core clocks >>    ASoC: qcom: lpass-platform: Replace card->dev with component->dev >>    include: dt-bindings: sound: Add sc7180-lpass bindings header >>    ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio >> >> Rohit kumar (8): >>    ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function >>    ASoC: qcom: lpass-platform: fix memory leak >>    ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers >>    ASoC: qcom: lpass-cpu: fix concurrency issue >>    dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node >>    ASoC: qcom: lpass-cpu: Use platform_get_resource >>    ASoC: qcom: lpass-platform: Use platform_get_irq >>    dt-bindings: sound: lpass-cpu: Move to yaml format > > Thanks Srini for review and testing. Mark, I am planning to repost patch07 onwards to address comments by Rob as there are no comments till patch06 and they are just fixes. > Tested this on Dragon Board 410c! > > Tested-by: Srinivas Kandagatla > > --srini >> >>   .../devicetree/bindings/sound/qcom,lpass-cpu.txt   |  79 -------- >>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  | 185 >> ++++++++++++++++++ >>   include/dt-bindings/sound/sc7180-lpass.h           |  10 + >>   sound/soc/qcom/Kconfig                             |   5 + >>   sound/soc/qcom/Makefile                            |   2 + >>   sound/soc/qcom/lpass-apq8016.c                     |  86 ++++++-- >>   sound/soc/qcom/lpass-cpu.c                         | 204 >> ++++++++++--------- >>   sound/soc/qcom/lpass-ipq806x.c                     |  67 +++++++ >>   sound/soc/qcom/lpass-lpaif-reg.h                   | 157 >> ++++++++------- >>   sound/soc/qcom/lpass-platform.c                    | 155 >> +++++++++++---- >>   sound/soc/qcom/lpass-sc7180.c                      | 216 >> +++++++++++++++++++++ >>   sound/soc/qcom/lpass.h                             |  63 +++++- >>   12 files changed, 930 insertions(+), 299 deletions(-) >>   delete mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt >>   create mode 100644 >> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >>   create mode 100644 include/dt-bindings/sound/sc7180-lpass.h >>   create mode 100644 sound/soc/qcom/lpass-sc7180.c >> -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.