From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA2F1494C3 for ; Thu, 25 Dec 2025 01:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766627587; cv=none; b=dN7s23AGfRvhlSw7yg/EWsfHBLt7JzXWT/rfMg20AycOzIgcOharaErQT1KezcdsWI3EBmen8FVsBEz07j0MBIOrV+IAmLZClURCg8MYBe05qAM9+RIY8gr1+GFGKI+03rc9msa8XA0AiWjibrfiCM55GUprzN933wduZcYUEGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766627587; c=relaxed/simple; bh=mYzkf3+PsUIQuSbRNfj15k0S+WOc26MP9FLu8OCGn3g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IwR2rcRjWsg1nJsNc2gPEz/WcXbRFMlx2X+gGmdpDiVhbSWji5dFu5pRrMwbr0GaDZcwmI9757pEQjtrBIfAaeSn7OuNN3AyNGEd34Dy+Yr1ludBf/bJ8bbA+XB8r0CMUIsiQ20PKllhCbLL1ZdILDcBKKGo6FkERvmyHj36A3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nQ8UIXQd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NTTWknms; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nQ8UIXQd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NTTWknms" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOMlwfd1902634 for ; Thu, 25 Dec 2025 01:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lTMsC0SwiBA2ewZQd68amFmG+DPbnH3fLn4naGygtUA=; b=nQ8UIXQdLOPvfOkL dMLeGTWT/lewL6Jow/aBm8IopbF3Y6qQ7+ncRbpw6lGPMzXAV6Tz8VNV0h8xcc3s DPdEK7gTUQlPsy03TpCh7lQXEgOjpxq3dnAVMuLKrCEo5PRlqtu1DUw6eb+Rm7hq H0197MzF3TZ2smVX+Xc3B6rgbHDfOJbYHJ0JkSGYGeXM6mQ8IQcloVSr+Vn3t874 f0yJPhODKrq5tPtAufEBuBhsZNZCfqpYqnF15WOI/J6vrKGAdTbB9mLv1Iu6dxZO n0nC0Ao+99flpPeZb0G/SjIZSoV7Tw2CFL7oVEmaLMfiuS4KruL42+mqzddoYFeN SIe0Nw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8hwe117s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Dec 2025 01:53:03 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34e5a9de94bso13477030a91.0 for ; Wed, 24 Dec 2025 17:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766627583; x=1767232383; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lTMsC0SwiBA2ewZQd68amFmG+DPbnH3fLn4naGygtUA=; b=NTTWknmsOefCDgVfU0TZZwdKhsznxeEIRAMEzz8xxrzb5Pp2xlLYWHyUZs/5YqszxU +CCAUQIQTo6B5/Rp6j2Azm8J8NkWD5/wINaQ5ulU+9tCgDobFQkfZTaOOIIb9czdE0/W nfIPNhJ3+gfubMBxKRXtXWlQBW6FuYxU/mtGxbqNn1ZS/P1ZvFC2TdYcHsQzvnXE+tJ1 Tfpya40XLx6/IY2nUFLjaC/MS2kcYJ5uhoU3lm7daMpnbwwsY/vz880/5bW3DRgoUajy gZKnFa/QDzk4BeZfgq3md0KcY5X3Gud8+9kUnzzL3RqW/EiBfOxKWM4LHmXAcwhsesSM Jkeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766627583; x=1767232383; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lTMsC0SwiBA2ewZQd68amFmG+DPbnH3fLn4naGygtUA=; b=hMXPOgh7XbxEE7+Z84zLMTF1ws500gAvZj0gyQCc8QpPd2R/7m4axnnP22s6zTkB7H Bpq1MnRykrF2BdrO/U2b41ZPXFhkR89+fiN3P8FCBSiLRKSszneO0rpbJbK2288DpmvA fwnE9cdngL+zV5wcM9bZDiSZRDwI06AS0LqkEAhZZ9HTLWtI3SodaLnw+R8Q8vvePo9v rUbgCXf0aiYIuNYR1rr7Pu9IxHtA+ZcongBwEOqCsNl2ccjLZAdOy9st7LpQknjP/a2e QDDbQ2ujpGYRkGF8XZmRQ/Kueeb1hmUKTF7g8tu5+LV6EnNzwvKaCqRFlULTZ5TrCIT7 bSZw== X-Forwarded-Encrypted: i=1; AJvYcCXbhledYIJ5agkM3WoEBVZS+pGrpl8OZ/uqs7LFod5hz+BQN5VQnd+ORyb+yO1Cadp1pW0cYLQOUUyw@vger.kernel.org X-Gm-Message-State: AOJu0Yy/QK7CcqL2rpJj76mj4AJMCZp1c28TgTnzgVFGmKONhO5+3hHT zB0aMJmsPjMe4UDB0/0I/KqDn2eCyrwNIUYtRHLeY4LzFKiF1RBAw908vr5yJcKNq912BdP3aDg 5MHEfh6o5bPWjE63RDiqTg/QY+FkjSNUPrZhjPY5WN1yJTqCE7uqv9Q5wXxukHNOs X-Gm-Gg: AY/fxX606Lc9DHtuOZ7SSei1imHuy/N3AyAzYfcSOJ2Ek6yoLQGLXRTltbBsqbmjYjA eSjyixXh3J7qv9SUi/+iW03UqfNjX6Jb0c3DHGwhU59b8OjqTPC95+ocEQ6qt/mjvpEVgw1+CM8 DSUyThFpam4uonY6ks+Bgm1rkGqjqroBTV3UKC9HayTAp1q4lHirfpmV5QAfl+c2HxNqAEn7lMk xj6R9WblCUeyfS6P7hy4HEdepQvVgERigdnsTCdDF/BslDtKx4NyR6mNnhxZXOaEOuxxWGuV/Et cHVfjpLKA1aBIigOaC8Kk/0y2S7Pm1tK5Dx352F2EKRMsaWJIlxMKZ3DG7vPDaDP8yZKj8aULT6 B9/oOSRV2KYPM8Azf01pwrdF1mVvIbWXkOqRVNjfIC6Y7I6eYACn6pCC4sy+NtNtCyzuHrUB/wm S613oz X-Received: by 2002:a05:6a20:a106:b0:366:14ac:e1dc with SMTP id adf61e73a8af0-376aaff535emr19179078637.66.1766627582516; Wed, 24 Dec 2025 17:53:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwMzT+yv8Q66avLJb03Vpq86z2JpTm3Ixh1dMTBijThR4XbZSKrYCUMtG0ZhnW2FELgxsvgw== X-Received: by 2002:a05:6a20:a106:b0:366:14ac:e1dc with SMTP id adf61e73a8af0-376aaff535emr19179051637.66.1766627581933; Wed, 24 Dec 2025 17:53:01 -0800 (PST) Received: from [10.133.33.10] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7a018eb5sm16400281a12.16.2025.12.24.17.52.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 17:53:01 -0800 (PST) Message-ID: Date: Thu, 25 Dec 2025 09:52:43 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/7] Provide support for Trigger Generation Unit To: andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI1MDAxNSBTYWx0ZWRfX3TLoDMWKBv7d jEPJ56tnOaQE9ErgfWh4MINSDBX1SrjfckOi03+/X2fx+htUvy8eCWIQZZ9T7qDPtJ7ILNnT820 fdH2aTNurPHkIYI2Qk4dKX88s67PiVq3I4wtKf3roHP7a1k4v7XB8eSJTbMdV7LrcK13j3UQQqJ RTfbJnmWJusQyA6EeuZ7ylVu1nZ69EJo+SKRyrW0/7khJ7MKsOmK0n+IUtF+P50tZUU2JRfjBsd 7QjLGX6+V4T5Je6CPiDyYJH4I1/iWzsHYZos942DVOjJIo6+0eyPYthCjRFF1Lux2pEmAvnyk5j m22gwaEvkCITTqJZ+2VMNlTg38/pIJgHej+1s2YeevsUdzVY4SVL7F3u1wSSCHDoQ5ZMNbIhy5F JdanDJTl5868ra9go879fDHuRd39gXu5y6eGYuxjgSm5n0P2HjwimsZS0ZTq5jIuFQDzjkUBKnY NcJEFHMC3+vpQ9e4zrg== X-Proofpoint-GUID: MF4K0iStk1srynIPDSxtMFJ9eOUZiSL0 X-Proofpoint-ORIG-GUID: MF4K0iStk1srynIPDSxtMFJ9eOUZiSL0 X-Authority-Analysis: v=2.4 cv=P9c3RyAu c=1 sm=1 tr=0 ts=694c98ff cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=fhqOlET_MB95s3sYkCsA:9 a=Xy4DMoyCCsA-7icV:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_04,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512250015 Gentle Reminder. On 12/19/2025 2:58 PM, Songwei Chai wrote: > We propose creating a new qcom directory under drivers/hwtracing > to host this TGU driver, as well as additional Qualcomm-specific > hwtracing drivers that we plan to submit in the coming months. > This structure will help organize vendor-specific implementations > and facilitate future development and maintenance. > > Feedback from the community on this proposal is highly appreciated. > > - Why we are proposing this: > > TGU has the ability to monitor signal conditions and trigger debug-related > actions, serving as a programmable hardware component that enhances system > trace and debug capabilities. Placing it under drivers/hwtracing aligns with > its function as a trace generation utility. > > We previously attempted to push this driver to drivers/hwtracing/coresight, > but did not receive support from the maintainers of the CoreSight subsystem. > The reason provided was: “This component is primarily a part of the > Qualcomm proprietary QPMDA subsystem, and is capable of operating > independently from the CoreSight hardware trace generation system.” > > Chat history : https://lore.kernel.org/all/CAJ9a7ViKxHThyZfFFDV_FkNRimk4uo1NrMtQ-kcaj1qO4ZcGnA@mail.gmail.com/ > > Given this, we have been considering whether it would be appropriate > to create a dedicated drivers/hwtracing/qcom directory for > Qualcomm-related hwtracing drivers. This would follow the precedent set > by Intel, which maintains its own directory at drivers/hwtracing/intel_th. > We believe this structure would significantly facilitate > future submissions of related Qualcomm drivers. > > - Maintenance of drivers/hwtracing/qcom: > > Bjorn, who maintains linux-arm-msm, will be the maintainer of this > directory — we’ve discussed this with him and he’s aware that his task > list may grow accordingly. Additionally, Qualcomm engineers familiar with > the debug hardware — such as [Tingwei Zhang, Jinlong Mao, Songwei Chai], > will be available to review incoming patches and support ongoing > development. > > - Detail for TGU: > > This component can be utilized to sense a plurality of signals and > create a trigger into the CTI or generate interrupts to processors > once the input signal meets the conditions. We can treat the TGU’s > workflow as a flowsheet, it has some “steps” regions for customization. > In each step region, we can set the signals that we want with priority > in priority_group, set the conditions in each step via condition_decode, > and set the resultant action by condition_select. Meanwhile, > some TGUs (not all) also provide timer/counter functionality. > Based on the characteristics described above, we consider the TGU as a > helper in the CoreSight subsystem. Its master device is the TPDM, which > can transmit signals from other subsystems, and we reuse the existing > ports mechanism to link the TPDM to the connected TGU. > > Here is a detailed example to explain how to use the TGU: > > In this example, the TGU is configured to use 2 conditions, 2 steps, and > the timer. The goal is to look for one of two patterns which are generated > from TPDM, giving priority to one, and then generate a trigger once the > timer reaches a certain value. In other words, two conditions are used > for the first step to look for the two patterns, where the one with the > highest priority is used in the first condition. Then, in the second step, > the timer is enabled and set to be compared to the given value at each > clock cycle. These steps are better shown below. > > |-----------------| > | | > | TPDM | > | | > |-----------------| > | > | > --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- ------ > | | | > | | |--------------------| | > | |---- ---> | | Go to next steps | | > | | | |--- ---> | Enable timer | | > | | v | | | | > | | |-----------------| | |--------------------| | > | | | | Yes | | | > | | | inputs==0xB | ----->| | <-------- | > | | | | | | No | | > | No | |-----------------| | v | | > | | | | |-----------------| | | > | | | | | | | | > | | | | | timer>=3 |-- | > | | v | | | | > | | |-----------------| | |-----------------| | > | | | | Yes | | | > | |--- | inputs==0xA | ----->| | Yes | > | | | | | > | |-----------------| v | > | |-----------------| | > | | | | > | | Trigger | | > | | | | > | |-----------------| | > | TGU | | > |--- --- --- --- --- --- --- --- --- --- --- --- --- --- |--- --- -- | > | > v > |-----------------| > |The controllers | > |which will use | > |triggers further | > |-----------------| > > steps: > 1. Reset TGU /*it will disable tgu and reset dataset*/ > - echo 1 > /sys/bus/amba/devices//reset_tgu > > 2. Set the pattern match for priority0 to 0xA = 0b1010 and for > priority 1 to 0xB = 0b1011. > - echo 0x11113232 > /sys/bus/amba/devices//step0_priority0/reg0 > - echo 0x11113233 > /sys/bus/amba/devices//step0_priority1/reg0 > > Note: > Bit distribution diagram for each priority register > |-------------------------------------------------------------------| > | Bits | Field Nam | Description | > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 29:28 | SEL_BIT7_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 25:24 | SEL_BIT6_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 21:20 | SEL_BIT5_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 17:16 | SEL_BIT4_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 13:12 | SEL_BIT3_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 9:8 | SEL_BIT2_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 5:4 | SEL_BIT1_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > | | | 00 = bypass for OR output | > | 1:0 | SEL_BIT0_TYPE2 | 01 = bypass for AND output | > | | | 10 = sense input '0' is true| > | | | 11 = sense input '1' is true| > |-------------------------------------------------------------------| > These bits are used to identify the signals we want to sense, with > a maximum signal number of 140. For example, to sense the signal > 0xA (binary 1010), we set the value of bits 0 to 13 to 3232, which > represents 1010. The remaining bits are set to 1, as we want to use > AND gate to summarize all the signals we want to sense here. For > rising or falling edge detection of any input to the priority, set > the remaining bits to 0 to use an OR gate. > > 3. look for the pattern for priority_i i=0,1. > - echo 0x3 > /sys/bus/amba/devices//step0_condition_decode/reg0 > - echo 0x30 > /sys/bus/amba/devices//step0_condition_decode/reg1 > > |-------------------------------------------------------------------------------| > | Bits | Field Nam | Description | > |-------------------------------------------------------------------------------| > | | |For each decoded condition, this | > | 24 | NOT |inverts the output. If the condition | > | | |decodes to true, and the NOT field | > | | |is '1', then the output is NOT true. | > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | 21 | BC0_COMP_ACTIVE |comparator will be actively included in| > | | |the decoding of this particular | > | | |condition. | > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | | |comparator will need to be 1 to affect | > | 20 | BC0_COMP_HIGH |the decoding of this condition. | > | | |Conversely, a '0' here requires a '0' | > | | |from the comparator | > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | 17 | |comparator will be actively included in| > | | TC0_COMP_ACTIVE |the decoding of this particular | > | | |condition. | > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | | |comparator will need to be 1 to affect | > | 16 | TC0_COMP_HIGH |the decoding of this particular | > | | |condition.Conversely, a 0 here | > | | |requires a '0' from the comparator | > |-------------------------------------------------------------------------------| > | | |When '1' the output from Priority_n | > | | |OR logic will be actively | > | 4n+3 | Priority_n_OR_ACTIVE|included in the decoding of | > | | (n=0,1,2,3) |this particular condition. | > | | | | > |-------------------------------------------------------------------------------| > | | |When '1' the output from Priority_n | > | | |will need to be '1' to affect the | > | 4n+2 | Priority_n_OR_HIGH |decoding of this particular | > | | (n=0,1,2,3) |condition. Conversely, a '0' here | > | | |requires a '0' from Priority_n OR logic| > |-------------------------------------------------------------------------------| > | | |When '1' the output from Priority_n | > | | |AND logic will be actively | > | 4n+1 |Priority_n_AND_ACTIVE|included in the decoding of this | > | | (n=0,1,2,3) |particular condition. | > | | | | > |-------------------------------------------------------------------------------| > | | |When '1' the output from Priority_n | > | | |AND logic will need to be '1' to | > | 4n | Priority_n_AND_HIGH |affect the decoding of this | > | | (n=0,1,2,3) |particular condition. Conversely, | > | | |a '0' here requires a '0' from | > | | |Priority_n AND logic. | > |-------------------------------------------------------------------------------| > Since we use `priority_0` and `priority_1` with an AND output in step 2, we set `0x3` > and `0x30` here to activate them. > > 4. Set NEXT_STEP = 1 and TC0_ENABLE = 1 so that when the conditions > are met then the next step will be step 1 and the timer will be enabled. > - echo 0x20008 > /sys/bus/amba/devices//step0_condition_select/reg0 > - echo 0x20008 > /sys/bus/amba/devices//step0_condition_select/reg1 > > |-----------------------------------------------------------------------------| > | Bits | Field Nam | Description | > |-----------------------------------------------------------------------------| > | | |This field defines the next step the | > | 18:17 | NEXT_STEP |TGU will 'goto' for the associated | > | | |Condition and Step. | > |-----------------------------------------------------------------------------| > | | |For each possible output trigger | > | 13 | TRIGGER |available, set a '1' if you want | > | | |the trigger to go active for the | > | | |associated condition and Step. | > |-----------------------------------------------------------------------------| > | | |This will cause BC0 to increment if the| > | 9 | BC0_INC |associated Condition is decoded for | > | | |this step. | > |-----------------------------------------------------------------------------| > | | |This will cause BC0 to decrement if the| > | 8 | BC0_DEC |associated Condition is decoded for | > | | |this step. | > |-----------------------------------------------------------------------------| > | | |This will clear BC0 count value to 0 if| > | 7 | BC0_CLEAR |the associated Condition is decoded | > | | |for this step. | > |-----------------------------------------------------------------------------| > | | |This will cause TC0 to increment until | > | 3 | TC0_ENABLE |paused or cleared if the associated | > | | |Condition is decoded for this step. | > |-----------------------------------------------------------------------------| > | | |This will cause TC0 to pause until | > | 2 | TC0_PAUSE |enabled if the associated Condition | > | | |is decoded for this step. | > |-----------------------------------------------------------------------------| > | | |This will clear TC0 count value to 0 | > | 1 | TC0_CLEAR |if the associated Condition is | > | | |decoded for this step. | > |-----------------------------------------------------------------------------| > | | |This will set the done signal to the | > | 0 | DONE |TGU FSM if the associated Condition | > | | |is decoded for this step. | > |-----------------------------------------------------------------------------| > Based on the distribution diagram, we set `0x20008` for `priority0` and `priority1` to > achieve "jump to step 1 and enable TC0" once the signal is sensed. > > 5. activate the timer comparison for this step. > - echo 0x30000 > /sys/bus/amba/devices//step1_condition_decode/reg0 > > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | 17 | |comparator will be actively included in| > | | TC0_COMP_ACTIVE |the decoding of this particular | > | | |condition. | > |-------------------------------------------------------------------------------| > | | |When '1' the output from the associated| > | | |comparator will need to be 1 to affect | > | 16 | TC0_COMP_HIGH |the decoding of this particular | > | | |condition.Conversely, a 0 here | > | | |requires a '0' from the comparator | > |-------------------------------------------------------------------------------| > Accroding to the decode distribution diagram , we give 0x30000 here to set 16th&17th bit > to enable timer comparison. > > 6. Set the NEXT_STEP = 0 and TC0_PAUSE = 1 and TC0_CLEAR = 1 once the timer > has reached the given value. > - echo 0x6 > /sys/bus/amba/devices//step1_condition_select/reg0 > > 7. Enable Trigger 0 for TGU when the condition 0 is met in step1, > i.e. when the timer reaches 3. > - echo 0x2000 > /sys/bus/amba/devices//step1_condition_select/default > > Note: > 1. 'default' register allows for establishing the resultant action for > the default condition > > 2. Trigger:For each possible output trigger available from > the Design document, there are three triggers: interrupts, CTI, > and Cross-TGU mapping.All three triggers can occur, but > the choice of which trigger to use depends on the user's > needs. > > 8. Compare the timer to 3 in step 1. > - echo 0x3 > /sys/bus/amba/devices//step1_timer/reg0 > > 9. enale tgu > - echo 1 > /sys/bus/amba/devices//enable_tgu > --- > Link to V8: https://lore.kernel.org/all/20251203090055.2432719-1-songwei.chai@oss.qualcomm.com/ > > Changes in V9: > - Decoupled the tgu driver from coresight header file and registered it as an amba device. > - Retained Rob's reviewed-by tag on patch1/7 since the file remains unchanged. > - Updated the sysfs node path in the Documentation directory. > --- > Link to V7: https://lore.kernel.org/all/20251104064043.88972-1-songwei.chai@oss.qualcomm.com/ > > Changes in V8: > - Add "select" section in bindings. > - Update publish date in "sysfs-bus-coresight-devices-tgu". > --- > Link to V6: https://lore.kernel.org/all/20250709104114.22240-1-songchai@qti.qualcomm.com/ > > Changes in V7: > - Move the TGU code location from 'drivers/hwtracing/coresight/' to 'drivers/hwtracing/qcom/'. > - Rename the spinlock used in the code from 'spinlock' to 'lock'. > - Perform the 'calculate_array_location' separately, instead of doing it within the function. > - Update the sender email address. > --- > Link to V5: https://lore.kernel.org/all/20250529081949.26493-1-quic_songchai@quicinc.com/ > > Changes in V6: > - Replace spinlock with guard(spinlock) in tgu_enable. > - Remove redundant blank line. > - Update publish date and contact member's name in "sysfs-bus-coresight-devices-tgu". > --- > Link to V4: https://patchwork.kernel.org/project/linux-arm-msm/cover/20250423101054.954066-1-quic_songchai@quicinc.com/ > > Changes in V5: > - Update publish date and kernel_version in "sysfs-bus-coresight-devices-tgu" > --- > Link to V3: https://lore.kernel.org/all/20250227092640.2666894-1-quic_songchai@quicinc.com/ > > Changes in V4: > - Add changlog in coverletter. > - Correct 'year' in Copyright in patch1. > - Correct port mechansim description in patch1. > - Remove 'tgu-steps','tgu-regs','tgu-conditions','tgu-timer-counters' from dt-binding > and set them through reading DEVID register as per Mike's suggestion. > - Modify tgu_disable func to make it have single return point in patch2 as per > Mike's suggestion. > - Use sysfs_emit in enable_tgu_show func in ptach2. > - Remove redundant judgement in enable_tgu_store in patch2. > - Correct typo in description in patch3. > - Set default ret as SYSFS_GROUP_INVISIBLE, and returnret at end in pacth3 as > per Mike's suggestion. > - Remove tgu_dataset_ro definition in patch3 > - Use #define constants with explanations of what they are rather than > arbitrary magic numbers in patch3 and patch4. > - Check -EINVAL before using 'calculate_array_location()' in array in patch4. > - Add 'default' in 'tgu_dataset_show''s switch part in patch4. > - Document the value needed to initiate the reset in pacth7. > - Check "value" in 'reset_tgu_store' and bail out with an error code if 0 in patch7. > - Remove dev_dbg in 'reset_tgu_store' in patch7. > --- > Link to V2: https://lore.kernel.org/all/20241010073917.16023-1-quic_songchai@quicinc.com/ > > Changes in V3: > - Correct typo and format in dt-binding in patch1 > - Rebase to the latest kernel version > --- > Link to V1: https://lore.kernel.org/all/20240830092311.14400-1-quic_songchai@quicinc.com/ > > Changes in V2: > - Use real name instead of login name, > - Correct typo and format in dt-binding and code. > - Bring order in tgu_prob(declarations with and without assignments) as per > Krzysztof's suggestion. > - Add module device table in patch2. > - Set const for tgu_common_grp and tgu_ids in patch2. > - Initialize 'data' in tgu_ids to fix the warning in pacth2. > --- > > Songwei Chai (7): > dt-bindings: arm: Add support for Qualcomm TGU trace > qcom-tgu: Add TGU driver > qcom-tgu: Add signal priority support > qcom-tgu: Add TGU decode support > qcom-tgu: Add support to configure next action > qcom-tgu: Add timer/counter functionality for TGU > qcom-tgu: Add reset node to initialize > > .../ABI/testing/sysfs-bus-amba-devices-tgu | 51 ++ > .../devicetree/bindings/arm/qcom,tgu.yaml | 92 +++ > drivers/Makefile | 1 + > drivers/hwtracing/Kconfig | 2 + > drivers/hwtracing/qcom/Kconfig | 18 + > drivers/hwtracing/qcom/Makefile | 3 + > drivers/hwtracing/qcom/tgu.c | 702 ++++++++++++++++++ > drivers/hwtracing/qcom/tgu.h | 272 +++++++ > 8 files changed, 1141 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > create mode 100644 Documentation/devicetree/bindings/arm/qcom,tgu.yaml > create mode 100644 drivers/hwtracing/qcom/Kconfig > create mode 100644 drivers/hwtracing/qcom/Makefile > create mode 100644 drivers/hwtracing/qcom/tgu.c > create mode 100644 drivers/hwtracing/qcom/tgu.h >