From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Ford <aford173@gmail.com>, linux-omap@vger.kernel.org
Cc: aford@beaconembedded.com,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Derald D. Woods" <woods.technical@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: dts: am3517-evm: Enable Ethernet PHY Interrupt
Date: Thu, 7 Sep 2023 08:11:58 +0200 [thread overview]
Message-ID: <cb1eb99d-5fb6-d11e-1685-3e36b12ad65d@linaro.org> (raw)
In-Reply-To: <20230907010159.330555-2-aford173@gmail.com>
On 07/09/2023 03:01, Adam Ford wrote:
> The Ethernet PHY interrupt pin is routed to GPIO_58. Create a
> PHY node to configure this GPIO for the interrupt to avoid polling.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/boot/dts/ti/omap/am3517-evm.dts b/arch/arm/boot/dts/ti/omap/am3517-evm.dts
> index 738189ddc8d5..19869ef906a8 100644
> --- a/arch/arm/boot/dts/ti/omap/am3517-evm.dts
> +++ b/arch/arm/boot/dts/ti/omap/am3517-evm.dts
> @@ -172,11 +172,24 @@ hsusb1_phy: hsusb1_phy {
> &davinci_emac {
> pinctrl-names = "default";
> pinctrl-0 = <ðernet_pins>;
> + phy-mode = "rmii";
> + phy-handle = <ðphy0>;
> status = "okay";
> };
>
> &davinci_mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> status = "okay";
> +
> + ethphy0: ethernet-phy@0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&enet_phy_pins>;
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; /* gpio_58 */
> + };
> };
>
> &dss {
> @@ -257,6 +270,12 @@ OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50mhz_clk */
> >;
> };
>
> + enet_phy_pins: pinmux_ent_phy_pins {
Nope. This looks like pasted from some old downstream tree. Please
rewrite downstream code to match upstream.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-07 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 1:01 [PATCH 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux Adam Ford
2023-09-07 1:01 ` [PATCH 2/2] arm: dts: am3517-evm: Enable Ethernet PHY Interrupt Adam Ford
2023-09-07 6:11 ` Krzysztof Kozlowski [this message]
2023-09-07 6:11 ` [PATCH 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux Krzysztof Kozlowski
2023-09-07 6:49 ` Tony Lindgren
2023-09-07 13:06 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb1eb99d-5fb6-d11e-1685-3e36b12ad65d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=woods.technical@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).