From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2494FEC8740 for ; Thu, 7 Sep 2023 15:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234651AbjIGPqy (ORCPT ); Thu, 7 Sep 2023 11:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344295AbjIGPcv (ORCPT ); Thu, 7 Sep 2023 11:32:51 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D485D19C for ; Thu, 7 Sep 2023 08:32:31 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-31c73c21113so1020741f8f.1 for ; Thu, 07 Sep 2023 08:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694100704; x=1694705504; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yT+j2pGsqz6g/7hkqeJl2HC5ajkztNJE87gRZrJmIGQ=; b=ZR2aut/wAJVoEYlHkVZ4kSxR1i3ZhuXha+KOsWLPdvIrMj+go8BETJBnCZQ5h4BGQq c76u+/3U/SrXY499o5BF8UXWbzhW6VOXDcPDwciZVMqBxMa1abEYoiYnCwbUPRgtRPDY LiXlIbE9uvg21bejyhGMFQZQfEqgwQm3X8sZKhwOQBHCLP3MfQXmjJ0KVT9vn2qIkUFg nLEpsxlx4BhKPJbwHQR59Zd43zAH+z/AtlCB7GSLPA7xtqnS0hFi6wP45z7HnRlxaAwT Nv7vW7qdZlFVWosVLpIcxjb+/abcrYxmgoesDtXNsbWcKGT1bzBrMviziDEOYpy/LI9E 3wPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694100704; x=1694705504; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yT+j2pGsqz6g/7hkqeJl2HC5ajkztNJE87gRZrJmIGQ=; b=jp/90HW/LL4Knvi+OLMz+zfldiJe/vPRQlzjCyOWmDF/mhCe06jvlAanslSaJf5O9x 1fc1LxlPWkoRfQ99kvo4TorMW9o6FdeLAyjFplZWuNdzLzZJypDju7sK0PBxugj039Wa 6Ea5XhDT7zEXbuVZLVHVW2rrhyoR8PZcQ4SpagaPwoa9MMrhJu4pRNvy8OPpmVLURDbQ ojqtvi9O2zfsa0zFT4pSrCvg+MrP8Ligy4s5Ugz6yYyYdbbLOp/gDZRx+pUtzDZWyPQ/ glptx7hfVi5MbgmRxQTW+pLPRwYS4oufcF63kSAlqf24aQ22z96o9okpiBKQi/B5CVe3 CHpg== X-Gm-Message-State: AOJu0YzixwvuxRa+EAhsuebD3Jn5+150fnnYYKe/E+dkm2F5HSaiSpTq 7bdhYmZyltC9LJ0VVFzRw3ZrnkldmXXH6PWK4c8= X-Google-Smtp-Source: AGHT+IGQFxHleCdB34IoNTOM/evfr23cCD6pBdZ/p+K+Fe4b+zXNzBASrpLUen6AG1Mok15vrJ6+qQ== X-Received: by 2002:aa7:df81:0:b0:523:2e0e:5462 with SMTP id b1-20020aa7df81000000b005232e0e5462mr3180834edy.42.1694067120706; Wed, 06 Sep 2023 23:12:00 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id a9-20020aa7d749000000b005257da6be23sm9413857eds.75.2023.09.06.23.11.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 23:12:00 -0700 (PDT) Message-ID: Date: Thu, 7 Sep 2023 08:11:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] arm: dts: am3517-evm: Enable Ethernet PHY Interrupt Content-Language: en-US To: Adam Ford , linux-omap@vger.kernel.org Cc: aford@beaconembedded.com, =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Derald D. Woods" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230907010159.330555-1-aford173@gmail.com> <20230907010159.330555-2-aford173@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230907010159.330555-2-aford173@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/09/2023 03:01, Adam Ford wrote: > The Ethernet PHY interrupt pin is routed to GPIO_58. Create a > PHY node to configure this GPIO for the interrupt to avoid polling. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/boot/dts/ti/omap/am3517-evm.dts b/arch/arm/boot/dts/ti/omap/am3517-evm.dts > index 738189ddc8d5..19869ef906a8 100644 > --- a/arch/arm/boot/dts/ti/omap/am3517-evm.dts > +++ b/arch/arm/boot/dts/ti/omap/am3517-evm.dts > @@ -172,11 +172,24 @@ hsusb1_phy: hsusb1_phy { > &davinci_emac { > pinctrl-names = "default"; > pinctrl-0 = <ðernet_pins>; > + phy-mode = "rmii"; > + phy-handle = <ðphy0>; > status = "okay"; > }; > > &davinci_mdio { > + #address-cells = <1>; > + #size-cells = <0>; > status = "okay"; > + > + ethphy0: ethernet-phy@0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&enet_phy_pins>; > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + interrupt-parent = <&gpio2>; > + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; /* gpio_58 */ > + }; > }; > > &dss { > @@ -257,6 +270,12 @@ OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50mhz_clk */ > >; > }; > > + enet_phy_pins: pinmux_ent_phy_pins { Nope. This looks like pasted from some old downstream tree. Please rewrite downstream code to match upstream. Best regards, Krzysztof