devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2
@ 2025-07-03 11:38 Adam Ford
  2025-07-03 11:38 ` [PATCH V2 2/2] arm64: dts: imx8mn: " Adam Ford
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Adam Ford @ 2025-07-03 11:38 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: aford, Adam Ford, Fabio Estevam, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	devicetree, imx, linux-kernel

UART2 is often used as the console, so the DMA was likely left
off on purpose, since it's recommended to not use the DMA on the
console. Because, the driver checks to see if the UART is used for
the console when determining if it should initialize DMA, it
should be safe to enable DMA on UART2 for all users.

Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
V2:  Fix spelling errors in commit message

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index cfebaa01217e..ded89b046970 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -915,6 +915,8 @@ uart2: serial@30890000 {
 					clocks = <&clk IMX8MM_CLK_UART2_ROOT>,
 						 <&clk IMX8MM_CLK_UART2_ROOT>;
 					clock-names = "ipg", "per";
+					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
+					dma-names = "rx", "tx";
 					status = "disabled";
 				};
 			};
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V2 2/2] arm64: dts: imx8mn: Configure DMA on UART2
  2025-07-03 11:38 [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
@ 2025-07-03 11:38 ` Adam Ford
  2025-07-03 12:15   ` Ahmad Fatoum
  2025-07-03 12:15 ` [PATCH V2 1/2] arm64: dts: imx8mm: " Ahmad Fatoum
  2025-07-07  8:59 ` Shawn Guo
  2 siblings, 1 reply; 5+ messages in thread
From: Adam Ford @ 2025-07-03 11:38 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	devicetree, imx, linux-kernel

UART2 is often used as the console, so the DMA was likely left
off on purpose, since it's recommended to not use the DMA on the
console. Because, the driver checks to see if the UART is used for
the console when determining if it should initialize DMA, it
should be safe to enable DMA on UART2 for all users.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:  Fix spelling errors in commit message

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 848ba5e46ee6..b98b3d0ddf25 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -860,6 +860,8 @@ uart2: serial@30890000 {
 					clocks = <&clk IMX8MN_CLK_UART2_ROOT>,
 						 <&clk IMX8MN_CLK_UART2_ROOT>;
 					clock-names = "ipg", "per";
+					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
+					dma-names = "rx", "tx";
 					status = "disabled";
 				};
 			};
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2
  2025-07-03 11:38 [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
  2025-07-03 11:38 ` [PATCH V2 2/2] arm64: dts: imx8mn: " Adam Ford
@ 2025-07-03 12:15 ` Ahmad Fatoum
  2025-07-07  8:59 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2025-07-03 12:15 UTC (permalink / raw)
  To: Adam Ford, linux-arm-kernel
  Cc: Rob Herring, Conor Dooley, devicetree, Sascha Hauer, aford,
	linux-kernel, imx, Pengutronix Kernel Team, Shawn Guo,
	Krzysztof Kozlowski, Fabio Estevam

On 7/3/25 13:38, Adam Ford wrote:
> UART2 is often used as the console, so the DMA was likely left
> off on purpose, since it's recommended to not use the DMA on the
> console. Because, the driver checks to see if the UART is used for
> the console when determining if it should initialize DMA, it
> should be safe to enable DMA on UART2 for all users.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
> V2:  Fix spelling errors in commit message
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index cfebaa01217e..ded89b046970 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -915,6 +915,8 @@ uart2: serial@30890000 {
>  					clocks = <&clk IMX8MM_CLK_UART2_ROOT>,
>  						 <&clk IMX8MM_CLK_UART2_ROOT>;
>  					clock-names = "ipg", "per";
> +					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> +					dma-names = "rx", "tx";
>  					status = "disabled";
>  				};
>  			};

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 2/2] arm64: dts: imx8mn: Configure DMA on UART2
  2025-07-03 11:38 ` [PATCH V2 2/2] arm64: dts: imx8mn: " Adam Ford
@ 2025-07-03 12:15   ` Ahmad Fatoum
  0 siblings, 0 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2025-07-03 12:15 UTC (permalink / raw)
  To: Adam Ford, linux-arm-kernel
  Cc: Rob Herring, Conor Dooley, Fabio Estevam, devicetree, Shawn Guo,
	Sascha Hauer, aford, linux-kernel, imx, Pengutronix Kernel Team,
	Krzysztof Kozlowski

On 7/3/25 13:38, Adam Ford wrote:
> UART2 is often used as the console, so the DMA was likely left
> off on purpose, since it's recommended to not use the DMA on the
> console. Because, the driver checks to see if the UART is used for
> the console when determining if it should initialize DMA, it
> should be safe to enable DMA on UART2 for all users.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
> V2:  Fix spelling errors in commit message
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 848ba5e46ee6..b98b3d0ddf25 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -860,6 +860,8 @@ uart2: serial@30890000 {
>  					clocks = <&clk IMX8MN_CLK_UART2_ROOT>,
>  						 <&clk IMX8MN_CLK_UART2_ROOT>;
>  					clock-names = "ipg", "per";
> +					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> +					dma-names = "rx", "tx";
>  					status = "disabled";
>  				};
>  			};

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2
  2025-07-03 11:38 [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
  2025-07-03 11:38 ` [PATCH V2 2/2] arm64: dts: imx8mn: " Adam Ford
  2025-07-03 12:15 ` [PATCH V2 1/2] arm64: dts: imx8mm: " Ahmad Fatoum
@ 2025-07-07  8:59 ` Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2025-07-07  8:59 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-arm-kernel, aford, Fabio Estevam, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, devicetree, imx, linux-kernel

On Thu, Jul 03, 2025 at 06:38:09AM -0500, Adam Ford wrote:
> UART2 is often used as the console, so the DMA was likely left
> off on purpose, since it's recommended to not use the DMA on the
> console. Because, the driver checks to see if the UART is used for
> the console when determining if it should initialize DMA, it
> should be safe to enable DMA on UART2 for all users.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Applied both, thanks!


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-07-07  9:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-03 11:38 [PATCH V2 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
2025-07-03 11:38 ` [PATCH V2 2/2] arm64: dts: imx8mn: " Adam Ford
2025-07-03 12:15   ` Ahmad Fatoum
2025-07-03 12:15 ` [PATCH V2 1/2] arm64: dts: imx8mm: " Ahmad Fatoum
2025-07-07  8:59 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).