* [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 @ 2025-06-12 18:50 Dan Carpenter 2025-06-12 18:50 ` [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Ghennadi Procopciuc 2025-06-13 14:50 ` [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Frank Li 0 siblings, 2 replies; 5+ messages in thread From: Dan Carpenter @ 2025-06-12 18:50 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Conor Dooley, devicetree, Fabio Estevam, imx, Krzysztof Kozlowski, linux-arm-kernel, linux-kernel, linux-usb, Peng Fan, Pengutronix Kernel Team, Peter Chen, Rob Herring, Sascha Hauer, Shawn Guo, Xu Yang, s32, linaro-s32, Larisa Grigore, Ionut Vicovan, Ghennadi Procopciuc This patchset adds support for the s32g2 and s32g3 chips. The changes since v1: * Put the device tree lines in alphabetical order. * Add imx@lists.linux.dev to the CC list. * Use power_lost_check() instead of creating a new REINIT_DURING_RESUME flag. * Change the Copyright date. * Leave the .compatible = "nxp,s32g3-usb" out of the ci_hdrc_imx.c driver because people can just specify both in the devicetree since they are compatible. Ghennadi Procopciuc (3): dt-bindings: usb: Add compatible strings for s32g2/s32g3 usb: chipidea: s32g: Add usb support for s32g2 usb: chipidea: s32g: Add usb support for s32g3 .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 + .../devicetree/bindings/usb/fsl,usbmisc.yaml | 2 + drivers/usb/chipidea/ci_hdrc_imx.c | 6 ++ drivers/usb/chipidea/usbmisc_imx.c | 89 +++++++++++++++++++ 4 files changed, 99 insertions(+) -- 2.47.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 2025-06-12 18:50 [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Dan Carpenter @ 2025-06-12 18:50 ` Ghennadi Procopciuc 2025-06-13 14:47 ` Conor Dooley 2025-06-13 14:49 ` Frank Li 2025-06-13 14:50 ` [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Frank Li 1 sibling, 2 replies; 5+ messages in thread From: Ghennadi Procopciuc @ 2025-06-12 18:50 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xu Yang, Peng Fan, linux-usb, devicetree, linux-kernel, imx, s32, linaro-s32, Larisa Grigore, Ionut Vicovan, Ghennadi Procopciuc From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> Add the compatible strings for the NXP s32g2 and s32g3. These chips are mostly compatible. The one difference is that the s32g2-usbmisc device has an errata ERR050474 which requires a special flag to be set for handling packages that aren't 4 byte aligned. Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- Changes since v1: 1: Alphabetize 2: Update the commit message a bit. Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++ Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index cc5787a8cfa3..f6372b76ed5a 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -23,6 +23,8 @@ properties: - nvidia,tegra30-udc - nvidia,tegra114-udc - nvidia,tegra124-udc + - nxp,s32g2-usb + - nxp,s32g3-usb - qcom,ci-hdrc - items: - enum: diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml index 019435540df0..ca677d1a8274 100644 --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml @@ -21,6 +21,8 @@ properties: - fsl,imx53-usbmisc - fsl,imx6q-usbmisc - fsl,vf610-usbmisc + - nxp,s32g2-usbmisc + - nxp,s32g3-usbmisc - items: - enum: - fsl,imx6ul-usbmisc -- 2.47.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 2025-06-12 18:50 ` [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Ghennadi Procopciuc @ 2025-06-13 14:47 ` Conor Dooley 2025-06-13 14:49 ` Frank Li 1 sibling, 0 replies; 5+ messages in thread From: Conor Dooley @ 2025-06-13 14:47 UTC (permalink / raw) To: Ghennadi Procopciuc Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xu Yang, Peng Fan, linux-usb, devicetree, linux-kernel, imx, s32, linaro-s32, Larisa Grigore, Ionut Vicovan, Ghennadi Procopciuc [-- Attachment #1: Type: text/plain, Size: 2349 bytes --] On Thu, Jun 12, 2025 at 09:50:51PM +0300, Ghennadi Procopciuc wrote: > From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > Add the compatible strings for the NXP s32g2 and s32g3. These chips > are mostly compatible. The one difference is that the s32g2-usbmisc > device has an errata ERR050474 which requires a special flag to be set > for handling packages that aren't 4 byte aligned. > > Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> This signoff chain is absolutely wrong, what were the contributions of Larisa, Ionut or Dan to this patch? If they were co-authors (surely not 4 people for a trivial 4 line diff) they need co-developed-by tags. You sent it, so your name should be last. > --- > Changes since v1: > 1: Alphabetize > 2: Update the commit message a bit. > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++ > Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index cc5787a8cfa3..f6372b76ed5a 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -23,6 +23,8 @@ properties: > - nvidia,tegra30-udc > - nvidia,tegra114-udc > - nvidia,tegra124-udc > + - nxp,s32g2-usb > + - nxp,s32g3-usb > - qcom,ci-hdrc > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > index 019435540df0..ca677d1a8274 100644 > --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -21,6 +21,8 @@ properties: > - fsl,imx53-usbmisc > - fsl,imx6q-usbmisc > - fsl,vf610-usbmisc > + - nxp,s32g2-usbmisc > + - nxp,s32g3-usbmisc > - items: > - enum: > - fsl,imx6ul-usbmisc > -- > 2.47.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 2025-06-12 18:50 ` [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Ghennadi Procopciuc 2025-06-13 14:47 ` Conor Dooley @ 2025-06-13 14:49 ` Frank Li 1 sibling, 0 replies; 5+ messages in thread From: Frank Li @ 2025-06-13 14:49 UTC (permalink / raw) To: Ghennadi Procopciuc Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xu Yang, Peng Fan, linux-usb, devicetree, linux-kernel, imx, s32, linaro-s32, Larisa Grigore, Ionut Vicovan, Ghennadi Procopciuc On Thu, Jun 12, 2025 at 09:50:51PM +0300, Ghennadi Procopciuc wrote: > From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > Add the compatible strings for the NXP s32g2 and s32g3. These chips > are mostly compatible. The one difference is that the s32g2-usbmisc > device has an errata ERR050474 which requires a special flag to be set > for handling packages that aren't 4 byte aligned. > > Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > Changes since v1: > 1: Alphabetize > 2: Update the commit message a bit. > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++ > Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index cc5787a8cfa3..f6372b76ed5a 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -23,6 +23,8 @@ properties: > - nvidia,tegra30-udc > - nvidia,tegra114-udc > - nvidia,tegra124-udc > + - nxp,s32g2-usb > + - nxp,s32g3-usb You plan support nxp,s32g3-usb fallback to nxp,s32g2-usb in dts, your dts can't pass CHECK_DTB with this bindding. Frank > - qcom,ci-hdrc > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > index 019435540df0..ca677d1a8274 100644 > --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -21,6 +21,8 @@ properties: > - fsl,imx53-usbmisc > - fsl,imx6q-usbmisc > - fsl,vf610-usbmisc > + - nxp,s32g2-usbmisc > + - nxp,s32g3-usbmisc > - items: > - enum: > - fsl,imx6ul-usbmisc > -- > 2.47.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 2025-06-12 18:50 [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Dan Carpenter 2025-06-12 18:50 ` [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Ghennadi Procopciuc @ 2025-06-13 14:50 ` Frank Li 1 sibling, 0 replies; 5+ messages in thread From: Frank Li @ 2025-06-13 14:50 UTC (permalink / raw) To: Dan Carpenter Cc: Greg Kroah-Hartman, Conor Dooley, devicetree, Fabio Estevam, imx, Krzysztof Kozlowski, linux-arm-kernel, linux-kernel, linux-usb, Peng Fan, Pengutronix Kernel Team, Peter Chen, Rob Herring, Sascha Hauer, Shawn Guo, Xu Yang, s32, linaro-s32, Larisa Grigore, Ionut Vicovan, Ghennadi Procopciuc On Thu, Jun 12, 2025 at 09:50:42PM +0300, Dan Carpenter wrote: > This patchset adds support for the s32g2 and s32g3 chips. > > The changes since v1: > * Put the device tree lines in alphabetical order. > * Add imx@lists.linux.dev to the CC list. > * Use power_lost_check() instead of creating a new REINIT_DURING_RESUME > flag. > * Change the Copyright date. > * Leave the .compatible = "nxp,s32g3-usb" out of the ci_hdrc_imx.c > driver because people can just specify both in the devicetree > since they are compatible. Suggest add dts patch also, make sure your dts file pass CHECK_DTBS Frank > > Ghennadi Procopciuc (3): > dt-bindings: usb: Add compatible strings for s32g2/s32g3 > usb: chipidea: s32g: Add usb support for s32g2 > usb: chipidea: s32g: Add usb support for s32g3 > > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 + > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 2 + > drivers/usb/chipidea/ci_hdrc_imx.c | 6 ++ > drivers/usb/chipidea/usbmisc_imx.c | 89 +++++++++++++++++++ > 4 files changed, 99 insertions(+) > > -- > 2.47.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-13 14:50 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-12 18:50 [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Dan Carpenter 2025-06-12 18:50 ` [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3 Ghennadi Procopciuc 2025-06-13 14:47 ` Conor Dooley 2025-06-13 14:49 ` Frank Li 2025-06-13 14:50 ` [PATCH 0/3 v2] usb: chipidea: Add support for s32g2 and s32g3 Frank Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).