From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869CBC2D0A8 for ; Wed, 23 Sep 2020 15:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33EA42137B for ; Wed, 23 Sep 2020 15:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="YS9RI+MC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgIWPfH (ORCPT ); Wed, 23 Sep 2020 11:35:07 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:8436 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgIWPfH (ORCPT ); Wed, 23 Sep 2020 11:35:07 -0400 X-Greylist: delayed 3884 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Sep 2020 11:35:06 EDT Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08NEQi6J014390; Wed, 23 Sep 2020 16:30:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=SjaY/w1nDEoWhikxQtwnd327tYOK3VZ51wdSZT/aEUk=; b=YS9RI+MCv/dZTSiRI2HLeGCC4O9EKyJdfd2K8y3fnqmxyNsMerNCRxjA4tmzEoOcNf3c pmusSpiiYsbySmOb8Xhmymgq0qY0fRWqTSv3cmcv/lpqBf4syKo1oWtV4q9A1rkBqd/I VXrlOXhhAeSs3W8dEE7hKyr5hnEQwsIofTwf2S04rjSTFRUJdazfb2TAbtSLh22wmMsf nlt6MZlZjtAQ4FYMmcW1pnA3gB1YuhgoYxqFiVVPt/rQbA9YerPpg26SUP5o0XGp+4lz SPnohXRTu0k27RoeX3aD+W40HUtGSji01pRamdaw2TkKBmCWmcFJbPK2wyMINWrnF24r Hg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 33n7eywne2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Sep 2020 16:30:12 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8E69410002A; Wed, 23 Sep 2020 16:30:11 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node1.st.com [10.75.127.7]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 154C12B8A2E; Wed, 23 Sep 2020 16:30:11 +0200 (CEST) Received: from lmecxl0889.tpe.st.com (10.75.127.49) by SFHDAG3NODE1.st.com (10.75.127.7) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 23 Sep 2020 16:30:09 +0200 Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization From: Arnaud POULIQUEN To: Rob Herring CC: Alexandre TORGUE , "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Fabien DESSENNE , Mathieu Poirier , Ohad Ben-Cohen , Bjorn Andersson References: <20200827072101.26588-1-arnaud.pouliquen@st.com> <20200827072101.26588-3-arnaud.pouliquen@st.com> <20200909202251.GA2975092@bogus> Message-ID: Date: Wed, 23 Sep 2020 16:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG6NODE3.st.com (10.75.127.18) To SFHDAG3NODE1.st.com (10.75.127.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-23_10:2020-09-23,2020-09-23 signatures=0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, Gentle reminder. As I'm not sure to well understand your comment I would appreciate if you could confirm your expectation before I sent a v2. Thanks in advance, Arnaud On 9/11/20 3:49 PM, Arnaud POULIQUEN wrote: > Hi Rob, > > On 9/9/20 10:22 PM, Rob Herring wrote: >> On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote: >>> Add new properties description used to attach to a pre-loaded >>> firmware according to the commit 9276536f455b3 >>> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation") >>> which updates the driver part. >>> >>> Signed-off-by: Arnaud Pouliquen >>> --- >>> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml >>> index 4ffa25268fcc..e50957d86b1c 100644 >>> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml >>> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml >>> @@ -96,6 +96,25 @@ properties: >>> 3rd cell: register bitmask for the deep sleep bit >>> maxItems: 1 >>> >>> + st,syscfg-m4-state: >>> + $ref: "/schemas/types.yaml#/definitions/phandle-array" >>> + description: | >>> + Reference to the tamp register which exposes the Cortex-M4 state. >>> + 1st cell: phandle to syscon block >>> + 2nd cell: register offset containing the Cortex-M4 state >>> + 3rd cell: register bitmask for the Cortex-M4 state >>> + maxItems: 1 >>> + >>> + st,syscfg-rsc-tbl: >>> + $ref: "/schemas/types.yaml#/definitions/phandle-array" >>> + description: | >>> + Reference to the tamp register which references the Cortex-M4 >>> + resource table address. >>> + 1st cell: phandle to syscon block >>> + 2nd cell: register offset containing the resource table address >>> + 3rd cell: register bitmask for the resource table address >>> + maxItems: 1 >> >> Why can't these be implied? You can lookup the tamp syscon by >> compatible. > > I just made a copy/past of the "st,syscfg-pdds" syscon description available in the same file [1] > > I can provide a shorter descriptions, something like this: > > description: | > Reference to the tamp syscon register and bitmask which contains the Cortex-M4 > resource table address. > maxItems: 1 > > Would this meet your expectations? If yes, I will also add in next version an extra patch to fix [1] > > [1] https://elixir.bootlin.com/linux/v5.9-rc3/source/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml#L90 > >> >> Please add these to the example. > > I will extend the example with these properties > > Thanks, > Arnaud > >> >>> + >>> st,auto-boot: >>> $ref: /schemas/types.yaml#/definitions/flag >>> description: >>> -- >>> 2.17.1 >>>