From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ludovic Barre <ludovic.barre@st.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] clocksource: stm32: rework driver to use only one timer
Date: Tue, 19 Sep 2017 17:54:37 +0200 [thread overview]
Message-ID: <cb440fab-b2a9-13ff-6f8a-4bce2eb2bc54@linaro.org> (raw)
In-Reply-To: <CA+M3ks45pUwv=dL6Gd6=Nvm1y5zRvtsFEU1bFoHht0xUDc3UVw@mail.gmail.com>
On 19/09/2017 09:59, Benjamin Gaignard wrote:
> 2017-09-18 23:30 GMT+02:00 Daniel Lezcano <daniel.lezcano@linaro.org>:
>> On 14/09/2017 09:56, Benjamin Gaignard wrote:
>>> Rework driver code to use only one timer for both clocksource
>>> and clockevent.
>>> This patch also forbids to use 16 bits timers because they are
>>> not enough accurate.
>>> Do some clean up in structures and functions names too.
>>>
>>> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>>
>> Hi Benjamin,
>>
>> I have a few comments below. Can you when reposting split this patch
>> into smaller changes ?
>
> Not so easy because I change the way of how the hardware is used to be able
> to provide clocksource and clockevent on the same hardware block.
>
>>
>> Also, can you consider using the timer-of API ?
>
> Is it just about using TIMER_OF_DECLARE ? or do you have something
> else in mind ?
It is something else, see commit dc11bae785.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-09-19 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 7:56 [PATCH 0/2] stm32 clocksource driver rework Benjamin Gaignard
[not found] ` <1505375812-19037-1-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-09-14 7:56 ` [PATCH 1/2] clocksource: stm32: rework driver to use only one timer Benjamin Gaignard
[not found] ` <1505375812-19037-2-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-09-15 18:27 ` kbuild test robot
2017-09-18 21:30 ` Daniel Lezcano
[not found] ` <9e5cae53-0a57-f2e9-cbb1-dde484619fca-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-09-19 7:59 ` Benjamin Gaignard
2017-09-19 15:54 ` Daniel Lezcano [this message]
2017-09-14 7:56 ` [PATCH 2/2] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
2017-09-15 21:03 ` Daniel Lezcano
2017-09-17 13:34 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb440fab-b2a9-13ff-6f8a-4bce2eb2bc54@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@st.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).