From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/2] clocksource: stm32: rework driver to use only one timer Date: Tue, 19 Sep 2017 17:54:37 +0200 Message-ID: References: <1505375812-19037-1-git-send-email-benjamin.gaignard@linaro.org> <1505375812-19037-2-git-send-email-benjamin.gaignard@linaro.org> <9e5cae53-0a57-f2e9-cbb1-dde484619fca@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Gaignard Cc: Rob Herring , Mark Rutland , Russell King - ARM Linux , Maxime Coquelin , Alexandre Torgue , Thomas Gleixner , Ludovic Barre , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On 19/09/2017 09:59, Benjamin Gaignard wrote: > 2017-09-18 23:30 GMT+02:00 Daniel Lezcano : >> On 14/09/2017 09:56, Benjamin Gaignard wrote: >>> Rework driver code to use only one timer for both clocksource >>> and clockevent. >>> This patch also forbids to use 16 bits timers because they are >>> not enough accurate. >>> Do some clean up in structures and functions names too. >>> >>> Signed-off-by: Ludovic Barre >>> Signed-off-by: Benjamin Gaignard >> >> Hi Benjamin, >> >> I have a few comments below. Can you when reposting split this patch >> into smaller changes ? > > Not so easy because I change the way of how the hardware is used to be able > to provide clocksource and clockevent on the same hardware block. > >> >> Also, can you consider using the timer-of API ? > > Is it just about using TIMER_OF_DECLARE ? or do you have something > else in mind ? It is something else, see commit dc11bae785. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog