From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CFE51A681C; Fri, 13 Mar 2026 15:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417316; cv=none; b=b0Oj9SvLoJ8/mzBHyyoYskZjDK+XWgSlKO5ddkfIzMcmUs++ekAyhulml8ogWnxbVw3vRSWgBMmDNvBDOC0ksXxkdOzB+Y/NmYJT+IFKAFB5HwZtGDE0J7HEwOmFeWuAfRdr8XYWL8tMVwBj7HCpRroogBd/7HxrZPQ0dihYNXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417316; c=relaxed/simple; bh=hVzQPtbQuzwll4VZu/CcnEuU8CMe9i+lkLu81Z18LsM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YRNJDw1/q4jHvIZ55+C7VRpxxDrYZ/XFFdk8+ooT5HfYHTDOc0c79G82QFYBGqiqQg+WLm8Hur6Tfz+7CDWW0Lt1l1BUo+M+XiygAn9UWI6kxF9Y7oObDHpYZXRkfEFSKrTvCsffYk0ZsxELYlEuZs9JcOoXcHtDWmHXkqRIEvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=URit964t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="URit964t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F4ACC19421; Fri, 13 Mar 2026 15:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773417316; bh=hVzQPtbQuzwll4VZu/CcnEuU8CMe9i+lkLu81Z18LsM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=URit964tQuoo2FgTGl7iTQplq2UPYIgQhA1mO0dgxijXmMyzXeCk6RLsTUAaNNTJI hUrqNYc62iAx/UTBoesTmC6Glyc/iYBICaDVF3evTPwe40zaTikBU6aed/Q0oyVRFJ oY8rMeQYpo3goT8oZStHDLMhSBL8G1oixkqV/RnRJIrDc1lZXX6ueidSJ+x+C/dAZn AftPqSJyxuJCNn6wcNAAjxde5Yt+1Dn3CJcO/kr3aBbePZjiuqsHCLHuy2rIQe+GjT 1FrJIhCEtz4gYZ0xZBvX6VYh8Pn7E6DISGiDFu9/0fuTys135rh2nP2AD8H2gS7bOF 14C5/zp6xQVbg== Message-ID: Date: Fri, 13 Mar 2026 16:55:10 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] media: iris: add platform data for kaanapali To: Dmitry Baryshkov , Vikash Garodia Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Vishnu Reddy , Hans Verkuil , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Bryan O'Donoghue References: <20260313-kaanapali-iris-v3-0-9c0d1a67af4b@oss.qualcomm.com> <20260313-kaanapali-iris-v3-7-9c0d1a67af4b@oss.qualcomm.com> <5t3bke2sjkxahn4pjhdpyznbrdmu67u7cfgdfwqgjcgo7cbg2e@4wr2jadk6b7i> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <5t3bke2sjkxahn4pjhdpyznbrdmu67u7cfgdfwqgjcgo7cbg2e@4wr2jadk6b7i> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/03/2026 16:46, Dmitry Baryshkov wrote: > On Fri, Mar 13, 2026 at 06:49:41PM +0530, Vikash Garodia wrote: >> Add support for the kaanapali platform by re-using the SM8550 >> definitions and using the vpu4 ops. >> Move the configurations that differs in a per-SoC platform header, that >> will contain SoC specific data. >> >> Co-developed-by: Vishnu Reddy >> Signed-off-by: Vishnu Reddy >> Signed-off-by: Vikash Garodia >> --- >> .../platform/qcom/iris/iris_platform_common.h | 1 + >> .../media/platform/qcom/iris/iris_platform_gen2.c | 90 ++++++++++++++++++++++ >> .../platform/qcom/iris/iris_platform_kaanapali.h | 83 ++++++++++++++++++++ >> drivers/media/platform/qcom/iris/iris_probe.c | 4 + >> 4 files changed, 178 insertions(+) >> > >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h b/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h >> new file mode 100644 >> index 0000000000000000000000000000000000000000..bdca1e5bf673353862c1554fb0420f73b3f519cb >> --- /dev/null >> +++ b/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h >> @@ -0,0 +1,83 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#ifndef __IRIS_PLATFORM_KAANAPALI_H__ >> +#define __IRIS_PLATFORM_KAANAPALI_H__ >> + >> +#include > > So, you are including the bindings here, from the header, which gets > included from the C source file including headers for all the platforms. > What if Kaanapali+1 (or +3) defines different sets of regions? Different problem - header file MUST NOT have data definitions. That's basic of C, we don't write such code. First because it leads to multiplied, redundant data. Second, that's not C coding style. This pattern in Qualcomm Iris is terrible and I could accept variations of existing data like below: > >> + >> +#define VIDEO_REGION_VM0_SECURE_NP_ID 1 >> +#define VIDEO_REGION_VM0_NONSECURE_NP_ID 5 >> + >> +static const char *const kaanapali_clk_reset_table[] = { >> + "bus0", >> + "bus1", >> + "core", >> + "vcodec0_core", >> +}; >> + >> +static const char *const kaanapali_pmdomain_table[] = { >> + "venus", >> + "vcodec0", >> + "vpp0", >> + "vpp1", >> + "apv", >> +}; >> + >> +static const struct platform_clk_data kaanapali_clk_table[] = { >> + { IRIS_AXI_CLK, "iface" }, >> + { IRIS_CTRL_CLK, "core" }, >> + { IRIS_HW_CLK, "vcodec0_core" }, >> + { IRIS_AXI1_CLK, "iface1" }, >> + { IRIS_CTRL_FREERUN_CLK, "core_freerun" }, >> + { IRIS_HW_FREERUN_CLK, "vcodec0_core_freerun" }, >> + { IRIS_BSE_HW_CLK, "vcodec_bse" }, >> + { IRIS_VPP0_HW_CLK, "vcodec_vpp0" }, >> + { IRIS_VPP1_HW_CLK, "vcodec_vpp1" }, >> + { IRIS_APV_HW_CLK, "vcodec_apv" }, >> +}; >> + >> +static const char *const kaanapali_opp_clk_table[] = { >> + "vcodec0_core", >> + "vcodec_apv", >> + "vcodec_bse", >> + "core", >> + NULL, >> +}; >> + >> +static struct tz_cp_config tz_cp_config_kaanapali[] = { But this is new thus NAK. Don't grow this broken pattern. There is no single reason data definition should be placed in a header. No single one. Best regards, Krzysztof