Re: [[RFC]DPU PATCH 4/4] dt-bindings: Add Innolux TV123WAM panel bindings

[spanda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org]

On 2018-04-24 20:13, Rob Herring wrote:
> On Wed, Apr 18, 2018 at 05:50:02PM +0530, Sandeep Panda wrote:
>> The Innolux TV123WAM is a 12.3" eDP display panel
>> with 2160x1440 resolution.
> 
> Why don't you just submit this for upstream?
Sean Paul has suggested to reuse simple panel driver instead of having a 
new driver altogether. So all these dt-bindings wont be needed.
> 
>> 
>> Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
>> ---
>>  .../bindings/display/panel/innolux,edp-2k-panel.txt | 21 
>> +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt 
>> b/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
>> new file mode 100644
>> index 0000000..19f271c
>> --- /dev/null
>> +++ 
>> b/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
>> @@ -0,0 +1,21 @@
>> +Innolux TV123WAM 12.3 inch eDP display panel
>> +
>> +Required properties:
>> +- power-supply: regulator to provide the supply voltage
>> +- enable-gpios: GPIO pin to enable or disable the panel
> 
> Need to state the active state.
> 
>> +
>> +Optional properties:
>> +- backlight: phandle of the backlight device attached to the panel
>> +
>> +Example:
>> +
>> +	edp_panel: edp_panel {
> 
> panel {
> 
>> +		compatible = "innolux, edp_2k_panel";
> 
> spurious space                        ^
> 
>> +		reg = <0>;
> 
> Not documented. Should be dropped.
> 
>> +
>> +		enable-gpios = <&msmgpio 32 GPIO_ACTIVE_HIGH>;
>> +
>> +		power-supply = <&pm8916_l8>;
>> +
> 
> Remove the extra blank lines.
> 
>> +		backlight = <&backlight>;
>> +	};
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" 
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno