* [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:33 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
` (12 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 479859bd8ab3..1d5e6ade8ae7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -92,6 +92,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <611>;
dynamic-power-coefficient = <290>;
@@ -118,6 +119,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <611>;
dynamic-power-coefficient = <290>;
@@ -140,6 +142,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <611>;
dynamic-power-coefficient = <290>;
@@ -162,6 +165,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <611>;
dynamic-power-coefficient = <290>;
@@ -184,6 +188,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <442>;
@@ -206,6 +211,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <442>;
@@ -228,6 +234,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <442>;
@@ -250,6 +257,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo385";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <442>;
@@ -5232,6 +5240,7 @@ cpufreq_hw: cpufreq@17d43000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
wifi: wifi@18800000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
@ 2023-02-16 10:33 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:33 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 479859bd8ab3..1d5e6ade8ae7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -92,6 +92,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <611>;
> dynamic-power-coefficient = <290>;
> @@ -118,6 +119,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <611>;
> dynamic-power-coefficient = <290>;
> @@ -140,6 +142,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <611>;
> dynamic-power-coefficient = <290>;
> @@ -162,6 +165,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <611>;
> dynamic-power-coefficient = <290>;
> @@ -184,6 +188,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <442>;
> @@ -206,6 +211,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <442>;
> @@ -228,6 +234,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <442>;
> @@ -250,6 +257,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo385";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <442>;
> @@ -5232,6 +5240,7 @@ cpufreq_hw: cpufreq@17d43000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> wifi: wifi@18800000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
2023-02-15 7:03 ` [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:34 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
` (11 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index bdcb74925313..d9b6e028cdac 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -168,6 +168,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -193,6 +194,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -214,6 +216,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -235,6 +238,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -256,6 +260,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -277,6 +282,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -298,6 +304,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -319,6 +326,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 2>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -5337,6 +5345,7 @@ cpufreq_hw: cpufreq@18591000 {
clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
@ 2023-02-16 10:34 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:34 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..d9b6e028cdac 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -168,6 +168,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -193,6 +194,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -214,6 +216,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -235,6 +238,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -256,6 +260,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -277,6 +282,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -298,6 +304,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -319,6 +326,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 2>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -5337,6 +5345,7 @@ cpufreq_hw: cpufreq@18591000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
> clock-names = "xo", "alternate";
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
> };
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
2023-02-15 7:03 ` [RESEND PATCH 01/12] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2023-02-15 7:03 ` [RESEND PATCH 02/12] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:35 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
` (10 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 1e1d366c92c1..c46bb6dab6a1 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -46,6 +46,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -71,6 +72,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -92,6 +94,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -113,6 +116,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -134,6 +138,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -155,6 +160,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
@@ -177,6 +183,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1894>;
dynamic-power-coefficient = <703>;
@@ -198,6 +205,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo560";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1894>;
dynamic-power-coefficient = <703>;
@@ -2002,6 +2010,7 @@ cpufreq_hw: cpufreq@18323000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
@ 2023-02-16 10:35 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:35 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 1e1d366c92c1..c46bb6dab6a1 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -46,6 +46,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -71,6 +72,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -92,6 +94,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -113,6 +116,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -134,6 +138,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -155,6 +160,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> @@ -177,6 +183,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1894>;
> dynamic-power-coefficient = <703>;
> @@ -198,6 +205,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo560";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1894>;
> dynamic-power-coefficient = <703>;
> @@ -2002,6 +2010,7 @@ cpufreq_hw: cpufreq@18323000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
> };
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (2 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 03/12] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:36 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
` (9 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 9910006c32aa..21b4f668889d 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -68,6 +68,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_0>;
power-domains = <&CPU_PD0>;
@@ -91,6 +92,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_100>;
power-domains = <&CPU_PD1>;
@@ -110,6 +112,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_200>;
power-domains = <&CPU_PD2>;
@@ -129,6 +132,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x300>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_300>;
power-domains = <&CPU_PD3>;
@@ -148,6 +152,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_400>;
power-domains = <&CPU_PD4>;
@@ -167,6 +172,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_500>;
power-domains = <&CPU_PD5>;
@@ -186,6 +192,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_600>;
power-domains = <&CPU_PD6>;
@@ -205,6 +212,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0 0x700>;
+ clocks = <&cpufreq_hw 2>;
enable-method = "psci";
next-level-cache = <&L2_700>;
power-domains = <&CPU_PD7>;
@@ -3341,6 +3349,7 @@ cpufreq_hw: cpufreq@17d91000 {
<GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1", "dcvsh-irq-2";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
pmu@24091000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
@ 2023-02-16 10:36 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:36 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 9910006c32aa..21b4f668889d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -68,6 +68,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_0>;
> power-domains = <&CPU_PD0>;
> @@ -91,6 +92,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_100>;
> power-domains = <&CPU_PD1>;
> @@ -110,6 +112,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_200>;
> power-domains = <&CPU_PD2>;
> @@ -129,6 +132,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x300>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_300>;
> power-domains = <&CPU_PD3>;
> @@ -148,6 +152,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_400>;
> power-domains = <&CPU_PD4>;
> @@ -167,6 +172,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_500>;
> power-domains = <&CPU_PD5>;
> @@ -186,6 +192,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_600>;
> power-domains = <&CPU_PD6>;
> @@ -205,6 +212,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0 0x700>;
> + clocks = <&cpufreq_hw 2>;
> enable-method = "psci";
> next-level-cache = <&L2_700>;
> power-domains = <&CPU_PD7>;
> @@ -3341,6 +3349,7 @@ cpufreq_hw: cpufreq@17d91000 {
> <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1", "dcvsh-irq-2";
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> pmu@24091000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (3 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 04/12] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:38 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: " Manivannan Sadhasivam
` (8 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 2f0e460acccd..44c8851178eb 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -97,6 +97,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <448>;
dynamic-power-coefficient = <205>;
@@ -127,6 +128,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <448>;
dynamic-power-coefficient = <205>;
@@ -151,6 +153,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <448>;
dynamic-power-coefficient = <205>;
@@ -175,6 +178,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <448>;
dynamic-power-coefficient = <205>;
@@ -199,6 +203,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <379>;
@@ -223,6 +228,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <379>;
@@ -248,6 +254,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <379>;
@@ -272,6 +279,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 2>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <444>;
@@ -5481,6 +5489,7 @@ cpufreq_hw: cpufreq@18591000 {
<GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1", "dcvsh-irq-2";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
@ 2023-02-16 10:38 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:38 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2f0e460acccd..44c8851178eb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -97,6 +97,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <448>;
> dynamic-power-coefficient = <205>;
> @@ -127,6 +128,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <448>;
> dynamic-power-coefficient = <205>;
> @@ -151,6 +153,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <448>;
> dynamic-power-coefficient = <205>;
> @@ -175,6 +178,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <448>;
> dynamic-power-coefficient = <205>;
> @@ -199,6 +203,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <379>;
> @@ -223,6 +228,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <379>;
> @@ -248,6 +254,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <379>;
> @@ -272,6 +279,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 2>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <444>;
> @@ -5481,6 +5489,7 @@ cpufreq_hw: cpufreq@18591000 {
> <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1", "dcvsh-irq-2";
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
> };
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (4 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 05/12] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:38 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
` (7 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/qdu1000.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
index f234159d2060..98a859ad5229 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
+++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
@@ -27,6 +27,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
power-domains = <&CPU_PD0>;
power-domain-names = "psci";
@@ -45,6 +46,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
power-domains = <&CPU_PD1>;
power-domain-names = "psci";
@@ -60,6 +62,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
power-domains = <&CPU_PD2>;
power-domain-names = "psci";
@@ -75,6 +78,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
power-domains = <&CPU_PD3>;
power-domain-names = "psci";
@@ -1312,6 +1316,7 @@ cpufreq_hw: cpufreq@17d90000 {
clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
gem_noc: interconnect@19100000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: " Manivannan Sadhasivam
@ 2023-02-16 10:38 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:38 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/qdu1000.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> index f234159d2060..98a859ad5229 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> @@ -27,6 +27,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "arm,cortex-a55";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> power-domains = <&CPU_PD0>;
> power-domain-names = "psci";
> @@ -45,6 +46,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "arm,cortex-a55";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> power-domains = <&CPU_PD1>;
> power-domain-names = "psci";
> @@ -60,6 +62,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "arm,cortex-a55";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> power-domains = <&CPU_PD2>;
> power-domain-names = "psci";
> @@ -75,6 +78,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "arm,cortex-a55";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> power-domains = <&CPU_PD3>;
> power-domain-names = "psci";
> @@ -1312,6 +1316,7 @@ cpufreq_hw: cpufreq@17d90000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
> clock-names = "xo", "alternate";
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> gem_noc: interconnect@19100000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (5 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 06/12] arm64: dts: qcom: qdu1000: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:38 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
` (6 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index ebfa21e9ed8a..53f0076f20f6 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -76,6 +76,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -103,6 +104,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -126,6 +128,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -149,6 +152,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -172,6 +176,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -195,6 +200,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
&LITTLE_CPU_SLEEP_1
@@ -218,6 +224,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -241,6 +248,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo468";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
&BIG_CPU_SLEEP_1
@@ -3578,6 +3586,7 @@ cpufreq_hw: cpufreq@18323000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
wifi: wifi@18800000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
@ 2023-02-16 10:38 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:38 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index ebfa21e9ed8a..53f0076f20f6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -76,6 +76,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -103,6 +104,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -126,6 +128,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -149,6 +152,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -172,6 +176,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -195,6 +200,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> &LITTLE_CPU_SLEEP_1
> @@ -218,6 +224,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -241,6 +248,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo468";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> &BIG_CPU_SLEEP_1
> @@ -3578,6 +3586,7 @@ cpufreq_hw: cpufreq@18323000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> wifi: wifi@18800000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (6 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 07/12] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:38 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
` (5 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index fd20096cfc6e..693d023d2629 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -48,6 +48,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <488>;
dynamic-power-coefficient = <232>;
@@ -74,6 +75,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <488>;
dynamic-power-coefficient = <232>;
@@ -97,6 +99,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <488>;
dynamic-power-coefficient = <232>;
@@ -119,6 +122,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <488>;
dynamic-power-coefficient = <232>;
@@ -141,6 +145,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <369>;
@@ -163,6 +168,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <369>;
@@ -185,6 +191,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <369>;
@@ -207,6 +214,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo485";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 2>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <421>;
@@ -4273,6 +4281,7 @@ cpufreq_hw: cpufreq@18323000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
lmh_cluster1: lmh@18350800 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
@ 2023-02-16 10:38 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:38 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index fd20096cfc6e..693d023d2629 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -48,6 +48,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <488>;
> dynamic-power-coefficient = <232>;
> @@ -74,6 +75,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <488>;
> dynamic-power-coefficient = <232>;
> @@ -97,6 +99,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <488>;
> dynamic-power-coefficient = <232>;
> @@ -119,6 +122,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <488>;
> dynamic-power-coefficient = <232>;
> @@ -141,6 +145,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <369>;
> @@ -163,6 +168,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <369>;
> @@ -185,6 +191,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <369>;
> @@ -207,6 +214,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo485";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 2>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <421>;
> @@ -4273,6 +4281,7 @@ cpufreq_hw: cpufreq@18323000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> lmh_cluster1: lmh@18350800 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (7 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 08/12] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:39 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
` (4 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 0a422637b61f..1b423c42ec0d 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -48,6 +48,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_0>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -69,6 +70,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_100>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -86,6 +88,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_200>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -103,6 +106,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_300>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -120,6 +124,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_400>;
qcom,freq-domain = <&cpufreq_hw 1>;
@@ -137,6 +142,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_500>;
qcom,freq-domain = <&cpufreq_hw 1>;
@@ -155,6 +161,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_600>;
qcom,freq-domain = <&cpufreq_hw 1>;
@@ -172,6 +179,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo685";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 2>;
enable-method = "psci";
next-level-cache = <&L2_700>;
qcom,freq-domain = <&cpufreq_hw 2>;
@@ -2283,6 +2291,7 @@ cpufreq_hw: cpufreq@18591000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
ufs_mem_hc: ufshc@1d84000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
@ 2023-02-16 10:39 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:39 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 0a422637b61f..1b423c42ec0d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -48,6 +48,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_0>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -69,6 +70,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -86,6 +88,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_200>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -103,6 +106,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_300>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -120,6 +124,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_400>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> @@ -137,6 +142,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_500>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> @@ -155,6 +161,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_600>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> @@ -172,6 +179,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo685";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 2>;
> enable-method = "psci";
> next-level-cache = <&L2_700>;
> qcom,freq-domain = <&cpufreq_hw 2>;
> @@ -2283,6 +2291,7 @@ cpufreq_hw: cpufreq@18591000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> ufs_mem_hc: ufshc@1d84000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (8 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 09/12] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:39 ` Konrad Dybcio
2023-02-15 7:03 ` [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: " Manivannan Sadhasivam
` (3 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 813fb168801f..a1eb9e333699 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -45,6 +45,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <602>;
next-level-cache = <&L2_0>;
@@ -69,6 +70,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <602>;
next-level-cache = <&L2_100>;
@@ -89,6 +91,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <602>;
next-level-cache = <&L2_200>;
@@ -109,6 +112,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
capacity-dmips-mhz = <602>;
next-level-cache = <&L2_300>;
@@ -129,6 +133,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
next-level-cache = <&L2_400>;
@@ -149,6 +154,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
next-level-cache = <&L2_500>;
@@ -169,6 +175,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
next-level-cache = <&L2_600>;
@@ -189,6 +196,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
next-level-cache = <&L2_700>;
@@ -3875,6 +3883,7 @@ cpufreq_hw: cpufreq@18591000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
remoteproc_nsp0: remoteproc@1b300000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
@ 2023-02-16 10:39 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:39 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 813fb168801f..a1eb9e333699 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -45,6 +45,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <602>;
> next-level-cache = <&L2_0>;
> @@ -69,6 +70,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <602>;
> next-level-cache = <&L2_100>;
> @@ -89,6 +91,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <602>;
> next-level-cache = <&L2_200>;
> @@ -109,6 +112,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> capacity-dmips-mhz = <602>;
> next-level-cache = <&L2_300>;
> @@ -129,6 +133,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> next-level-cache = <&L2_400>;
> @@ -149,6 +154,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> next-level-cache = <&L2_500>;
> @@ -169,6 +175,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> next-level-cache = <&L2_600>;
> @@ -189,6 +196,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> next-level-cache = <&L2_700>;
> @@ -3875,6 +3883,7 @@ cpufreq_hw: cpufreq@18591000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
>
> remoteproc_nsp0: remoteproc@1b300000 {
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (9 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 10/12] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
@ 2023-02-15 7:03 ` Manivannan Sadhasivam
2023-02-16 10:40 ` Konrad Dybcio
2023-02-15 7:04 ` [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
` (2 subsequent siblings)
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:03 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6375.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi
index 31b88c738510..58d3b4785401 100644
--- a/arch/arm64/boot/dts/qcom/sm6375.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi
@@ -39,6 +39,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_0>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -58,6 +59,7 @@ CPU1: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_100>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -74,6 +76,7 @@ CPU2: cpu@200 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x200>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_200>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -90,6 +93,7 @@ CPU3: cpu@300 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x300>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_300>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -106,6 +110,7 @@ CPU4: cpu@400 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x400>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_400>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -122,6 +127,7 @@ CPU5: cpu@500 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x500>;
+ clocks = <&cpufreq_hw 0>;
enable-method = "psci";
next-level-cache = <&L2_500>;
qcom,freq-domain = <&cpufreq_hw 0>;
@@ -139,6 +145,7 @@ CPU6: cpu@600 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x600>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_600>;
qcom,freq-domain = <&cpufreq_hw 1>;
@@ -155,6 +162,7 @@ CPU7: cpu@700 {
device_type = "cpu";
compatible = "qcom,kryo660";
reg = <0x0 0x700>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
next-level-cache = <&L2_700>;
qcom,freq-domain = <&cpufreq_hw 1>;
@@ -1383,6 +1391,7 @@ cpufreq_hw: cpufreq@fd91000 {
<GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 ` [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: " Manivannan Sadhasivam
@ 2023-02-16 10:40 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:40 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm6375.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi
> index 31b88c738510..58d3b4785401 100644
> --- a/arch/arm64/boot/dts/qcom/sm6375.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi
> @@ -39,6 +39,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_0>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -58,6 +59,7 @@ CPU1: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -74,6 +76,7 @@ CPU2: cpu@200 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x200>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_200>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -90,6 +93,7 @@ CPU3: cpu@300 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x300>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_300>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -106,6 +110,7 @@ CPU4: cpu@400 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x400>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_400>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -122,6 +127,7 @@ CPU5: cpu@500 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x500>;
> + clocks = <&cpufreq_hw 0>;
> enable-method = "psci";
> next-level-cache = <&L2_500>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> @@ -139,6 +145,7 @@ CPU6: cpu@600 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x600>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_600>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> @@ -155,6 +162,7 @@ CPU7: cpu@700 {
> device_type = "cpu";
> compatible = "qcom,kryo660";
> reg = <0x0 0x700>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> next-level-cache = <&L2_700>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> @@ -1383,6 +1391,7 @@ cpufreq_hw: cpufreq@fd91000 {
> <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1";
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
> };
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (10 preceding siblings ...)
2023-02-15 7:03 ` [RESEND PATCH 11/12] arm64: dts: qcom: sm6375: " Manivannan Sadhasivam
@ 2023-02-15 7:04 ` Manivannan Sadhasivam
2023-02-16 10:40 ` Konrad Dybcio
2023-02-16 10:32 ` [RESEND PATCH 00/12] arm64: dts: qcom: " Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson
13 siblings, 1 reply; 27+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-15 7:04 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
devicetree, linux-kernel, viresh.kumar, Manivannan Sadhasivam
Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
to the CPU cores. But this relationship is not represented in DTS so far.
So let's make cpufreq node as the clock provider and CPU nodes as the
consumers. The clock index for each CPU node is based on the frequency
domain index.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index 4d6ec815b78b..f55b193139bf 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -39,6 +39,7 @@ CPU0: cpu@0 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x0>;
+ clocks = <&cpufreq_hw 0>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
enable-method = "psci";
@@ -54,6 +55,7 @@ CPU1: cpu@1 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x1>;
+ clocks = <&cpufreq_hw 0>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
enable-method = "psci";
@@ -65,6 +67,7 @@ CPU2: cpu@2 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x2>;
+ clocks = <&cpufreq_hw 0>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
enable-method = "psci";
@@ -76,6 +79,7 @@ CPU3: cpu@3 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x3>;
+ clocks = <&cpufreq_hw 0>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <100>;
enable-method = "psci";
@@ -87,6 +91,7 @@ CPU4: cpu@100 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x100>;
+ clocks = <&cpufreq_hw 1>;
enable-method = "psci";
capacity-dmips-mhz = <1638>;
dynamic-power-coefficient = <282>;
@@ -102,6 +107,7 @@ CPU5: cpu@101 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x101>;
+ clocks = <&cpufreq_hw 1>;
capacity-dmips-mhz = <1638>;
dynamic-power-coefficient = <282>;
enable-method = "psci";
@@ -113,6 +119,7 @@ CPU6: cpu@102 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x102>;
+ clocks = <&cpufreq_hw 1>;
capacity-dmips-mhz = <1638>;
dynamic-power-coefficient = <282>;
enable-method = "psci";
@@ -124,6 +131,7 @@ CPU7: cpu@103 {
device_type = "cpu";
compatible = "qcom,kryo260";
reg = <0x0 0x103>;
+ clocks = <&cpufreq_hw 1>;
capacity-dmips-mhz = <1638>;
dynamic-power-coefficient = <282>;
enable-method = "psci";
@@ -2123,6 +2131,7 @@ cpufreq_hw: cpufreq@f521000 {
clock-names = "xo", "alternate";
#freq-domain-cells = <1>;
+ #clock-cells = <1>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: Supply clock from cpufreq node to CPUs
2023-02-15 7:04 ` [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
@ 2023-02-16 10:40 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:40 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:04, Manivannan Sadhasivam wrote:
> Qualcomm platforms making use of CPUFreq HW Engine (EPSS/OSM) supply clocks
> to the CPU cores. But this relationship is not represented in DTS so far.
>
> So let's make cpufreq node as the clock provider and CPU nodes as the
> consumers. The clock index for each CPU node is based on the frequency
> domain index.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 4d6ec815b78b..f55b193139bf 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -39,6 +39,7 @@ CPU0: cpu@0 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x0>;
> + clocks = <&cpufreq_hw 0>;
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> enable-method = "psci";
> @@ -54,6 +55,7 @@ CPU1: cpu@1 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x1>;
> + clocks = <&cpufreq_hw 0>;
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> enable-method = "psci";
> @@ -65,6 +67,7 @@ CPU2: cpu@2 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x2>;
> + clocks = <&cpufreq_hw 0>;
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> enable-method = "psci";
> @@ -76,6 +79,7 @@ CPU3: cpu@3 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x3>;
> + clocks = <&cpufreq_hw 0>;
> capacity-dmips-mhz = <1024>;
> dynamic-power-coefficient = <100>;
> enable-method = "psci";
> @@ -87,6 +91,7 @@ CPU4: cpu@100 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x100>;
> + clocks = <&cpufreq_hw 1>;
> enable-method = "psci";
> capacity-dmips-mhz = <1638>;
> dynamic-power-coefficient = <282>;
> @@ -102,6 +107,7 @@ CPU5: cpu@101 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x101>;
> + clocks = <&cpufreq_hw 1>;
> capacity-dmips-mhz = <1638>;
> dynamic-power-coefficient = <282>;
> enable-method = "psci";
> @@ -113,6 +119,7 @@ CPU6: cpu@102 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x102>;
> + clocks = <&cpufreq_hw 1>;
> capacity-dmips-mhz = <1638>;
> dynamic-power-coefficient = <282>;
> enable-method = "psci";
> @@ -124,6 +131,7 @@ CPU7: cpu@103 {
> device_type = "cpu";
> compatible = "qcom,kryo260";
> reg = <0x0 0x103>;
> + clocks = <&cpufreq_hw 1>;
> capacity-dmips-mhz = <1638>;
> dynamic-power-coefficient = <282>;
> enable-method = "psci";
> @@ -2123,6 +2131,7 @@ cpufreq_hw: cpufreq@f521000 {
> clock-names = "xo", "alternate";
>
> #freq-domain-cells = <1>;
> + #clock-cells = <1>;
> };
> };
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (11 preceding siblings ...)
2023-02-15 7:04 ` [RESEND PATCH 12/12] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
@ 2023-02-16 10:32 ` Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson
13 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:32 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson
Cc: robh+dt, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, viresh.kumar
On 15.02.2023 08:03, Manivannan Sadhasivam wrote:
> Hi,
>
> As a follow-up of [1], this series adds support for supplying clock from
> cpufreq node to CPUs for rest of the SoCs.
>
> This series has been tested on SDM845, SM8450 and SC8280XP based boards.
>
> Thanks,
> Mani
>
> [1] https://lore.kernel.org/linux-arm-msm/20221117053145.10409-1-manivannan.sadhasivam@linaro.org/
Maybe it would be beneficial to mark '#clock-cells' required in
bindings now, to prevent people from hitting that OPP bug?
Konrad
>
> Manivannan Sadhasivam (12):
> arm64: dts: qcom: sdm845: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sc7280: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm6350: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm8550: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm8250: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: qdu1000: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sc7180: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm8150: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm8350: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sc8280xp: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm6375: Supply clock from cpufreq node to CPUs
> arm64: dts: qcom: sm6115: Supply clock from cpufreq node to CPUs
>
> arch/arm64/boot/dts/qcom/qdu1000.dtsi | 5 +++++
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm6375.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 +++++++++
> 12 files changed, 104 insertions(+)
>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs
2023-02-15 7:03 [RESEND PATCH 00/12] arm64: dts: qcom: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
` (12 preceding siblings ...)
2023-02-16 10:32 ` [RESEND PATCH 00/12] arm64: dts: qcom: " Konrad Dybcio
@ 2023-03-15 23:35 ` Bjorn Andersson
13 siblings, 0 replies; 27+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:35 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: linux-arm-msm, konrad.dybcio, viresh.kumar, robh+dt, devicetree,
krzysztof.kozlowski+dt, linux-kernel
On Wed, 15 Feb 2023 12:33:48 +0530, Manivannan Sadhasivam wrote:
> As a follow-up of [1], this series adds support for supplying clock from
> cpufreq node to CPUs for rest of the SoCs.
>
> This series has been tested on SDM845, SM8450 and SC8280XP based boards.
>
> Thanks,
> Mani
>
> [...]
Applied, thanks!
[01/12] arm64: dts: qcom: sdm845: Supply clock from cpufreq node to CPUs
commit: 2af2ef08c0ba052aefca20609572d67e0633b1ef
[02/12] arm64: dts: qcom: sc7280: Supply clock from cpufreq node to CPUs
commit: 667d8a2039608c4c848179cb45282204eadeb157
[03/12] arm64: dts: qcom: sm6350: Supply clock from cpufreq node to CPUs
commit: afa34380d973491e87ab01d13c387528e2e1c476
[04/12] arm64: dts: qcom: sm8550: Supply clock from cpufreq node to CPUs
commit: 1b0911fe3edb0895c43db4c19729b3c300028189
[05/12] arm64: dts: qcom: sm8250: Supply clock from cpufreq node to CPUs
commit: d78cb07dbc1d384a8665b08918d188ee670ec45b
[06/12] arm64: dts: qcom: qdu1000: Supply clock from cpufreq node to CPUs
commit: fcca74d893f3511a1e95869b1b3db3abb69bfb3b
[07/12] arm64: dts: qcom: sc7180: Supply clock from cpufreq node to CPUs
commit: 7b39c98ff7e80f7e2bdf3c73829480e6ac123fb5
[08/12] arm64: dts: qcom: sm8150: Supply clock from cpufreq node to CPUs
commit: fc7258948c4a9e5dd2670adfcc80b13c621fbcd1
[09/12] arm64: dts: qcom: sm8350: Supply clock from cpufreq node to CPUs
commit: c2a18730f0aaa2088a259f123e5fedf05f8a7041
[10/12] arm64: dts: qcom: sc8280xp: Supply clock from cpufreq node to CPUs
commit: 2051f735b37d8e49f84914df11eb7b4a3a16349f
[11/12] arm64: dts: qcom: sm6375: Supply clock from cpufreq node to CPUs
commit: d9ab57eec39db8bf72951e00cde5ab117bcad6d8
[12/12] arm64: dts: qcom: sm6115: Supply clock from cpufreq node to CPUs
commit: 0e6538e2d973bdfdf4d65a7d4b8baf1b7cdf75f0
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread