From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AD6C4332F for ; Wed, 30 Nov 2022 15:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbiK3PZC (ORCPT ); Wed, 30 Nov 2022 10:25:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiK3PZB (ORCPT ); Wed, 30 Nov 2022 10:25:01 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B49A7E431 for ; Wed, 30 Nov 2022 07:24:58 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id d6so27482418lfs.10 for ; Wed, 30 Nov 2022 07:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+0BCcjLSSdMLqYLWjpCC6aMjjhEkfHkguLFqsvsQY2M=; b=wJEYzJPvPNQ+WbLH5BwUtMd05wUMgMjQWoAv4Jerr2yHAPrNp4ZusglHKI/ze3DxYt uRdq00ofY59stTD86gAEsOM0DRIOMhFYFyuMfhXYR2pIVJfb7cGMaIrBz4nVp/u1yUlU 8ohuAcGWqkYc7fMy4yjb3l/uo38F6JEPfDtn5b8Ypmvn4KnkVM6kQ+89ELgZ62yxiqLr 6EogoyS8H7IRZga3ZYSFnBQYgO8RkyqPrjjazvgEhPpxZWL7qozn1TSn+hPf4lt3PwZU TjWa4mIB6vYdfBa1ZQRTfPj6wpuC1hQ36q4VuJs9vchihf8CUgEpww2Ect3ngxtgVHHL VTkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+0BCcjLSSdMLqYLWjpCC6aMjjhEkfHkguLFqsvsQY2M=; b=2nfFgaK8VThrd3EShWuUi8u68SsbdfOlE4WNqDeLdySPx2e4FgwG4vqVV6DIHKs64m x4D189rUwJ5QQjjxF6UOjEqYCi77SQmPxCQUo30RiVfHIZJo0ep1bb9WlOchCdot4qo+ 9gzAmW6J6RxfMacEQWlNH2xQ8wNLkGgay2Jf/CyNqlHtWWlE9tbburE6rb5SIh7jdqoG gF7gMDURTP5V0Z9k7P31I9IBhXNLnHStwaOGaK3B6zQJn2g/LRNDoLYWY8DcEJzQseFd iVUzzj6J89yVUS10Di8GDIHr9MtIYHexwWT8E60F4STz0YAXZyrVg3gjaQG4kd9pXqmM IP/g== X-Gm-Message-State: ANoB5pniKcTPt9IYhajVKr4ntYo1z8ZlGzzGlv5iSgAqC/LcD6BWlziq V1xsL+j1qxOOTdapzWAjPcH+IQ== X-Google-Smtp-Source: AA0mqf4bPQ8Fltgiqp+JUq+K+K68Yb7F2StiWajMAq5Uz7JQnjaz8QbZr0Bb2QSbmHgNT0hgnKgMLw== X-Received: by 2002:a05:6512:3e2a:b0:4ab:534b:1b2c with SMTP id i42-20020a0565123e2a00b004ab534b1b2cmr15709904lfv.426.1669821897312; Wed, 30 Nov 2022 07:24:57 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e13-20020a05651236cd00b00492e5d31201sm297593lfs.7.2022.11.30.07.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 07:24:56 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 16:24:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller Content-Language: en-US To: Kunihiko Hayashi , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221129103509.9958-1-hayashi.kunihiko@socionext.com> <20221129103509.9958-2-hayashi.kunihiko@socionext.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/11/2022 09:59, Kunihiko Hayashi wrote: >>> +maintainers: >>> + - Kunihiko Hayashi >>> + >>> +description: |+ >>> + System controller implemented on Socionext UniPhier SoCs has multiple >>> + functions such as clock control, reset control, internal watchdog >>> timer, >>> + thermal management, and so on. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - socionext,uniphier-ld4-sysctrl >>> + - socionext,uniphier-pro4-sysctrl >>> + - socionext,uniphier-pro5-sysctrl >>> + - socionext,uniphier-pxs2-sysctrl >>> + - socionext,uniphier-ld6b-sysctrl >>> + - socionext,uniphier-sld8-sysctrl >>> + - socionext,uniphier-ld11-sysctrl >>> + - socionext,uniphier-ld20-sysctrl >>> + - socionext,uniphier-pxs3-sysctrl >>> + - socionext,uniphier-nx1-sysctrl >> >> All of them can have children or only some? > > In case of this system controller, > all SoCs has clock-controller, reset-controller and watchdog. > > However, some SoCs don't have thermal-sensor and > their register addresses are reserved. OK > >>> + - socionext,uniphier-sysctrl What about this one? What SoC is this? Looks too generic. Best regards, Krzysztof