From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA55C47088 for ; Fri, 2 Dec 2022 10:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232873AbiLBKrG (ORCPT ); Fri, 2 Dec 2022 05:47:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232728AbiLBKrF (ORCPT ); Fri, 2 Dec 2022 05:47:05 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7F22717D for ; Fri, 2 Dec 2022 02:47:03 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id g7so6812753lfv.5 for ; Fri, 02 Dec 2022 02:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9Vtg1LtCfjtyNCzyBNU5YXITjkmZBt3+mmKj+CQPVVc=; b=UD3RDKAs3ew754ylVfIQCZ/no50brGFS4qCHmlg5qAuU5YJ45sQ9/DYEWipoJDUrsd 8oFBWNEhCsEvrcJOao509FHXeaRMLuWw5NWqR7TIY246o9UH4Q2SKQ+sK0hZYuZaFyYg XvTC2EHgY2NCB2+3Ovm5X+nF5pVBG69Cae63PobFnrLZBz7j6cHixXmFnhP55uLTiRt8 UuXSCxnod/z2W+YT9S2M3LIpLk5jf3SaHjURYTzrpfJOZeGKFI+dpxFgbu26BKq+ODhK sYpsQU5mmVscmZ1pcPNSa+B8auqVN0HyyNBTosair3SGOq8wt47vDWbvAeDDdRb5zgSm BYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Vtg1LtCfjtyNCzyBNU5YXITjkmZBt3+mmKj+CQPVVc=; b=qMOVuYZMEjLciSfRynG86YFJfUJrQO6BGrsbmkSywCsRK7pXGHwDiM/0auORJfaBmg k0QpLCoSzTNGwX/p+idJ1Roe7mFpNmJNwfULUDykpWCeHtZyRI3o+lfSSG7kRarbepdr keEbSh0YQx/nf/85+vydrlw9AcTP0l3Kzx3hOaJIGmLTzTukEUtRNR3N+gB4TaPSfotz V+MsHreKeNNjxFHPoQMeTgl1mr8qctaIhCNDbLholBUGxqrqDrtjR853MKlHWPpeAY5N 3gMrHb8SvHnpw+eBu8WitY4A+vJR++TigRKr7GiUKdh56Kzflmlul1ZV5Gim9p48lgrq pLNQ== X-Gm-Message-State: ANoB5pm9i1aiH5JIPYZ8vRyR9yN6NiXLW7sRC+BtVrAarInK3cBkaBq7 AS6XByVRFzMg6E3QZ4iRB1Eqhg== X-Google-Smtp-Source: AA0mqf6gr/P7/w7zGPP1KlPQazaqNcuOmcl9Iu9U5TcIblGgOCA0ThAsves7sYSTqYRGj0mj2QSL+A== X-Received: by 2002:ac2:4c27:0:b0:4a2:4df9:4cab with SMTP id u7-20020ac24c27000000b004a24df94cabmr24215355lfq.56.1669978021914; Fri, 02 Dec 2022 02:47:01 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id bk37-20020a05651c23a500b002770eafaafbsm596033ljb.99.2022.12.02.02.47.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 02:47:01 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 11:46:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive Content-Language: en-US To: "xingu.wu" , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , linux-kernel@vger.kernel.org References: <20221202093943.149674-1-xingyu.wu@starfivetech.com> <20221202093943.149674-2-xingyu.wu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20221202093943.149674-2-xingyu.wu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/12/2022 10:39, xingu.wu wrote: > From: Xingyu Wu > > Add bindings to describe the watchdog for the StarFive SoCs. > > Signed-off-by: Xingyu Wu > --- > .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > new file mode 100644 > index 000000000000..ece3e80153a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml Filename should be based on compatible. You do not allow here any other models... If you intent and you are 100% sure you will grow with new models, make it maybe a family-based name. > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/starfive,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" Drop quotes. > + > +maintainers: > + - Samin Guo > + - Xingyu Wu > + > +properties: > + compatible: > + const: starfive,jh7110-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Core clock > + - description: APB clock > + > + clock-names: > + items: > + - const: core_clk Drop _clk > + - const: apb_clk Drop _clk > + > + resets: > + items: > + - description: APB reset > + - description: Core reset > + > + reset-names: > + items: > + - const: rst_apb Drop rst_ > + - const: rst_core Ditto > + > + timeout-sec: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - timeout-sec > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + watchdog@13070000 { > + compatible = "starfive,jh7110-wdt"; Use 4 spaces for example indentation. > + reg = <0x13070000 0x10000>; > + interrupts = <68>; > + clocks = <&syscrg_clk JH7110_SYSCLK_WDT_CORE>, > + <&syscrg_clk JH7110_SYSCLK_WDT_APB>; > + clock-names = "core_clk", "apb_clk"; > + resets = <&syscrg_rst JH7110_SYSRST_WDT_APB>, > + <&syscrg_rst JH7110_SYSRST_WDT_CORE>; > + reset-names = "rst_apb", "rst_core"; > + timeout-sec = <15>; > + }; > + Drop trailing line. Best regards, Krzysztof