From: Daniel Almeida <daniel.almeida@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
nicolas.dufresne@collabora.co.uk
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v1 7/9] media: verisilicon: Add Rockchip AV1 decoder
Date: Fri, 23 Dec 2022 20:15:38 -0300 [thread overview]
Message-ID: <cb95838c835aa91cd69e7067c8a3b747f89d2e95.camel@collabora.com> (raw)
In-Reply-To: <d7025e7e-246f-a7f4-f0b5-d1290a38a96c@collabora.com>
> > + int cur_offset[V4L2_AV1_NUM_REF_FRAMES - 1];
> > + int cur_roffset[V4L2_AV1_NUM_REF_FRAMES - 1];
>
> This looks like V4L2_AV1_REFS_PER_FRAME. Daniel, should be remove
> this
> V4L2_AV1_NUM_REF_FRAMES ? Its redundant with
> V4L2_AV1_TOTAL_REFS_PER_FRAME ...
Hi. These are different. NUM_REF_FRAMES is the size of the "DPB" while
TOTAL_REFS_PER_FRAME is the maximum number of references a frame can
use. It just so happens that in AV1 these two are close in absolute
value (i.e. 7 vs 8).
Using VP9 as a comparison, the DPB size is still 8, but REFS_PER_FRAME
is 3 (meaning a frame can specificy LAST, GOLDEN and ALTREF values).
As this is per spec and a mere convenience, I vote for keeping it.
-- Daniel
next prev parent reply other threads:[~2022-12-23 23:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 15:56 [PATCH v1 0/9] AV1 stateless decoder for RK3588 Benjamin Gaignard
2022-12-19 15:56 ` [PATCH v1 1/9] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible Benjamin Gaignard
2022-12-19 16:06 ` Krzysztof Kozlowski
2022-12-19 16:44 ` Benjamin Gaignard
2022-12-20 9:55 ` Krzysztof Kozlowski
2022-12-19 15:56 ` [PATCH v1 2/9] media: verisilicon: Add AV1 decoder mode and controls Benjamin Gaignard
2022-12-19 18:25 ` kernel test robot
2022-12-19 20:26 ` Nicolas Dufresne
2022-12-19 20:28 ` Nicolas Dufresne
2022-12-19 15:56 ` [PATCH v1 3/9] media: verisilicon: Save bit depth for AV1 decoder Benjamin Gaignard
2022-12-19 20:37 ` Nicolas Dufresne
2022-12-19 21:29 ` Ezequiel Garcia
2022-12-20 13:05 ` Benjamin Gaignard
2022-12-19 22:08 ` kernel test robot
2022-12-19 15:56 ` [PATCH v1 4/9] media: verisilicon: Check AV1 bitstreams bit depth Benjamin Gaignard
2022-12-19 20:38 ` Nicolas Dufresne
2022-12-20 13:02 ` Benjamin Gaignard
2022-12-21 16:16 ` Nicolas Dufresne
2022-12-19 15:56 ` [PATCH v1 5/9] media: verisilicon: Compute motion vectors size for AV1 frames Benjamin Gaignard
2022-12-19 20:42 ` Nicolas Dufresne
2022-12-20 13:13 ` Benjamin Gaignard
2022-12-19 15:56 ` [PATCH v1 6/9] media: verisilicon: Add AV1 entropy helpers Benjamin Gaignard
2022-12-19 20:51 ` Nicolas Dufresne
2022-12-20 10:19 ` Andrzej Pietrasiewicz
2022-12-20 12:19 ` Benjamin Gaignard
2022-12-19 15:56 ` [PATCH v1 7/9] media: verisilicon: Add Rockchip AV1 decoder Benjamin Gaignard
2022-12-19 19:16 ` kernel test robot
2022-12-19 21:56 ` Nicolas Dufresne
2022-12-20 14:49 ` Benjamin Gaignard
2022-12-21 16:30 ` Nicolas Dufresne
2022-12-21 16:37 ` Benjamin Gaignard
2022-12-23 23:15 ` Daniel Almeida [this message]
2022-12-23 23:20 ` Daniel Almeida
2022-12-19 15:56 ` [PATCH v1 8/9] media: verisilicon: Add film grain feature to AV1 driver Benjamin Gaignard
2022-12-19 20:47 ` kernel test robot
2022-12-19 15:56 ` [PATCH v1 9/9] media: verisilicon: Enable AV1 decoder on rk3588 Benjamin Gaignard
2022-12-19 20:22 ` [PATCH v1 0/9] AV1 stateless decoder for RK3588 Nicolas Dufresne
2022-12-19 21:07 ` Ezequiel Garcia
2022-12-19 21:54 ` Michael Grzeschik
2022-12-20 1:52 ` Ezequiel Garcia
2022-12-20 12:26 ` Benjamin Gaignard
2022-12-20 13:40 ` Michael Grzeschik
2022-12-20 17:15 ` Nicolas Dufresne
2022-12-20 17:50 ` Ezequiel Garcia
2022-12-21 22:17 ` Michael Grzeschik
2022-12-20 17:00 ` Nicolas Dufresne
2022-12-21 22:01 ` Michael Grzeschik
2022-12-22 13:24 ` Ezequiel Garcia
2022-12-21 16:33 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb95838c835aa91cd69e7067c8a3b747f89d2e95.camel@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.co.uk \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).