From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8CCC77B6E for ; Wed, 12 Apr 2023 08:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjDLIiL (ORCPT ); Wed, 12 Apr 2023 04:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbjDLIhz (ORCPT ); Wed, 12 Apr 2023 04:37:55 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35696E9B for ; Wed, 12 Apr 2023 01:36:42 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id f26so20716318ejb.1 for ; Wed, 12 Apr 2023 01:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681288508; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yoGluq/J5303QEsfmSr2iQw9kmdWUed7sT0pHVPfXtg=; b=I3dy17S7m2Vab1t0U+AGdFNZsDwDtgsJFXI5Jlt8+Fq3CCTOSOk9aw+7wV4OLzQVE4 DSTZOLwPrSBUZOYzFkbXMKLUGC45las/eApfBkCzJUZ46gJITnmIbD5vKp2llVNKaWOD LBZRzQCcPUG7/fRCEPBFHIedYZ+nfCHf4/2bJ/QAgVXi8GwaCoj8d9hury4TUpGzM0eQ LD9XbLgPpHAgwDMv701nn5YDVckB5mXBZBlCvXDUSfBDrR8sugEegXnfO+cFlT7oEhd3 ZpbejePdOv5lU6rNSCeaozsMu50LVV9y5tSweiLThhzSwXkHrR/4sdrkalzk0D191TsK Q9Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681288508; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yoGluq/J5303QEsfmSr2iQw9kmdWUed7sT0pHVPfXtg=; b=wRec+w1N1/DmieYW8gacbTXoSEy4Rfkb5jJiSmOili/EN8Nny1mVJtTxjGAsRkelP8 DSYELlUkvxWk5owytTRrp8g2j6sM0OQY0svvYQQLaftDwiyFKWWAPGTrz/csU479aniL Wuj4LlAM/zDKbd8UFG53flSIeAokQ+w83Mqun+AJvhs+VfcRgDcWEKAB6lPmYi1gEbb3 0ohMtRNLlHIOG/KGWyl8eUSsorE/S0SIyFPOy4o9YEHGq1bc5ev7OIJhX9pP2QIbCFTo td13fFuLdW7GFOvt5GBl+PNi4kiwBXVBwvT0OZ74vQlmqTa4cqf8DmFNGQsCIJe6e7Ez 068A== X-Gm-Message-State: AAQBX9deg9vAgK4u6f0kwj50wIOP//fdYAHIEbYfxciBuWWzdeDmVo1F eeo7oelBl5Zex5qN25VdZdf16Q== X-Google-Smtp-Source: AKy350ZF0tWwKgLIPhrVEdP4KEaeMRw0Kd5VxKsy15GudE93E4tkyqAIy7bUV5T2axpZPp5BerwaLw== X-Received: by 2002:a17:906:e2c6:b0:947:a6d7:e2b4 with SMTP id gr6-20020a170906e2c600b00947a6d7e2b4mr5434302ejb.8.1681288508144; Wed, 12 Apr 2023 01:35:08 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8fa0:9989:3f72:b14f? ([2a02:810d:15c0:828:8fa0:9989:3f72:b14f]) by smtp.gmail.com with ESMTPSA id tg12-20020a1709078dcc00b0094a473988b9sm4173113ejc.27.2023.04.12.01.35.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:35:07 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 10:35:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 1/7] dt-bindings: power: Constrain properties for JH7110 PMU Content-Language: en-US To: Changhuang Liang , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Walker Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20230411064743.273388-1-changhuang.liang@starfivetech.com> <20230411064743.273388-2-changhuang.liang@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230411064743.273388-2-changhuang.liang@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/04/2023 08:47, Changhuang Liang wrote: > When use "starfive,jh7110-pmu-dphy" compatible, do not need the reg and > interrupts properties. > > Signed-off-by: Changhuang Liang > --- > .../bindings/power/starfive,jh7110-pmu.yaml | 14 ++++++++++++-- > include/dt-bindings/power/starfive,jh7110-pmu.h | 3 +++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > index 98eb8b4110e7..ffb4406c2e56 100644 > --- a/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > +++ b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > @@ -8,6 +8,7 @@ title: StarFive JH7110 Power Management Unit > > maintainers: > - Walker Chen > + - Changhuang Liang > > description: | > StarFive JH7110 SoC includes support for multiple power domains which can be > @@ -17,6 +18,7 @@ properties: > compatible: > enum: > - starfive,jh7110-pmu > + - starfive,jh7110-pmu-dphy You do here much more than commit msg says. Isn'y DPHY a phy? Why is it in power? > > reg: > maxItems: 1 > @@ -29,10 +31,18 @@ properties: > > required: > - compatible > - - reg > - - interrupts > - "#power-domain-cells" > > +if: Put it under allOf (in this place). Will save you one re-indentation later. > + properties: > + compatible: > + contains: > + const: starfive,jh7110-pmu > +then: > + required: > + - reg > + - interrupts > + > additionalProperties: false > > examples: > diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h > index 132bfe401fc8..0bfd6700c144 100644 > --- a/include/dt-bindings/power/starfive,jh7110-pmu.h > +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h > @@ -14,4 +14,7 @@ > #define JH7110_PD_ISP 5 > #define JH7110_PD_VENC 6 > > +#define JH7110_PD_DPHY_TX 0 > +#define JH7110_PD_DPHY_RX 1 > + > #endif Best regards, Krzysztof