From: Thomas Zimmermann <tzimmermann@suse.de>
To: Leander Kieweg <kieweg.leander@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
u.kleine-koenig@baylibre.com
Subject: Re: [PATCH v6 0/2] drm: Add DRM driver for GlandaGPU (VHDL soft-IP GPU)
Date: Wed, 11 Nov 2026 11:27:06 +0100 [thread overview]
Message-ID: <cba017db-db33-429f-a837-766200ec16ec@suse.de> (raw)
In-Reply-To: <CAMwcS0ii+=5LvgeFRmMkQKUm9oReQj=-t7vZ5uxCrLGi=jzvnQ@mail.gmail.com>
Hi
Am 10.11.26 um 18:28 schrieb Leander Kieweg:
>> Oh, I thought you wanted to send a v7. :)
>>
>> There's nothing blocking it, I think. I'll merged the driver in soon.
> Hi Thomas,
>
> thank you for the review and for merging it!
There's was bitrot in there.
CC [M] drivers/gpu/drm/tiny/glandagpu.o
/home/tzimmermann/Projekte/drm-upstream/src/drivers/gpu/drm/tiny/glandagpu.c:293:10:
error: »const struct drm_crtc_funcs« hat kein Element namens »reset«
293 | .reset = drm_atomic_helper_crtc_reset,
| ^~~~~
/home/tzimmermann/Projekte/drm-upstream/src/drivers/gpu/drm/tiny/glandagpu.c:293:18:
error: »drm_atomic_helper_crtc_reset« ist hier (außerhalb einer
Funktion) nicht deklariert; meinten Sie »drm_atomic_helper_check_modeset«?
293 | .reset = drm_atomic_helper_crtc_reset,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| drm_atomic_helper_check_modeset
/home/tzimmermann/Projekte/drm-upstream/src/drivers/gpu/drm/tiny/glandagpu.c:317:10:
error: »const struct drm_connector_funcs« hat kein Element namens »reset«
317 | .reset = drm_atomic_helper_connector_reset,
| ^~~~~
/home/tzimmermann/Projekte/drm-upstream/src/drivers/gpu/drm/tiny/glandagpu.c:317:18:
error: »drm_atomic_helper_connector_reset« ist hier (außerhalb einer
Funktion) nicht deklariert; meinten Sie
»drm_atomic_helper_connector_tv_check«?
317 | .reset = drm_atomic_helper_connector_reset,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| drm_atomic_helper_connector_tv_check
The reset callbacks got replaced by atomic_create_state plus default
implementation. I've fixed the patch before merging it.
>
> After Christmas I will submit the QEMU patch to get the official
> device ID. Then I will send a follow-up kernel patch to replace the
> placeholder.
Sure.
Best regards
Thomas
>
> Best regards,
> Leander
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
prev parent reply other threads:[~2026-11-11 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 15:45 [PATCH v6 0/2] drm: Add DRM driver for GlandaGPU (VHDL soft-IP GPU) Leander Kieweg
2026-10-11 15:45 ` [PATCH v6 1/2] dt-bindings: display: Add GlandaGPU binding Leander Kieweg
2026-10-11 15:45 ` [PATCH v6 2/2] drm/glanda: Add initial DRM driver for GlandaGPU Leander Kieweg
2026-10-11 15:56 ` sashiko-bot
2026-11-10 10:36 ` [PATCH v6 0/2] drm: Add DRM driver for GlandaGPU (VHDL soft-IP GPU) Leander Kieweg
2026-11-10 12:54 ` Thomas Zimmermann
2026-11-10 17:28 ` Leander Kieweg
2026-11-11 10:27 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba017db-db33-429f-a837-766200ec16ec@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieweg.leander@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox