From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582DAC48BE5 for ; Tue, 15 Jun 2021 11:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42F3C60249 for ; Tue, 15 Jun 2021 11:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbhFOLkZ (ORCPT ); Tue, 15 Jun 2021 07:40:25 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4916 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbhFOLkZ (ORCPT ); Tue, 15 Jun 2021 07:40:25 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G45pM60H0z704Q; Tue, 15 Jun 2021 19:35:07 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 19:38:16 +0800 Received: from [127.0.0.1] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 19:38:16 +0800 Subject: Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" To: Mark Kettenis , Shawn Guo CC: , , , , , References: <20210524035244.8677-1-thunder.leizhen@huawei.com> <5612f2cad25a3041@bloch.sibelius.xs4all.nl> <52e44070-3b6f-b8ee-2f23-6059517755a8@huawei.com> <20210612021057.GE29138@dragon> <56133c63c48700e7@bloch.sibelius.xs4all.nl> From: "Leizhen (ThunderTown)" Message-ID: Date: Tue, 15 Jun 2021 19:38:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <56133c63c48700e7@bloch.sibelius.xs4all.nl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021/6/12 18:11, Mark Kettenis wrote: >> Date: Sat, 12 Jun 2021 10:10:58 +0800 >> From: Shawn Guo >> >> On Tue, May 25, 2021 at 10:00:30AM +0800, Leizhen (ThunderTown) wrote: >>> >>> >>> On 2021/5/25 1:36, Mark Kettenis wrote: >>>>> From: Zhen Lei >>>>> Date: Mon, 24 May 2021 11:52:44 +0800 >>>>> Content-Type: text/plain; charset="us-ascii" >>>>> >>>>> The compatible string of ARM SBSA defined generic UART needs to contain >>>>> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, >>>>> the pl011.yaml will check it and falsely report many warnings similar to >>>>> the following: >>>>> >>>>> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: >>>>> serial@21c0000: compatible:0: 'arm,pl011' was expected >>>>> serial@21c0000: compatible:1: 'arm,primecell' was expected >>>>> >>>>> Delete the redundant "arm,pl011" to fix it. >>>> >>>> According to its reference manual, the LX2160A has a full PL011 >>>> implementation. So I think this is the wrong "fix". >>> >>> No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html >>> >>> Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible >>> "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense >>> to append "arm, pl011" to the end of the compatible string as an alternative >>> driver. >>> >>> drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, >> >> I guess Mark is suggesting the following fix. >> >> uart0: serial@21c0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21c0000 0x0 0x1000>; >> interrupts = ; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> I copied some folks who might help clarify whether LX2160A UART is a SBSA >> or a full PL011. > > Sorry, I missed Leizhen's original reply. But yes, that is what I > meant. According to the NXP documentation, the LX2160A has a real > PL011 UART, so the correct fix is what Shawn suggests above. Okay, so I'll prepare v2 on the advice of Shawn. > > Cheers, > > Mark > >>>>> Signed-off-by: Zhen Lei >>>>> --- >>>>> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- >>>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> index 4fcc869c21a4..417546616d85 100644 >>>>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> @@ -920,7 +920,7 @@ >>>>> }; >>>>> >>>>> uart0: serial@21c0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21c0000 0x0 0x1000>; >>>>> interrupts = ; >>>>> current-speed = <115200>; >>>>> @@ -928,7 +928,7 @@ >>>>> }; >>>>> >>>>> uart1: serial@21d0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21d0000 0x0 0x1000>; >>>>> interrupts = ; >>>>> current-speed = <115200>; >>>>> @@ -936,7 +936,7 @@ >>>>> }; >>>>> >>>>> uart2: serial@21e0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21e0000 0x0 0x1000>; >>>>> interrupts = ; >>>>> current-speed = <115200>; >>>>> @@ -944,7 +944,7 @@ >>>>> }; >>>>> >>>>> uart3: serial@21f0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21f0000 0x0 0x1000>; >>>>> interrupts = ; >>>>> current-speed = <115200>; >>>>> -- >>>>> 2.21.1 >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> linux-arm-kernel mailing list >>>>> linux-arm-kernel@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>>>> >>>> >>>> . >>>> >>> >> > > . >