Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kumar Patro <bibek.patro@oss.qualcomm.com>,
	Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
Subject: Re: [PATCH v2] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode
Date: Tue, 4 Aug 2026 17:38:28 +0200	[thread overview]
Message-ID: <cbc62091-ace6-4e4b-8cae-fdf9b83b118d@kernel.org> (raw)
In-Reply-To: <c1f8b5bc-6d50-42bc-b671-7e91d76cb975@oss.qualcomm.com>

On 04/08/2026 17:18, Vishnu Santhosh wrote:
> 
> On 30-07-2026 12:53 pm, Krzysztof Kozlowski wrote:
>> On Wed, Jul 29, 2026 at 02:21:01PM +0530, Vishnu Santhosh wrote:
>>> The BAM-DMUX node lives as a direct child of the modem PAS remoteproc
>> No, it does not. Look:
>>
>>    $  git describe
>>    next-20260729
>>    $ git grep bam-dmux
>>    No child node shown
> 
> The commit message overstated this. The dt changes are yet to be merged.
> I'll correct it in v3.
> 
>>
>> Why isn't this part of Shikra remoteproc commit/patch? How any code
>> could pass validation otherwise?
> 
> By the time the BAM-DMUX support was brought up and validated, the
> remoteproc changes was already in a stable state. Therefore, the

No, it was not in stable state if it was not merged.

> bam-dmux change is being submitted separately.

No, bindings should be complete.

> 
>>> node, but qcom,shikra-pas.yaml has unevaluatedProperties: false and
>>> does not list bam-dmux, so any DT adding this subnode fails schema
>>> validation.
>> Fails how? How can I reproduce the error?
>>
>> There is no bam-dma in this binding example.
>>
>>
>> Best regards,
>> Krzysztof
> 
> Did you mean bam-dmux (the property this patch adds)? If so, I'll add
> an example with a bam-dmux subnode in v3.

You claim something fails. Prove it.


Best regards,
Krzysztof

  reply	other threads:[~2026-08-04 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  8:51 [PATCH v2] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode Vishnu Santhosh
2026-07-30  7:23 ` Krzysztof Kozlowski
2026-08-04 15:18   ` Vishnu Santhosh
2026-08-04 15:38     ` Krzysztof Kozlowski [this message]
2026-08-05  9:46       ` Vishnu Santhosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc62091-ace6-4e4b-8cae-fdf9b83b118d@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=deepak.singh@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=vishnu.santhosh@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox