* Re: [PATCH v29 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195
[not found] ` <20221227080443.6273-2-nancy.lin@mediatek.com>
@ 2023-01-10 10:50 ` Krzysztof Kozlowski
2023-01-13 9:51 ` Nancy Lin (林欣螢)
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-10 10:50 UTC (permalink / raw)
To: Nancy.Lin, Rob Herring, Matthias Brugger, Philipp Zabel, CK Hu,
wim, krzysztof.kozlowski+dt
Cc: Nathan Chancellor, Nick Desaulniers, Jason-JH Lin, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, clang-built-linux,
Project_Global_Chrome_Upstream_Group, singo.chang
On 27/12/2022 09:04, Nancy.Lin wrote:
> Add vdosys1 mmsys compatible for MT8195 platform.
>
> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
> 2 different power domains, different clock drivers and different
> mediatek-drm drivers.
>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> index 0711f1834fbd..242ce5a69432 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> @@ -52,6 +52,10 @@ properties:
> - const: mediatek,mt8195-mmsys
> - const: syscon
>
> + - items:
> + - const: mediatek,mt8195-vdosys1
This should be part of first enum. Don't create redundant entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v29 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195
2023-01-10 10:50 ` [PATCH v29 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Krzysztof Kozlowski
@ 2023-01-13 9:51 ` Nancy Lin (林欣螢)
0 siblings, 0 replies; 2+ messages in thread
From: Nancy Lin (林欣螢) @ 2023-01-13 9:51 UTC (permalink / raw)
To: p.zabel@pengutronix.de, matthias.bgg@gmail.com,
wim@linux-watchdog.org, krzysztof.kozlowski@linaro.org,
robh+dt@kernel.org, CK Hu (胡俊光),
krzysztof.kozlowski+dt@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Singo Chang (張興國), nathan@kernel.org,
Jason-JH Lin (林睿祥),
devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group,
linux-arm-kernel@lists.infradead.org,
clang-built-linux@googlegroups.com, ndesaulniers@google.com
Dear Krzysztof,
Thanks for the review.
On Tue, 2023-01-10 at 11:50 +0100, Krzysztof Kozlowski wrote:
> On 27/12/2022 09:04, Nancy.Lin wrote:
> > Add vdosys1 mmsys compatible for MT8195 platform.
> >
> > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding
> > to
> > 2 different power domains, different clock drivers and different
> > mediatek-drm drivers.
> >
> > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4
> > ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > index 0711f1834fbd..242ce5a69432 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > @@ -52,6 +52,10 @@ properties:
> > - const: mediatek,mt8195-mmsys
> > - const: syscon
> >
> > + - items:
> > + - const: mediatek,mt8195-vdosys1
>
> This should be part of first enum. Don't create redundant entries.
>
> Best regards,
> Krzysztof
OK, I will modify as following:
@@ -33,6 +33,7 @@ properties:
- mediatek,mt8186-mmsys
- mediatek,mt8188-vdosys0
- mediatek,mt8192-mmsys
+ - mediatek,mt8195-vdosys1
- mediatek,mt8365-mmsys
- const: syscon
Best,
Nancy
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-13 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221227080443.6273-1-nancy.lin@mediatek.com>
[not found] ` <20221227080443.6273-2-nancy.lin@mediatek.com>
2023-01-10 10:50 ` [PATCH v29 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 Krzysztof Kozlowski
2023-01-13 9:51 ` Nancy Lin (林欣螢)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).