* [PATCH] dt-bindings: ata: Add UniPhier controller binding
@ 2023-02-09 1:40 Kunihiko Hayashi
2023-02-09 8:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Kunihiko Hayashi @ 2023-02-09 1:40 UTC (permalink / raw)
To: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Hans de Goede,
Jens Axboe
Cc: linux-ide, devicetree, linux-kernel, Kunihiko Hayashi
Add UniPhier SATA controller compatible string to the platform binding.
This controller needs two reset controls.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
index 7dc2a2e8f598..3f6b21032d02 100644
--- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
+++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
@@ -45,6 +45,9 @@ properties:
- marvell,armada-8k-ahci
- marvell,berlin2-ahci
- marvell,berlin2q-ahci
+ - socionext,uniphier-pro4-ahci
+ - socionext,uniphier-pxs2-ahci
+ - socionext,uniphier-pxs3-ahci
- const: generic-ahci
- enum:
- cavium,octeon-7130-ahci
@@ -74,7 +77,8 @@ properties:
maxItems: 1
resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
patternProperties:
"^sata-port@[0-9a-f]+$":
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: ata: Add UniPhier controller binding
2023-02-09 1:40 [PATCH] dt-bindings: ata: Add UniPhier controller binding Kunihiko Hayashi
@ 2023-02-09 8:51 ` Krzysztof Kozlowski
2023-02-09 11:19 ` Kunihiko Hayashi
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 8:51 UTC (permalink / raw)
To: Kunihiko Hayashi, Damien Le Moal, Rob Herring,
Krzysztof Kozlowski, Hans de Goede, Jens Axboe
Cc: linux-ide, devicetree, linux-kernel
On 09/02/2023 02:40, Kunihiko Hayashi wrote:
> Add UniPhier SATA controller compatible string to the platform binding.
> This controller needs two reset controls.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> index 7dc2a2e8f598..3f6b21032d02 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> @@ -45,6 +45,9 @@ properties:
> - marvell,armada-8k-ahci
> - marvell,berlin2-ahci
> - marvell,berlin2q-ahci
> + - socionext,uniphier-pro4-ahci
> + - socionext,uniphier-pxs2-ahci
> + - socionext,uniphier-pxs3-ahci
> - const: generic-ahci
> - enum:
> - cavium,octeon-7130-ahci
> @@ -74,7 +77,8 @@ properties:
> maxItems: 1
>
> resets:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
You now allow two resets for each other platform, which is not justified
in commit msg. Constrain it per device/compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ata: Add UniPhier controller binding
2023-02-09 8:51 ` Krzysztof Kozlowski
@ 2023-02-09 11:19 ` Kunihiko Hayashi
0 siblings, 0 replies; 3+ messages in thread
From: Kunihiko Hayashi @ 2023-02-09 11:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Damien Le Moal, Rob Herring,
Krzysztof Kozlowski, Hans de Goede, Jens Axboe
Cc: linux-ide, devicetree, linux-kernel
Hi Krzysztof,
Thank you for reviewing.
On 2023/02/09 17:51, Krzysztof Kozlowski wrote:
> On 09/02/2023 02:40, Kunihiko Hayashi wrote:
>> Add UniPhier SATA controller compatible string to the platform binding.
>> This controller needs two reset controls.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> index 7dc2a2e8f598..3f6b21032d02 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> @@ -45,6 +45,9 @@ properties:
>> - marvell,armada-8k-ahci
>> - marvell,berlin2-ahci
>> - marvell,berlin2q-ahci
>> + - socionext,uniphier-pro4-ahci
>> + - socionext,uniphier-pxs2-ahci
>> + - socionext,uniphier-pxs3-ahci
>> - const: generic-ahci
>> - enum:
>> - cavium,octeon-7130-ahci
>> @@ -74,7 +77,8 @@ properties:
>> maxItems: 1
>>
>> resets:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>
> You now allow two resets for each other platform, which is not justified
> in commit msg. Constrain it per device/compatible.
Ah I see.
I'll add if-then clause to constrain compatible instead of changing that
directly.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 1:40 [PATCH] dt-bindings: ata: Add UniPhier controller binding Kunihiko Hayashi
2023-02-09 8:51 ` Krzysztof Kozlowski
2023-02-09 11:19 ` Kunihiko Hayashi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).