From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G
Date: Wed, 4 Sep 2024 09:56:14 +0200 [thread overview]
Message-ID: <cbfee403-0fc0-4ac7-bce7-5f7560ed2ea3@kernel.org> (raw)
In-Reply-To: <ZtgSMlgKyQ6nKu4U@hovoldconsulting.com>
On 04/09/2024 09:54, Johan Hovold wrote:
> On Wed, Sep 04, 2024 at 09:46:09AM +0200, Krzysztof Kozlowski wrote:
>> On 04/09/2024 00:42, Jérôme de Bretagne wrote:
>>> Add an initial devicetree for the Microsoft Surface Pro 9 5G, based
>>> on SC8280XP.
>
>> Rest looks good, except ordering of nodes/overrides/phandles. They
>> should go alphabetically, AFAIR, so your &tlmm is placed in wrong spot.
>
> For the other sc8280xp machines (and I believe at least some other
> SoCs), we placed the pinctrl section, which tends to be quite long, last
> on purpose with a separating header (e.g. so that it is easy to find):
>
> /* PINCTRL */
>
> &pmr735a_gpios {
> ...
>
> &tlmm {
>
>
> Looks like the header comment is missing here if you want to follow that
> style, though.
If that is the style here, no problem for me. With two node name fixes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-04 7:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 22:42 [PATCH 0/4] Microsoft Surface Pro 9 5G support Jérôme de Bretagne
2024-09-03 22:42 ` [PATCH 1/4] dt-bindings: arm: qcom: Document Microsoft Surface Pro 9 5G Jérôme de Bretagne
2024-09-04 6:42 ` Krzysztof Kozlowski
2024-09-03 22:42 ` [PATCH 2/4] firmware: qcom: scm: Allow QSEECOM on " Jérôme de Bretagne
2024-09-04 10:53 ` Konrad Dybcio
2024-09-03 22:42 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp: Add uart18 Jérôme de Bretagne
2024-09-05 13:49 ` Konrad Dybcio
2024-09-03 22:42 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G Jérôme de Bretagne
2024-09-04 7:46 ` Krzysztof Kozlowski
2024-09-04 7:54 ` Johan Hovold
2024-09-04 7:55 ` Johan Hovold
2024-09-04 7:56 ` Krzysztof Kozlowski [this message]
2024-09-04 14:14 ` Konrad Dybcio
2024-09-04 14:14 ` Konrad Dybcio
2024-09-04 13:36 ` [PATCH 0/4] Microsoft Surface Pro 9 5G support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbfee403-0fc0-4ac7-bce7-5f7560ed2ea3@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jerome.debretagne@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).