From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B70C54EAA for ; Mon, 30 Jan 2023 10:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236495AbjA3K75 (ORCPT ); Mon, 30 Jan 2023 05:59:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236398AbjA3K7v (ORCPT ); Mon, 30 Jan 2023 05:59:51 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818DC3252C for ; Mon, 30 Jan 2023 02:59:47 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id t18so10674757wro.1 for ; Mon, 30 Jan 2023 02:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=0Z8uT27zXqHP075WCZAzyrIHic+yDVlBHrlssAyuAUM=; b=NiIO4SMiQLbe67Fym5JRRoOy7y9Eq0YI0OXOIq9dv+wJ+FhtzztYafPE3m4gLc0g8V jl0w370sQGHOdgMP56aUovXP7Nn1yYy826UyZz00wqOP/5NYbJQGUKBStkeM+mu27Fej 3oYdQjWFBzS2+3evX9bNsjNRpNH3s+zNS+v0OOCd5JiKe4lFMfyd3Ko3pLDd97MrYtA3 WRCcG6S3ON09OEYH8XwPlwSOew/qfU8rn0eJJ73LR/Ahu8DVhSij4t+uO2ZG5LuDBMZA KUQXddk+da3QifkYeiRYbIAA2JO09WYizDIHTcXZH2h47vUr/tfWngIoaTDmom1bzY5n LBgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Z8uT27zXqHP075WCZAzyrIHic+yDVlBHrlssAyuAUM=; b=Hn2mKRLscvNXCgPM96Tt7kgElafvnEiLFIyMEXnkQRgKaw8Du2+xP5Jnvb2NoPFksg SO0wcg/wCH/dSiiU/2JtoF3iMNncTR07cGw15imcfx7WeUUkAoHlElgqpl73Qzhze4WP cCvoDsPdb+szOtWvqwJ1sTRJuvuCfxiWeE46Ji4W8YoJY0KwUknNtke6EgIfHKO8/4ys I9tyYMu3p0Sz7lmHW41gDC8s0NuHdsIKvBWVt8jr4uUFR6WphCQuz/J0jo8Qy/1HAWs5 4T/2PCZcoN7rzT4mm69Vzp/s1SL19oUtEnhO6PmsaQ+TvyUhHxEEgEZnYMk6HFZAy2Vl up4Q== X-Gm-Message-State: AO0yUKVG2aqV/mqQLtQTjHnYCdoO2ElGO7xaEuP5vSZFWy0Fgqepr/Aq /QWWb5mrfFJ1CE4lRC5abp2qAA== X-Google-Smtp-Source: AK7set/sYnO95MR4+0FT0/tcJvTb7fmizp1HJ+iffXGPWUEjMjzpfDRyiHJWbFvI9ZBar1MpSK8Yiw== X-Received: by 2002:a5d:4050:0:b0:2bf:d683:135a with SMTP id w16-20020a5d4050000000b002bfd683135amr9133033wrp.37.1675076385832; Mon, 30 Jan 2023 02:59:45 -0800 (PST) Received: from [192.168.7.111] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id n9-20020a5d67c9000000b00294176c2c01sm11465658wrw.86.2023.01.30.02.59.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 02:59:45 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 11:59:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 6/7] arm64: dts: qcom: sm8550-mtp: add pmic glink node Content-Language: en-US To: Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-6-0b0acfad301e@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/01/2023 11:41, Konrad Dybcio wrote: > > > On 30.01.2023 10:54, Neil Armstrong wrote: >> Add the pmic glink node linked with the DWC3 USB controller >> switched to OTG mode and tagged with usb-role-switch. >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 34 ++++++++++++++++++++++++++++++++- >> 1 file changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> index 725d3bc3ee72..f054c11fe1f6 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> @@ -27,6 +27,31 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> + pmic-glink { >> + compatible = "qcom,sm8450-pmic-glink", > 8550? > > Otherwise same comments as for the previous patch Oops bad copy-pasta even if it still works... Thanks, Neil > > Konrad > "qcom,pmic-glink"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + connector@0 { >> + compatible = "usb-c-connector"; >> + reg = <0>; >> + power-role = "dual"; >> + data-role = "dual"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + pmic_glink_dwc3_in: endpoint { >> + remote-endpoint = <&usb_1_dwc3_out>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> vph_pwr: vph-pwr-regulator { >> compatible = "regulator-fixed"; >> regulator-name = "vph_pwr"; >> @@ -546,7 +571,14 @@ &usb_1 { >> }; >> >> &usb_1_dwc3 { >> - dr_mode = "peripheral"; >> + dr_mode = "otg"; >> + usb-role-switch; >> + >> + port { >> + usb_1_dwc3_out: endpoint { >> + remote-endpoint = <&pmic_glink_dwc3_in>; >> + }; >> + }; >> }; >> >> &usb_1_hsphy { >>