From: Georgi Djakov <georgi.djakov@linaro.org>
To: Henry Chen <henryc.chen@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Stephen Boyd <swboyd@chromium.org>,
Ryan Case <ryandcase@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Nicolas Boichat <drinkcat@google.com>,
Fan Chen <fan.chen@mediatek.com>,
James Liao <jamesjj.liao@mediatek.com>,
Arvin Wang <arvin.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH V9 08/12] interconnect: mediatek: Add interconnect provider driver
Date: Thu, 18 Mar 2021 11:14:50 +0200 [thread overview]
Message-ID: <cc1d4ea2-22f6-e962-07bc-815ce73b2cb9@linaro.org> (raw)
In-Reply-To: <1614656863-8530-9-git-send-email-henryc.chen@mediatek.com>
On 3/2/21 05:47, Henry Chen wrote:
> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> using the interconnect framework.
>
> ICC provider ICC Nodes
> ---- ----
> --------- |CPU | |--- |VPU |
> ----- | |----- ---- | ----
> |DRAM |--|DRAM | ---- | ----
> | |--|scheduler|----- |GPU | |--- |DISP|
> | |--|(EMI) | ---- | ----
> | |--| | ----- | ----
> ----- | |----- |MMSYS|--|--- |VDEC|
> --------- ----- | ----
> /|\ | ----
> |change DRAM freq |--- |VENC|
> ---------- | ----
> | DVFSR | |
> | | | ----
> ---------- |--- |IMG |
> | ----
> | ----
> |--- |CAM |
> ----
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> drivers/interconnect/Kconfig | 1 +
> drivers/interconnect/Makefile | 1 +
> drivers/interconnect/mediatek/Kconfig | 13 ++
> drivers/interconnect/mediatek/Makefile | 3 +
> drivers/interconnect/mediatek/mtk-emi.c | 331 ++++++++++++++++++++++++++++++++
> 5 files changed, 349 insertions(+)
> create mode 100644 drivers/interconnect/mediatek/Kconfig
> create mode 100644 drivers/interconnect/mediatek/Makefile
> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
[..]
> +++ b/drivers/interconnect/mediatek/mtk-emi.c
> @@ -0,0 +1,331 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + *
> + */
> +
> +#include <linux/device.h>
> +#include <linux/interconnect-provider.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/soc/mediatek/mtk_dvfsrc.h>
The patch looks good to me, but as there is a build dependency I'll wait
until the dvfsrc patches are reviewed/picked by Matthias.
Thanks,
Georgi
next prev parent reply other threads:[~2021-03-18 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 3:47 [PATCH V9 00/13] Add driver for dvfsrc, support for interconnect Henry Chen
2021-03-02 3:47 ` [PATCH V9 01/12] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2021-03-08 18:38 ` Rob Herring
2021-03-02 3:47 ` [PATCH V9 02/12] soc: mediatek: add header for mediatek SIP interface Henry Chen
2021-03-02 3:47 ` [PATCH V9 03/12] soc: mediatek: add driver for dvfsrc support Henry Chen
2021-03-18 9:14 ` Georgi Djakov
2021-03-02 3:47 ` [PATCH V9 04/12] soc: mediatek: add support for mt6873 Henry Chen
2021-03-02 3:47 ` [PATCH V9 05/12] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2021-03-02 3:47 ` [PATCH V9 06/12] arm64: dts: mt8192: " Henry Chen
2021-03-02 3:47 ` [PATCH V9 07/12] dt-bindings: interconnect: add MT6873 interconnect dt-bindings Henry Chen
2021-03-08 18:39 ` Rob Herring
2021-03-02 3:47 ` [PATCH V9 08/12] interconnect: mediatek: Add interconnect provider driver Henry Chen
2021-03-18 9:14 ` Georgi Djakov [this message]
2021-03-02 3:47 ` [PATCH V9 09/12] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2021-03-02 3:47 ` [PATCH V9 10/12] arm64: dts: mt8192: " Henry Chen
2021-03-02 3:47 ` [PATCH V9 11/12] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
2021-03-02 3:47 ` [PATCH V9 12/12] arm64: dts: mt8192: " Henry Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1d4ea2-22f6-e962-07bc-815ce73b2cb9@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=arvin.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=fan.chen@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).