From: "Nuno Sá" <noname.nuno@gmail.com>
To: Alisa-Dariana Roman <alisadariana@gmail.com>,
Alisa-Dariana Roman <alisa.roman@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v7 2/4] iio: adc: ad7192: Update clock config
Date: Thu, 18 Jul 2024 16:08:33 +0200 [thread overview]
Message-ID: <cc1d58f9ca652dff81ffda0af2329cc673e888fb.camel@gmail.com> (raw)
In-Reply-To: <20240717212535.8348-3-alisa.roman@analog.com>
On Thu, 2024-07-18 at 00:25 +0300, Alisa-Dariana Roman wrote:
> There are actually 4 configuration modes of clock source for AD719X
> devices. Either a crystal can be attached externally between MCLK1 and
> MCLK2 pins, or an external CMOS-compatible clock can drive the MCLK2
> pin. The other 2 modes make use of the 4.92MHz internal clock.
>
> Undocumented properties adi,int-clock-output-enable and adi,clock-xtal
> still supported for backward compatibility, but their use is highly
> discouraged. Use cleaner alternative of configuring external clock by
> using clock names mclk and xtal.
>
> Functionality of AD7192_CLK_INT_CO will be implemented in complementary
> patch by adding clock provider.
>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> ---
LGTM,
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
next prev parent reply other threads:[~2024-07-18 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 21:25 [PATCH v7 0/4] iio: adc: adc7192: Improvements Alisa-Dariana Roman
2024-07-17 21:25 ` [PATCH v7 1/4] dt-bindings: iio: adc: ad7192: Update clock config Alisa-Dariana Roman
2024-07-17 21:25 ` [PATCH v7 2/4] " Alisa-Dariana Roman
2024-07-18 14:08 ` Nuno Sá [this message]
2024-07-17 21:25 ` [PATCH v7 3/4] dt-bindings: iio: adc: ad7192: Add clock provider Alisa-Dariana Roman
2024-07-18 15:14 ` Conor Dooley
2024-07-20 13:42 ` Jonathan Cameron
2024-07-21 13:35 ` Alisa-Dariana Roman
2024-07-22 19:46 ` Jonathan Cameron
2024-07-17 21:25 ` [PATCH v7 4/4] " Alisa-Dariana Roman
2024-07-18 14:11 ` Nuno Sá
2024-07-20 13:44 ` Jonathan Cameron
2024-07-17 21:36 ` [PATCH v7 0/4] iio: adc: adc7192: Improvements Alisa-Dariana Roman
2024-07-20 13:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1d58f9ca652dff81ffda0af2329cc673e888fb.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).