From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330B3C433EF for ; Tue, 12 Apr 2022 12:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354012AbiDLMVP (ORCPT ); Tue, 12 Apr 2022 08:21:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356222AbiDLMTj (ORCPT ); Tue, 12 Apr 2022 08:19:39 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB4222F; Tue, 12 Apr 2022 04:24:07 -0700 (PDT) X-UUID: d52c9a3afb984682af61dc8ceae6b463-20220412 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:da2e59b6-cda6-484b-ab3f-d7ca1d2f473f,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.4,REQID:da2e59b6-cda6-484b-ab3f-d7ca1d2f473f,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:faefae9,CLOUDID:7baee6a8-d103-4e36-82b9-b0e86991b3df,C OID:IGNORED,Recheck:0,SF:13|15|28|17|19|48,TC:nil,Content:0,EDM:-3,File:ni l,QS:0,BEC:nil X-UUID: d52c9a3afb984682af61dc8ceae6b463-20220412 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 615625054; Tue, 12 Apr 2022 19:24:03 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Tue, 12 Apr 2022 19:24:02 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 12 Apr 2022 19:24:02 +0800 Message-ID: Subject: Re: [PATCH V2 12/15] cpufreq: mediatek: Use maximum voltage in init stage From: Rex-BC Chen To: AngeloGioacchino Del Regno , , , , CC: , , , , , , , , , Date: Tue, 12 Apr 2022 19:24:02 +0800 In-Reply-To: <5f788a8f-7092-19ca-8499-d3626c4a386d@collabora.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-13-rex-bc.chen@mediatek.com> <5f788a8f-7092-19ca-8499-d3626c4a386d@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 2022-04-08 at 15:37 +0200, AngeloGioacchino Del Regno wrote: > Il 08/04/22 06:59, Rex-BC Chen ha scritto: > > From: Jia-Wei Chang > > > > Two or more clients may use the same regulator, and it could cause > > the > > issue of high-freqeuncy-low-voltage. > > To prevent this, we use maximum voltage in > > mtk_cpu_dvfs_info_init(). > > > > Signed-off-by: Jia-Wei Chang > > Is this happening for proc-supply (proc_reg)? > ...because it looks like it is, so you should send this commit > separately > and with an appropriate Fixes: tag. Hello Angelo, The commit message is not clear. The clients are cpufreq and mediatek cci. I think there is no any error before introducing mediatek cci into cpufreq. The order of this patch should be after "cpufreq: mediatek: Link CCI device to CPU". If so, I will also correct the commit message in next version. BRs, Rex